From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B912EECAAD3 for ; Mon, 19 Sep 2022 18:14:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4ZOT/ZWnORZakn8khRwgQOFehBiVBbcGS2HS4lQ9EzY=; b=aHLnStgqq3Vyye +qKbcN71rc3LyMax1KscA34kxiWPtuAFjkRXijIPmmciq04oJmKF1IitqAU6AZqek/9+7pGFPUfa/ o8+AcZhcznXIcDYDvVX5c6flaYPq8OALRP11EGceu6hd871R44GJz1v4HaC9X6sSmmP5U4tQT/Zin uKAq5KDFAR8M8jMpIyEK9SNxoC19vPPBMAUnRlfwElT/lGUSYDzxHc6PoU+uLmr25Jn/ezCvNxnkh n0jqGhuFZr0V/dftf7/NIUMNmGcetzCGeQpGQgQsYvyZ5p/VYIaglP6E75blBIt6pc2JUKL3OuLVr zzwBd07lTT5uC8cSps9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaLGm-00De5p-Nf; Mon, 19 Sep 2022 18:13:26 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaLGc-00Ddrw-ND for linux-arm-kernel@lists.infradead.org; Mon, 19 Sep 2022 18:13:18 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D75BCB81BBA; Mon, 19 Sep 2022 18:12:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86B2AC433D6; Mon, 19 Sep 2022 18:12:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663611177; bh=aotGmVArsuGPUXjbMK5fSz2bHP43nLY4BmMcFqGhkA0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PIti6DE+/vLrtxuf3lyhD9TkvPjirGE64SUHAt4+noudLDqN/KwiCCoP63Le3o1xe 8CX72L5XHFGUlLCp+TwL1xWC5ClDkY/0Fz6crMIbtpJvYey3dZDMOGgGPIH7ijUW22 NlI83YyNxRl/G0w46oyNPQ5Ai/N5yg6DCpmOOfs73scABtF65UwPUtrnCcqGM3H8bv hEkGfi+dUR4GllyRnbBWXo+OxpTuh+Hdu3fJIDyPBK/ACE2+7bpHqwov0mK6ZXHbKX HxVgFB3hsx73ofnYj90DVaPL7YKhxc92YaAHLlZZbq1i9I/nz6ld8ZcGOPtzwi2O3k sQdxSD9BDCrvQ== Received: from 185-176-101-241.host.sccbroadband.ie ([185.176.101.241] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oaLGJ-00BBPO-7G; Mon, 19 Sep 2022 19:12:55 +0100 Date: Mon, 19 Sep 2022 19:12:53 +0100 Message-ID: <878rmfkzbu.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas Cc: kernel test robot , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kbuild-all@lists.01.org, Cornelia Huck , Will Deacon , Evgenii Stepanov , kvm@vger.kernel.org, Steven Price , Vincenzo Frascino Subject: Re: [PATCH v3 3/7] mm: Add PG_arch_3 page flag In-Reply-To: References: <20220810193033.1090251-4-pcc@google.com> <202208111500.62e0Bl2l-lkp@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.176.101.241 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, lkp@intel.com, pcc@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kbuild-all@lists.01.org, cohuck@redhat.com, will@kernel.org, eugenis@google.com, kvm@vger.kernel.org, steven.price@arm.com, vincenzo.frascino@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220919_111315_084879_4BC891E4 X-CRM114-Status: GOOD ( 38.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 05 Sep 2022 18:01:55 +0100, Catalin Marinas wrote: > > On Thu, Sep 01, 2022 at 06:59:23PM +0100, Catalin Marinas wrote: > > On Thu, Aug 11, 2022 at 03:16:08PM +0800, kernel test robot wrote: > > > Thank you for the patch! Perhaps something to improve: > > > > > > [auto build test WARNING on arm64/for-next/core] > > > [also build test WARNING on linus/master next-20220811] > > > [cannot apply to kvmarm/next arm/for-next soc/for-next xilinx-xlnx/master v5.19] > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > And when submitting patch, we suggest to use '--base' as documented in > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > > > url: https://github.com/intel-lab-lkp/linux/commits/Peter-Collingbourne/KVM-arm64-permit-MAP_SHARED-mappings-with-MTE-enabled/20220811-033310 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core > > > config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20220811/202208111500.62e0Bl2l-lkp@intel.com/config) > > > compiler: loongarch64-linux-gcc (GCC) 12.1.0 > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://github.com/intel-lab-lkp/linux/commit/1a400517d8428df0ec9f86f8d303b2227ee9702f > > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > > git fetch --no-tags linux-review Peter-Collingbourne/KVM-arm64-permit-MAP_SHARED-mappings-with-MTE-enabled/20220811-033310 > > > git checkout 1a400517d8428df0ec9f86f8d303b2227ee9702f > > > # save the config file > > > mkdir build_dir && cp config build_dir/.config > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash > > > > > > If you fix the issue, kindly add following tag where applicable > > > Reported-by: kernel test robot > > > > > > All warnings (new ones prefixed by >>): > > > > > > >> mm/memory.c:92:2: warning: #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. [-Wcpp] > > > 92 | #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. > > > | ^~~~~~~ > > > > > > > > > vim +92 mm/memory.c > > > > > > 42b7772812d15b Jan Beulich 2008-07-23 90 > > > af27d9403f5b80 Arnd Bergmann 2018-02-16 91 #if defined(LAST_CPUPID_NOT_IN_PAGE_FLAGS) && !defined(CONFIG_COMPILE_TEST) > > > 90572890d20252 Peter Zijlstra 2013-10-07 @92 #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. > > > 75980e97daccfc Peter Zijlstra 2013-02-22 93 #endif > > > 75980e97daccfc Peter Zijlstra 2013-02-22 94 > > > > It looks like ith CONFIG_NUMA_BALANCING=y on loongarch we run out of > > spare bits in page->flags to fit last_cpupid. The reason we don't see it > > on arm64 is that we select SPARSEMEM_VMEMMAP and SECTIONS_WIDTH becomes > > 0. On loongarch SECTIONS_WIDTH takes 19 bits (48 - 29) in page->flags. > > > > I think instead of always defining PG_arch_{2,3} if CONFIG_64BIT, we > > could add a CONFIG_ARCH_WANTS_PG_ARCH_23 option and only select it on > > arm64 for the time being. > > I pushed a patch as the first one on the arm64 devel/mte-pg-flags > branch. Also updated the last patch on this branch following Steven's > comments. > > Peter, please let me know if you want to pick this series up together > with your other KVM patches. Otherwise I can post it separately, it's > worth merging it on its own as it clarifies the page flag vs tag setting > ordering. I'm looking at queuing this, but I'm confused by this comment. Do I need to pick this as part of the series? Or is this an independent thing (my hunch is that it is actually required not to break other architectures...). Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel