From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26ADEC0650E for ; Mon, 8 Jul 2019 01:15:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E489F204EC for ; Mon, 8 Jul 2019 01:15:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="moUtEP/i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E489F204EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LmWy1nmakhJmzmOWwgnuFssWvc9oisBJ6k4D9+jFNGo=; b=moUtEP/ijxKe5h o9MOd7rRk/tUoNue62mevjzFqfD7msnnsS7pzTGci6bfMsd1Twv3QEv2XvnGf7AMZKMreUFrnopsf HjX3icmukzVy+3dr6B5qCI+5lBIEnT4MZlzjEpb2V9W82wKZGWiRAjQzyiyjLM+MYEWgo4Ik0Homt 5k3oS3S8OYnPGyYGBWWV0z0R8vnBbEP090kDQd3xh/do+m5zWhmbEYnAvaNuDVZkM2ZHsYGWw774m 4wLqyskAy5HdounxguoKvPVzATnHduW37YrI7IOpvD73T4cKQzWpEWukg930/xfOsrzkJvg7po20y hlDePexBw0dXwWfFn1Tw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hkIG0-0000V7-Ja; Mon, 08 Jul 2019 01:15:52 +0000 Received: from ozlabs.org ([203.11.71.1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hkIFx-0000Te-F8 for linux-arm-kernel@lists.infradead.org; Mon, 08 Jul 2019 01:15:51 +0000 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 45hnZJ0R8Jz9sN4; Mon, 8 Jul 2019 11:15:35 +1000 (AEST) From: Michael Ellerman To: Aleksa Sarai , Al Viro , Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , David Howells , Shuah Khan , Shuah Khan Subject: Re: [PATCH v9 10/10] selftests: add openat2(2) selftests In-Reply-To: <20190706145737.5299-11-cyphar@cyphar.com> References: <20190706145737.5299-1-cyphar@cyphar.com> <20190706145737.5299-11-cyphar@cyphar.com> Date: Mon, 08 Jul 2019 11:15:35 +1000 Message-ID: <878st9iax4.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190707_181549_671214_A527BDCD X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Alexei Starovoitov , Oleg Nesterov , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Tycho Andersen , Aleksa Sarai , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-xtensa@linux-xtensa.org, Kees Cook , Jann Horn , linuxppc-dev@lists.ozlabs.org, Aleksa Sarai , Andy Lutomirski , David Drysdale , Christian Brauner , linux-parisc@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-api@vger.kernel.org, Chanho Min , linux-kernel@vger.kernel.org, Eric Biederman , linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Linus Torvalds , containers@lists.linux-foundation.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Aleksa, A few minor comments below. Aleksa Sarai writes: > diff --git a/tools/testing/selftests/openat2/Makefile b/tools/testing/selftests/openat2/Makefile > new file mode 100644 > index 000000000000..8235a49928f6 > --- /dev/null > +++ b/tools/testing/selftests/openat2/Makefile > @@ -0,0 +1,12 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +CFLAGS += -Wall -O2 -g > +TEST_GEN_PROGS := linkmode_test resolve_test rename_attack_test > + > +include ../lib.mk > + > +$(OUTPUT)/linkmode_test: linkmode_test.c helpers.o > +$(OUTPUT)/rename_attack_test: rename_attack_test.c helpers.o > +$(OUTPUT)/resolve_test: resolve_test.c helpers.o You don't need to tell make that foo depends on foo.c. Also if you make the dependency be on helpers.c then you won't get an intermediate helpers.o, and then you don't need to clean it. So the above three lines could just be: $(TEST_GEN_PROGS): helpers.c > +EXTRA_CLEAN = helpers.o $(wildcard /tmp/ksft-openat2-*) If you follow my advice above you don't need helpers.o in there. Deleting things from /tmp is also a bit fishy on shared machines, ie. it will error if those files happen to be owned by another user. cheers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel