From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FD24C4332F for ; Thu, 22 Dec 2022 10:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u4BCYfl0UoTudGugRwppCTUxcItx+Hpzjkm8nc6jLMI=; b=rKGuPPQ3gJqhIH RHlLg7PlhMJX3FUmfLXjQ/oR0laGYDmyiuMQ7/dMxFEC5nNTUHdfJFAxNixFJZN3AOulB2U5CEUBc 9eQ3s2ahNAKUJ943jMSRCiFMmIIvH5mCogcHZjBJmUEmRMCbsjFFArUI/4CGmVoPLdybIo6tj1ore 4B6HlrbqAKyGl9nbLVtAKjGwAalhMruv8U+gJq1wGKwnnmJdhPVFA4iBd/Wdgsc1U58wQImmFZWZE lzqIxn1VVyMu4fyGLnR2u7pq54ace6xgMwqe9/V4TFK58YRA5U4GgpiBZVOHQstiUOi8Q4svdH/NZ TsFl5G2chyT1rA3g6hfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8In0-00AJBY-Fp; Thu, 22 Dec 2022 10:27:02 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8ImB-00AIo1-QZ for linux-arm-kernel@lists.infradead.org; Thu, 22 Dec 2022 10:26:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B6E861A3C; Thu, 22 Dec 2022 10:26:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB2C3C433D2; Thu, 22 Dec 2022 10:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671704770; bh=rEaTjHoGaG/GmLeHAgYZZfzKQ7QMGfKquTO4exPzJEI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=V5oHZpUdJDz4/HkJZNzeeG0n80vHBGofnb1Q0GsTAj6AS+i5XQjwQn1TGHqUivJ+W ExkCuxkIN3YAxwyRUVkfXUVcUg1dmDaGEDxHenCPAx2vJzXhqSzmbRz2baDp5Tp2TB zMyuqxP7bcks2x/DxIqIxmvq3eixAO7T1GQMi2c8K33g7wWkA8M2HlHVGurH9nBvup Ya7UOmOp9wlrE6MtntrmvUfjKXu1L+Ss6LDNfoUdehCMWmGhiiDtLwP/umYvVf9Mpv Lvssx4BTSG28nHi82vbCHtoXEeih2ghkIn6UhTFs0saWdrA2Bpz1hjiPdsB4E083CU 7WckAzLyIjPhA== Message-ID: <879325d2-4b2d-bc1d-310c-ece4c449ad8f@kernel.org> Date: Thu, 22 Dec 2022 11:26:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RFC PATCH 3/7] dt-bindings: bus: add STM32MP15 ETZPC firewall bus bindings Content-Language: en-US To: Gatien Chevallier , alexandre.torgue@foss.st.com, robh+dt@kernel.org, Oleksii_Moisieiev@epam.com, linus.walleij@linaro.org, gregkh@linuxfoundation.org Cc: linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loic.pallardy@st.com, devicetree@vger.kernel.org, mark.rutland@arm.com, arnd@arndb.de References: <20221221173055.11719-1-gatien.chevallier@foss.st.com> <20221221173055.11719-4-gatien.chevallier@foss.st.com> From: Krzysztof Kozlowski In-Reply-To: <20221221173055.11719-4-gatien.chevallier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221222_022612_159109_BB968FC4 X-CRM114-Status: GOOD ( 15.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/12/2022 18:30, Gatien Chevallier wrote: > Adds the list of peripherals IDs under firewall bus on STM32MP15. > > Signed-off-by: Gatien Chevallier > --- > include/dt-bindings/bus/stm32mp15_sys_bus.h | 98 +++++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 include/dt-bindings/bus/stm32mp15_sys_bus.h > > diff --git a/include/dt-bindings/bus/stm32mp15_sys_bus.h b/include/dt-bindings/bus/stm32mp15_sys_bus.h > new file mode 100644 > index 000000000000..97eacc7b5f16 > --- /dev/null > +++ b/include/dt-bindings/bus/stm32mp15_sys_bus.h That's wrong in multiple ways: 1. No underscores 2. Missing vendor prefix 3. Name not matching compatible. > @@ -0,0 +1,98 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (C) STMicroelectronics 2022 - All Rights Reserved > + */ > +#ifndef _DT_BINDINGS_BUS_STM32MP15_SYS_BUS_H > +#define _DT_BINDINGS_BUS_STM32MP15_SYS_BUS_H > + > +/* ETZPC IDs */ > +#define STM32MP1_ETZPC_STGENC_ID 0 > +#define STM32MP1_ETZPC_BKPSRAM_ID 1 > +#define STM32MP1_ETZPC_IWDG1_ID 2 > +#define STM32MP1_ETZPC_USART1_ID 3 > +#define STM32MP1_ETZPC_SPI6_ID 4 > +#define STM32MP1_ETZPC_I2C4_ID 5 > +/* ID 6 reserved */ Reserved why? These are IDs so they start from 0 and go by 0. Don't hard-code some register offsets. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel