From: Marc Zyngier <maz@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM
BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...),
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org (moderated list:ARM
SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS),
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE)
Subject: Re: [PATCH v5 01/14] irqchip: Provide platform_device to of_irq_init_cb_t
Date: Wed, 20 Oct 2021 11:56:06 +0100 [thread overview]
Message-ID: <87a6j4c6d5.wl-maz@kernel.org> (raw)
In-Reply-To: <20211019215855.1920099-2-f.fainelli@gmail.com>
AOn Tue, 19 Oct 2021 22:58:42 +0100,
Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> Provide the platform device mapping to the interrupt controller node to
> the of_irq_init_cb_t callback such that drivers can make use of it.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/irqchip/irqchip.c | 2 +-
> drivers/irqchip/qcom-pdc.c | 3 ++-
> drivers/of/irq.c | 2 +-
> include/linux/of_irq.h | 5 ++++-
> 4 files changed, 8 insertions(+), 4 deletions(-)
>
[...]
> diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h
> index aaf219bd0354..89acc8b089f0 100644
> --- a/include/linux/of_irq.h
> +++ b/include/linux/of_irq.h
> @@ -9,7 +9,10 @@
> #include <linux/ioport.h>
> #include <linux/of.h>
>
> -typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *);
> +struct platform_device;
> +
> +typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *,
> + struct platform_device *);
>
> /*
> * Workarounds only applied to 32bit powermac machines
As pointed out in my reply to your v4 [1], this does break all users
of IRQCHIP_DECLARE(). You can see that by applying [2].
M.
[1] https://lore.kernel.org/r/87tuhcnlwt.wl-maz@kernel.org
[2] https://lore.kernel.org/r/20211020104527.3066268-1-maz@kernel.org
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-20 10:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 21:58 [PATCH v5 00/14] Modular Broadcom irqchip drivers Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 01/14] irqchip: Provide platform_device to of_irq_init_cb_t Florian Fainelli
2021-10-20 10:56 ` Marc Zyngier [this message]
2021-10-19 21:58 ` [PATCH v5 02/14] MIPS: BMIPS: Remove use of irq_cpu_offline Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 03/14] irqchip/irq-bcm7038-l1: Remove .irq_cpu_offline() Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 04/14] irqchip/irq-bcm7038-l1: Use irq_get_irq_data() Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 05/14] irqchip/irq-bcm7038-l1: Gate use of CPU logical map to MIPS Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 06/14] irqchip/irq-bcm7038-l1: Restrict affinity setting " Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 07/14] irqchip/irq-bcm7038-l1: Switch to IRQCHIP_PLATFORM_DRIVER Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 08/14] genirq: Export irq_gc_{unmask_enable, mask_disable}_reg Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 09/14] irqchip/irq-brcmstb-l2: Switch to IRQCHIP_PLATFORM_DRIVER Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 10/14] genirq: Export irq_gc_noop() Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 11/14] irqchip/irq-bcm7120-l2: Switch to IRQCHIP_PLATFORM_DRIVER Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 12/14] arm64: broadcom: Removed forced select of interrupt controllers Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 13/14] ARM: bcm: " Florian Fainelli
2021-10-19 21:58 ` [PATCH v5 14/14] irqchip: Fix kernel-doc parameter typo for IRQCHIP_DECLARE Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6j4c6d5.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).