From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Marek Behún" <kabel@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, pali@kernel.org,
"Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH mvebu-dt] ARM: dts: turris-omnia: Fix mpp26 pin name and comment
Date: Fri, 02 Sep 2022 15:58:49 +0200 [thread overview]
Message-ID: <87bkrxg9nq.fsf@BL-laptop> (raw)
In-Reply-To: <20220727125610.20782-1-kabel@kernel.org>
Marek Behún <kabel@kernel.org> writes:
> There is a bug in Turris Omnia's schematics, whereupon the MPP[26] pin,
> which is routed to CN11 pin header, is documented as SPI CS1, but
> MPP[26] pin does not support this function. Instead it controls chip
> select 2 if in "spi0" mode.
>
> Fix the name of the pin node in pinctrl node and fix the comment in SPI
> node.
>
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Marek Behún <kabel@kernel.org>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4878df39753..487dece2033c 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -478,7 +478,7 @@ spi0cs0_pins: spi0cs0-pins {
> marvell,function = "spi0";
> };
>
> - spi0cs1_pins: spi0cs1-pins {
> + spi0cs2_pins: spi0cs2-pins {
> marvell,pins = "mpp26";
> marvell,function = "spi0";
> };
> @@ -513,7 +513,7 @@ partition@100000 {
> };
> };
>
> - /* MISO, MOSI, SCLK and CS1 are routed to pin header CN11 */
> + /* MISO, MOSI, SCLK and CS2 are routed to pin header CN11 */
> };
>
> &uart0 {
> --
> 2.35.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-02 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 12:56 [PATCH mvebu-dt] ARM: dts: turris-omnia: Fix mpp26 pin name and comment Marek Behún
2022-09-02 13:58 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkrxg9nq.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=kabel@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).