From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CB17C54E94 for ; Sat, 21 Jan 2023 21:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0C2ghnisHvQi9ni5Bn10R3sHY1R1NHrv4kWmfiKkrcc=; b=RyMe7JjRcXm6sZ Ohu1dn62Y7Y1yQwaC3CKZL6dQ3oPEFt/4ef3u3zVjo4tzVBe3OPeggVObQotY92FSQ0NUnHDoIRlZ Q1rb1PV/lkFHlOEaPm4r28TofMy/DPakV2Gu/v9BMPrDafaL6/ak5rLnnIRKb4JV4JFi/ORsUslNF Pwao6HCFRcXeOy++sCdKWH5aH8lwzsts3DeiVje+UqW3SJr0JuNeUaqLua2KR/w//mL4XNGF8cCNi Ud32oql9djH8vICXLSO2yQYnpvHS2cWsszs1mLYBQlckXW/7FW1XFi4dOcXP/2EK9vVFsUtc3iCX2 tY5q0NPLp2P51kTb38CA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJL2s-00EWfl-N4; Sat, 21 Jan 2023 21:05:02 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJL2o-00EWfB-Iw for linux-arm-kernel@lists.infradead.org; Sat, 21 Jan 2023 21:04:59 +0000 Received: by mail-ej1-x62c.google.com with SMTP id mp20so21899010ejc.7 for ; Sat, 21 Jan 2023 13:04:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=aPa+6EK8AKVSjpuJR3mx7O0BaY8v3OeMxyFJexLfe8s=; b=N/U4JY9pmKH6wk/jUD27yjs7prEI9IXwjaACYeK0/up+EJT1X8wGW94obDSQTVbpOo 6kGqxqojEd+Dqvkpyhm+Yu765K9vCgu/s/Uo6ktZ+JJaUjTO85WWt0iyLJetU5QsEFFR tM5IrPxkXU+/nROh+oH5KkRJ99dA/S4oCkSrsLatM9YTwsJmLI+5Te+RRR54j0a8HOY4 co7joIQSN+QMBXhEVpwtPjw5yCDZoheZimEdVz3pI4LRFCwdErydaG+N4jVWVb2OP6KI uvuZBHnVGXoCLPSaSLDx0XpvQGxVxCfoZmQEfjZCG9eHApnBihtg1R8AO6uzUbSdvc0B 31pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aPa+6EK8AKVSjpuJR3mx7O0BaY8v3OeMxyFJexLfe8s=; b=YZktomGXj+IE1LOUb3u7JEO7ghPzbrJbhWue0IBb5O0X9eO4HTkPkuvotpH38+GSxd zsnjt10mzJTMvhrLYFNEjNPPD0M7PdYG95I9lbQpJZV1jdA592kNJ7cJnM4PNm2fU4EI a3u5dqWdNdRpk9YkNDCQEN6UElE4dHoC45L8BOBkmQGBx7p86OP43jBlGRJb5c7ZQqUT ujMxLWcZHuaDfAaUHRe38L9JYmsrd/FODl3BlWqB87/TfET245gFO1/m2KpHhKgmjoUv r6pzHCrERGSICnvOX6MrCzIUI+hSSwrRs9HMvbvUsH3Ok5IhYxACEtebAyGeGd6C7bgq azuQ== X-Gm-Message-State: AFqh2kq6HQTegNP9BrNAEoMbQNXPgQtH3w/lYaB4bcoCkFiKxK45dFcm t5BJJNifcBRYTnLBJP5i0LM= X-Google-Smtp-Source: AMrXdXtZ3opKlzpSg8/onoS+2wKmXlH6Kai+xR9iPu81bFxVOKaPAkS7AqSSBQK6iH1dBUKNbBD3ug== X-Received: by 2002:a17:906:5a5c:b0:877:593a:58ef with SMTP id my28-20020a1709065a5c00b00877593a58efmr15119384ejc.77.1674335096784; Sat, 21 Jan 2023 13:04:56 -0800 (PST) Received: from osv.localdomain ([89.175.180.246]) by smtp.gmail.com with ESMTPSA id 20-20020a170906101400b0085ff05d5dbdsm14519224ejm.173.2023.01.21.13.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Jan 2023 13:04:56 -0800 (PST) From: Sergey Organov To: Stefan Wahren Cc: linux-serial@vger.kernel.org, Fabio Estevam , Greg Kroah-Hartman , Jiri Slaby , Richard Genoud , Sascha Hauer , Shawn Guo , Tim Harvey , Tomasz =?utf-8?Q?Mo=C5=84?= , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Johan Hovold , Ilpo =?utf-8?Q?J=C3=A4rvinen?= , Sherry Sun , linux-arm-kernel@lists.infradead.org, NXP Linux Team , Pengutronix Kernel Team Subject: Re: [PATCH v1 3/7] serial: imx: do not sysrq broken chars References: <87bko4e65y.fsf@osv.gnss.ru> <20230121153639.15402-1-sorganov@gmail.com> <20230121153639.15402-4-sorganov@gmail.com> <6dc81996-6ffc-c1bc-6c3f-ca65055c94a2@i2se.com> Date: Sun, 22 Jan 2023 00:04:54 +0300 In-Reply-To: <6dc81996-6ffc-c1bc-6c3f-ca65055c94a2@i2se.com> (Stefan Wahren's message of "Sat, 21 Jan 2023 17:12:07 +0100") Message-ID: <87fsc3wqdl.fsf@osv.gnss.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230121_130458_679624_1D28C6F8 X-CRM114-Status: GOOD ( 11.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, Stefan Wahren writes: > Hi Sergey, > > Am 21.01.23 um 16:36 schrieb Sergey Organov: >> Do not call uart_handle_sysrq_char() if we got any receive error >> along with the character, as we don't want random junk to be >> considered a sysrq. >> Signed-off-by: Sergey Organov > > this looks like a bugfix to me. Since the relevant code is pretty old, > i'm not sure about the fixes tag here: > > Fixes: 279a9acc9b72 ("2.6.11 import") ? Dunno. I've checked a few drivers, and it seems that they don't care either, e.g., look at atmel_serial.c, or mpc52xx_uart.c. Either it doesn't matter, or a few drivers need similar fix? What's going on here, I wonder? Thanks, -- Sergey Organov _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel