From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07219C07E96 for ; Thu, 8 Jul 2021 08:18:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABB1861CE0 for ; Thu, 8 Jul 2021 08:18:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABB1861CE0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8g7vN5T9xGonzkPiCq3Ca7pnIB8eOJNQIU7tdGGUIgA=; b=st6gw6iVMf4czX Gd4s+sCb2sf44pqiBBSpOD6LVAznFE4kS2eteeAeTRdZuox7+SsqGlyX+sst0RIkwBD40BjWGl5WP /BKPYYnGezY6LaQRMuJpOX6vR4mzoztbtfkLaXSTZ4G7RGlh904gJuDASsn2Yy/tljsFRUWqxfvoj mAuwAsqibAZYpid0VPiZFWUNwcKUOCmMxgHI9ZRE7SwgbGKSWWESaTLw8w8pnD6Uf3fTu1PBPbUpi 0gMQfH/BmXrIvgxCzS+I5ppae9hqUZaG8C9hOMHgBaFXFWe/uNvttX9jNWVN4dV5Zdy7SvQzsdqIa pQLUm/8WQVcmK7HPZB0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1PD4-00GI0D-0S; Thu, 08 Jul 2021 08:16:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1PD0-00GHyQ-FX; Thu, 08 Jul 2021 08:16:35 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8C7F61CE0; Thu, 8 Jul 2021 08:16:33 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m1PCx-00C2yG-Dc; Thu, 08 Jul 2021 09:16:31 +0100 Date: Thu, 08 Jul 2021 09:16:21 +0100 Message-ID: <87h7h52pbe.wl-maz@kernel.org> From: Marc Zyngier To: Markus Schneider-Pargmann Cc: Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip: mtk-sysirq: Skip setting irq-wake In-Reply-To: <20210707124932.szw7zud63fl7xn6i@blmsp> References: <20210707062004.782787-1-msp@baylibre.com> <87sg0q77fc.wl-maz@kernel.org> <20210707124932.szw7zud63fl7xn6i@blmsp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: msp@baylibre.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210708_011634_612600_29E673C9 X-CRM114-Status: GOOD ( 28.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 07 Jul 2021 13:49:32 +0100, Markus Schneider-Pargmann wrote: > > Hi Marc, > > On Wed, Jul 07, 2021 at 11:19:19AM +0100, Marc Zyngier wrote: > > Hi Markus, > > > > On Wed, 07 Jul 2021 07:20:04 +0100, > > Markus Schneider-Pargmann wrote: > > > > > > mtk-sysirq doesn't require specific logic to work with wakeup IRQs. To > > > allow registered IRQs to be used as a wakeup-source, add the flag > > > IRQCHIP_SKIP_SET_WAKE. > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > --- > > > drivers/irqchip/irq-mtk-sysirq.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c > > > index 6ff98b87e5c0..586e52d5442b 100644 > > > --- a/drivers/irqchip/irq-mtk-sysirq.c > > > +++ b/drivers/irqchip/irq-mtk-sysirq.c > > > @@ -65,6 +65,7 @@ static struct irq_chip mtk_sysirq_chip = { > > > .irq_set_type = mtk_sysirq_set_type, > > > .irq_retrigger = irq_chip_retrigger_hierarchy, > > > .irq_set_affinity = irq_chip_set_affinity_parent, > > > + .flags = IRQCHIP_SKIP_SET_WAKE, > > > }; > > > > > > static int mtk_sysirq_domain_translate(struct irq_domain *d, > > > > Is this a fix? If so, please provide a Fixes: tag matching the commit > > it addresses. Add a Cc stable if this requires backporting. > > At least from my point of view I would like to prepare the mtk-sysirq > for powermanagement stuff, so not a fix. There may be some components > trying to use this already but I would consider this more of a feature > as it has probably never worked before. Fair enough. I'll keep that for 5.15 then. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel