From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44824CA9EC5 for ; Wed, 30 Oct 2019 21:11:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1080B20856 for ; Wed, 30 Oct 2019 21:11:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p6X/qpfQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1080B20856 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dUsb2IvsrWc4DLNScJr/aLNklmVYrzGgM4BJeV/O/bA=; b=p6X/qpfQ3h4B9+ JHiGfuexLmTJE/hcSKoCt3y/4ArffuAqoZs9XdrHdXFPyMpuUg7Dtubwt9KpOPHJpcxnhsu1EvY1m EEwbUwr8L7peGVGkdIQVYZKgcr8rQGj+eu3a7aWqNnQoDalAoc9f2YiyzLvGbdm8wyHuj6kH2fX4Y Hp2T0hJ1NkgEG0munw1mBT3BVpsI8gQGktLrvaOqDczc9MiipkQeqN5YtbEc2n1MPCnbQJUdkyl0+ BnA3TM/wHgA8Cxu8M/dqmtulMzlwBNDH9d7vo6DEZVMQFhCpSFdwwYsmSG+9fTTn/XEXtrSsMQjtX /z+M9qQcxzGXxTU+weiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPvF3-0006wy-Ej; Wed, 30 Oct 2019 21:10:57 +0000 Received: from smtp08.smtpout.orange.fr ([80.12.242.130] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPvF0-0006wW-Iz for linux-arm-kernel@lists.infradead.org; Wed, 30 Oct 2019 21:10:56 +0000 Received: from belgarion ([90.55.204.252]) by mwinf5d15 with ME id KxAo210045TFNlm03xAoN2; Wed, 30 Oct 2019 22:10:52 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 30 Oct 2019 22:10:52 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann Subject: Re: [PATCH 38/46] video: backlight: tosa: use gpio lookup table References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-38-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 30 Oct 2019 22:10:48 +0100 In-Reply-To: <20191018154201.1276638-38-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:53 +0200") Message-ID: <87h83qlz1j.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191030_141054_907858_036F76EF X-CRM114-Status: GOOD ( 17.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Jingoo Han , Linus Walleij , linux-kernel@vger.kernel.org, Haojian Zhuang , Daniel Mack , linux-fbdev@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Arnd Bergmann writes: > The driver should not require a machine specific header. Change > it to pass the gpio line through a lookup table, and move the > timing generator definitions into the drivers itself. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Signed-off-by: Arnd Bergmann > > --- > I'm not overly confident that I got the correct device names > for the lookup table, it would be good if someone could > double-check. Ah the I2C and SPI devices querrying GPIOs ... unless someone does an actual test, this will probably be very regression prone ... Anyway : Acked-by: Robert Jarzmik Cheers. -- Robert _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel