From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01551C433DB for ; Mon, 22 Mar 2021 14:07:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D86661931 for ; Mon, 22 Mar 2021 14:07:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D86661931 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5aM/8Jxg6eS5GdR3y05oWk1tv+/Oj8Ka+0H3Z6DDyYI=; b=e4A8zTgoHCQDUiSkJjrTgTAoo 2Nu2mvxRdh3Dg+X37GKLukz8nBa/F7x2jgfGUofOJdzWL0Z5Ovnn+z/7c8KLG+fqz+oGNQiikmmQK eZoy47By+y3EO+9Xyl3yeTHM6Bhr3aaffnuLt5FOoe9BzHvG9x7kXRB9IZpH4KEEt+486zB+c5gSE 2vOpUWoRWNun3qa0zg+bz32ovFIUr9ft1ZeT5SiohWhpHoqZLEsJPNVe6qON/8riqQXz6qCAxit8/ XFT2t+aue8NCya1a71hORMxfOhm+0OzwzdrjBJzbvcPbqq96uUmrmWiS8PH75JsyXOzzce2z+IkBP 5TZn32pzg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOLBL-00BlMX-3Z; Mon, 22 Mar 2021 14:05:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOLAq-00BlCy-Vj; Mon, 22 Mar 2021 14:04:57 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6109E6198E; Mon, 22 Mar 2021 14:04:51 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lOLAn-00351e-8A; Mon, 22 Mar 2021 14:04:49 +0000 Date: Mon, 22 Mar 2021 14:04:48 +0000 Message-ID: <87lfafgu7z.wl-maz@kernel.org> From: Marc Zyngier To: Michal Simek Cc: Lorenzo Pieralisi , michal.simek@xilinx.com, Bjorn Helgaas , Frank Wunderlich , Thierry Reding , Thomas Gleixner , Rob Herring , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Thierry Reding , Jonathan Hunter , Ryder Lee , Marek Vasut , Yoshihiro Shimoda , Paul Walmsley , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 03/13] PCI: xilinx: Convert to MSI domains In-Reply-To: <74cffc38-df12-7d92-1bfe-20eed4b60e86@monstr.eu> References: <20210225151023.3642391-1-maz@kernel.org> <20210225151023.3642391-4-maz@kernel.org> <20210322122100.GA11469@e121166-lin.cambridge.arm.com> <74cffc38-df12-7d92-1bfe-20eed4b60e86@monstr.eu> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: monstr@monstr.eu, lorenzo.pieralisi@arm.com, michal.simek@xilinx.com, bhelgaas@google.com, frank-w@public-files.de, treding@nvidia.com, tglx@linutronix.de, robh@kernel.org, will@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, thierry.reding@gmail.com, jonathanh@nvidia.com, ryder.lee@mediatek.com, marek.vasut+renesas@gmail.com, yoshihiro.shimoda.uh@renesas.com, paul.walmsley@sifive.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210322_140456_057567_12D608EB X-CRM114-Status: GOOD ( 31.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 22 Mar 2021 12:33:10 +0000, Michal Simek wrote: > > Hi, > > On 3/22/21 1:21 PM, Lorenzo Pieralisi wrote: > > On Thu, Feb 25, 2021 at 03:10:13PM +0000, Marc Zyngier wrote: > >> In anticipation of the removal of the msi_controller structure, convert > >> the ancient xilinx host controller driver to MSI domains. > >> > >> We end-up with the usual two domain structure, the top one being a > >> generic PCI/MSI domain, the bottom one being xilinx-specific and handling > >> the actual HW interrupt allocation. > >> > >> This allows us to fix some of the most appaling MSI programming, where > >> the message programmed in the device is the virtual IRQ number instead > >> of the allocated vector number. The allocator is also made safe with > >> a mutex. This should allow support for MultiMSI, but I decided not to > >> even try, since I cannot test it. > >> > >> Also take the opportunity to get rid of the cargo-culted memory allocation > >> for the MSI capture address. *ANY* sufficiently aligned address should > >> be good enough, so use the physical address of the xilinx_pcie_host > >> structure instead. > >> > >> Signed-off-by: Marc Zyngier > >> --- > >> drivers/pci/controller/Kconfig | 2 +- > >> drivers/pci/controller/pcie-xilinx.c | 238 +++++++++++---------------- > >> 2 files changed, 96 insertions(+), 144 deletions(-) > > > > Michal, > > > > can you please test these changes or make sure someone does and report > > back on the mailing list please ? > > > > I would like to merge this series for v5.13. > > I got just private response (not sure why) from Bharat March 5 that > changes are fine. > It means go ahead with it. Can I take this as a full Tested-by tag? Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel