From: Marc Zyngier <email@example.com>
To: "wangyanan (Y)" <firstname.lastname@example.org>
Cc: Will Deacon <email@example.com>,
Quentin Perret <firstname.lastname@example.org>,
Alexandru Elisei <email@example.com>,
Catalin Marinas <firstname.lastname@example.org>,
James Morse <email@example.com>,
Julien Thierry <firstname.lastname@example.org>,
Suzuki K Poulose <email@example.com>,
Gavin Shan <firstname.lastname@example.org>, <email@example.com>,
Subject: Re: [PATCH v6 1/4] KVM: arm64: Introduce cache maintenance callbacks for guest stage-2
Date: Thu, 17 Jun 2021 09:03:04 +0100 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
On Thu, 17 Jun 2021 07:48:29 +0100,
"wangyanan (Y)" <email@example.com> wrote:
> Hi Marc,
> On 2021/6/16 21:21, Marc Zyngier wrote:
> > Hi Yanan,
> > On Wed, 16 Jun 2021 10:51:57 +0100,
> > Yanan Wang <firstname.lastname@example.org> wrote:
> >> To prepare for performing guest CMOs in the fault handlers in pgtable.c,
> >> introduce two cache maintenance callbacks in struct kvm_pgtable_mm_ops.
> >> The new callbacks are specific for guest stage-2, so they will only be
> >> initialized in 'struct kvm_pgtable_mm_ops kvm_s2_mm_ops'.
> >> Signed-off-by: Yanan Wang <email@example.com>
> >> ---
> >> arch/arm64/include/asm/kvm_pgtable.h | 7 +++++++
> >> 1 file changed, 7 insertions(+)
> >> diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h
> >> index c3674c47d48c..302eca32e0af 100644
> >> --- a/arch/arm64/include/asm/kvm_pgtable.h
> >> +++ b/arch/arm64/include/asm/kvm_pgtable.h
> >> @@ -44,6 +44,11 @@ typedef u64 kvm_pte_t;
> >> * in the current context.
> >> * @virt_to_phys: Convert a virtual address mapped in the current context
> >> * into a physical address.
> >> + * @flush_dcache: Clean data cache for a guest page address range before
> >> + * creating the corresponding stage-2 mapping.
> > Please don't reintroduce the word 'flush'. We are really trying to
> > move away from it as it doesn't describe what we want to do.
> I agree with this. I intended to make the names short and laconic, but this
> missed the information about the callback's actual behaviors.
> > Here this
> > should be 'clean_invalidate_dcache' which, despite being a mouthful,
> > describe accurately what we expect it to do.
> Sure, I will change the name as you suggested.
> > The comment is also missing the invalidate part, and we shouldn't
> > assume that this is only used for S2 mapping.
> Ok, will refine the comment. I think something like"Clean and invalidate the
> date cache for the specified memory address range" may be generic enough.
> >> + * @flush_icache: Invalidate instruction cache for a guest page address
> >> + * range before creating or updating the corresponding
> >> + * stage-2 mapping.
> > Same thing here; this should be 'invalidate_icache', and the comment
> > cleaned up.
> Thanks, I will also correct this part.
> Besides the callback names and comments, is there anything else that still
> needs some adjustment in the other three patches? :)
It looks pretty good so far, much nicer than the previous versions.
I have a small nit on the last patch, which should be dead easy to
address. I'm currently running a bunch of tests, hopefully nothing bad
will come out of it.
If you respin it shortly, that nothing fails, and unless someone
shouts, I'll queue it for -next.
Without deviation from the norm, progress is not possible.
linux-arm-kernel mailing list
next prev parent reply other threads:[~2021-06-17 8:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:51 [PATCH v6 0/4] KVM: arm64: Improve efficiency of stage2 page table Yanan Wang
2021-06-16 9:51 ` [PATCH v6 1/4] KVM: arm64: Introduce cache maintenance callbacks for guest stage-2 Yanan Wang
2021-06-16 13:21 ` Marc Zyngier
2021-06-17 6:48 ` wangyanan (Y)
2021-06-17 8:03 ` Marc Zyngier [this message]
2021-06-17 8:22 ` wangyanan (Y)
2021-06-17 8:44 ` Marc Zyngier
2021-06-17 9:43 ` wangyanan (Y)
2021-06-17 10:43 ` Marc Zyngier
2021-06-18 8:50 ` Fuad Tabba
2021-06-16 9:51 ` [PATCH v6 2/4] KVM: arm64: Introduce mm_ops member for structure stage2_attr_data Yanan Wang
2021-06-16 9:51 ` [PATCH v6 3/4] KVM: arm64: Tweak parameters of guest cache maintenance functions Yanan Wang
2021-06-16 9:52 ` [PATCH v6 4/4] KVM: arm64: Move guest CMOs to the fault handlers Yanan Wang
2021-06-17 8:00 ` Marc Zyngier
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).