From: mpe@ellerman.id.au (Michael Ellerman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/7] kexec_file, x86, powerpc: factor out kexec_file_ops functions
Date: Wed, 14 Mar 2018 13:14:40 +1100 [thread overview]
Message-ID: <87o9jrflnz.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <87zi3b8o94.fsf@morokweng.localdomain>
Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com> writes:
> Dave Young <dyoung@redhat.com> writes:
>
>> On 03/06/18 at 07:22pm, AKASHI Takahiro wrote:
>>> As arch_kexec_kernel_image_{probe,load}(),
>>> arch_kimage_file_post_load_cleanup() and arch_kexec_kernel_verify_sig()
>>> are almost duplicated among architectures, they can be commonalized with
>>> an architecture-defined kexec_file_ops array. So let's factor them out.
>>>
>>> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>>> Cc: Dave Young <dyoung@redhat.com>
>>> Cc: Vivek Goyal <vgoyal@redhat.com>
>>> Cc: Baoquan He <bhe@redhat.com>
>>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>>> Cc: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
>>> ---
>>> arch/powerpc/include/asm/kexec.h | 2 +-
>>> arch/powerpc/kernel/kexec_elf_64.c | 2 +-
>>> arch/powerpc/kernel/machine_kexec_file_64.c | 39 ++-----------------
>>> arch/x86/include/asm/kexec-bzimage64.h | 2 +-
>>> arch/x86/kernel/kexec-bzimage64.c | 2 +-
>>> arch/x86/kernel/machine_kexec_64.c | 45 +---------------------
>>> include/linux/kexec.h | 13 +++----
>>> kernel/kexec_file.c | 60 +++++++++++++++++++++++++++--
>>> 8 files changed, 71 insertions(+), 94 deletions(-)
>>>
>>
>> For this patch it also needs some review from powerpc people.
>
> FWIW:
>
> Reviewed-by: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
>
> Also, tested on a ppc64le KVM guest:
>
> Tested-by: Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>
Thanks for testing. It looks OK to me.
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
next prev parent reply other threads:[~2018-03-14 2:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 10:22 [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres AKASHI Takahiro
2018-03-06 10:22 ` [PATCH v2 1/7] kexec_file: make an use of purgatory optional AKASHI Takahiro
2018-03-06 10:22 ` [PATCH v2 2/7] kexec_file, x86, powerpc: factor out kexec_file_ops functions AKASHI Takahiro
2018-03-08 1:13 ` Dave Young
2018-03-14 1:00 ` Thiago Jung Bauermann
2018-03-14 2:14 ` Michael Ellerman [this message]
2018-03-06 10:22 ` [PATCH v2 3/7] x86: kexec_file: purge system-ram walking from prepare_elf64_headers() AKASHI Takahiro
2018-03-06 10:23 ` [PATCH v2 4/7] x86: kexec_file: remove X86_64 dependency " AKASHI Takahiro
2018-03-06 10:23 ` [PATCH v2 5/7] x86: kexec_file: lift CRASH_MAX_RANGES limit on crash_mem buffer AKASHI Takahiro
2018-03-06 10:23 ` [PATCH v2 6/7] x86: kexec_file: clean up prepare_elf64_headers() AKASHI Takahiro
2018-03-06 10:23 ` [PATCH v2 7/7] kexec_file, x86: move re-factored code to generic side AKASHI Takahiro
2018-03-08 1:05 ` [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres Dave Young
2018-03-09 6:02 ` Dave Young
2018-03-09 6:44 ` Dave Young
2018-03-09 7:18 ` AKASHI Takahiro
2018-03-09 7:46 ` Dave Young
2018-03-09 7:55 ` Dave Young
2018-03-09 9:33 ` AKASHI Takahiro
2018-03-12 3:18 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9jrflnz.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).