From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67FB7C43461 for ; Wed, 21 Apr 2021 17:59:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 923FD61426 for ; Wed, 21 Apr 2021 17:59:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 923FD61426 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Fow6oEwc0kzzp7kO0YTifzIoquUzG5bATd2+FNVwktY=; b=bDBcBB85G/ucx9jfCJFQD3Pyo vxtNYpL2abMvdP25Tul09+gaolLI+0/qK3WJkQFfR1tZ1/3mnwdUslo5abtFjX85s7aEXtKLnOKMv 3jSIJxYNemGhjgMY4g99TL8zbPuEQP52vqaEpjG8I9rRylwnRUjiBuATmQU2WmmE0n33UvwLFSvY3 5jN/bwGigFvOY/S0cOmTkBnxpaO2rv1xjLzi3u4I66YxtfW1S+8igZuJp33rQQiBkDXER2QcIFj8V twZp5xeBikG4HP3adxp0HT4ecYsOkIfVv95SVHYqAnpthhjTgSkJfpK74hy6JWpzonRD/SEeMObEE 8dlBeg4Yg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZH6i-00EvTH-FL; Wed, 21 Apr 2021 17:57:48 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZH6d-00EvS9-DU for linux-arm-kernel@desiato.infradead.org; Wed, 21 Apr 2021 17:57:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mV8RKWTKz0PwlcWzm8FWtVFjIYWzH6SFLi0ba9SdIGQ=; b=kQ78gltVEV6XtXTuWuizZDen9y cWdRDj2Gns95Q1Hl9ryNdH9p6gXBzU0dMtwawT0A0dEEV22V9455sIr+KET9PK1VlyMrvRkOXXz8r ADPrJAexAy1xyoj6nneNPAlS8pMSVgmelDvA31HEl5gEs2W/KIkSy2jE0PB+1hDjO3uS7HN+SsptU uyogMjpUm0ERZOW5GlTOzFhtKorIjBQsw9g3ZIOH4NGo3ol2wG7GbVnuB5SKPXAGbCd/a4YKExPFm KSt+/nlMq4v5iWK86Dra/JkSvIqUNODOA3Ja6NXeqsnODX59hSnbRcPksuc10OIEwgOhGL4xPgF64 2WkXgaEA==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZH6a-00D5IS-PA for linux-arm-kernel@lists.infradead.org; Wed, 21 Apr 2021 17:57:42 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 919E16141C; Wed, 21 Apr 2021 17:57:37 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lZH6V-008kJm-39; Wed, 21 Apr 2021 18:57:35 +0100 Date: Wed, 21 Apr 2021 18:57:34 +0100 Message-ID: <87sg3jsepd.wl-maz@kernel.org> From: Marc Zyngier To: Sudeep Holla Cc: Lorenzo Pieralisi , Hanjun Guo , dann frazier , Fu Wei , Len Brown , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org Subject: Re: [PATCH 1/2] ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure In-Reply-To: <20210421172056.n2yoggo5epqwdhtc@bogus> References: <20210421164317.1718831-1-maz@kernel.org> <20210421164317.1718831-2-maz@kernel.org> <20210421172056.n2yoggo5epqwdhtc@bogus> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, dann.frazier@canonical.com, wefu@redhat.com, lenb@kernel.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210421_105740_873343_358E7F22 X-CRM114-Status: GOOD ( 23.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 21 Apr 2021 18:20:56 +0100, Sudeep Holla wrote: > > (with stable email fixed, but may need separate posting anyways) > > On Wed, Apr 21, 2021 at 05:43:16PM +0100, Marc Zyngier wrote: > > When failing the driver probe because of invalid firmware properties, > > the GTDT driver unmaps the interrupt that it mapped earlier. > > > > However, it never checks whether the mapping of the interrupt actially > > succeeded. Even more, should the firmware report an illegal interrupt > > number that overlaps with the GIC SGI range, this can result in an > > IPI being unmapped, and subsequent fireworks (as reported by Dann > > Frazier). > > > > Rework the driver to have a slightly saner behaviour and actually > > check whether the interrupt has been mapped before unmapping things. > > > > Reported-by: dann frazier > > Fixes: ca9ae5ec4ef0 ("acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver") > > Signed-off-by: Marc Zyngier > > Link: https://lore.kernel.org/r/YH87dtTfwYgavusz@xps13.dannf > > Cc: stable@vgerlkernel.org > ^^^ > > I thought I messed up while replying with my fat fingers, but here is the > culprit. I got mail delivery failure to my reply, thought I will let you > know as it may be difficult to notice this when using git send-email. I'm definitely the one with very fat fingers. I'll fix the patch in my tree. Thanks for the heads up, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel