Re: [PATCH v4 2/2] irqchip/apple-aic: Add support for A7-A11 SoCs

From: Marc Zyngier <maz@kernel.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht, asahi@lists.linux.dev,
	Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	martin.botka@somainline.org,
	angelogioacchino.delregno@somainline.org,
	marijn.suijten@somainline.org, jamipkettunen@somainline.org,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] irqchip/apple-aic: Add support for A7-A11 SoCs
Date: Sun, 09 Oct 2022 01:56:43 +0100	[thread overview]
Message-ID: <87wn99hl10.wl-maz@kernel.org> (raw)
In-Reply-To: <06a1b6fa-d179-97c7-995e-91d93123a5de@somainline.org>

On Sat, 08 Oct 2022 08:03:23 +0100,
Konrad Dybcio <konrad.dybcio@somainline.org> wrote:
> 
> 
> 
> On 8.10.2022 01:17, Marc Zyngier wrote:
> > On 2022-10-07 21:00, Konrad Dybcio wrote:
> >> Add support for A7-A11 SoCs by if-ing out some features only present
> >> on A11 & newer (implementation-defined IPI & UNCORE registers).
> >>
> >> Also, annotate IPI regs support in the aic struct so that the driver
> >> can tell whether the SoC supports these, as they are written to,
> >> even if fast IPI is disabled. This in turn causes a crash on older
> >> platforms, as the implemention-defined registers either do
> >> something else or are not supposed to be touched - definitely not a
> >> NOP though.
> >>
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> >> ---
> >> Changes since v3:
> >> - Replace use_fast_ipi with has_uncore_ipi_regs in aic_init_cpu
> >> (logic error, this was written to regardless of FIPI usage before,
> >> but touching Sn_... regs on SoCs that don't explicitly use them for
> >> IPIs makes them sepuku..)
> >> - Drop A11 compatible
> >>
> >>  drivers/irqchip/irq-apple-aic.c | 47 ++++++++++++++++++++++-----------
> >>  1 file changed, 32 insertions(+), 15 deletions(-)
> > 
> > Since you cannot be bothered to read the review comments on
> > the previous versions of this series, I'll do the same with
> > these patches. Feel free to stop Cc-ing me.
> > 
> >         M.
> I'm sorry, I'm working on a lot of stuff right now and I was almost sure
> your email only concerned adding a cover letter

And yet you ignored it again.

> and affirming the discussion on the fallback compatible,

I couldn't care less about that, but I admire your ability to guess
what an email may or may not contain!

> so I did not go through it again - but that was
> obviously incorrect. If you don't mind, I can respin another version of this
> patchset, addressing your comments.

That's pretty pointless at the moment, as I'm not queuing anything
other than fixes (and one week between versions is a sensible
pace). Come back after -rc1 with a cover letter and the various
comments addressed.

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel