From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39717C48BE5 for ; Wed, 16 Jun 2021 02:25:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F140A61241 for ; Wed, 16 Jun 2021 02:25:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F140A61241 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tOIRlm+wihDH0d8OpN2WxfByxKLZHuPztp0i/qMtVK0=; b=sqvuSMv0ZGts2t PWaF2ZV6R0OnFv+tPb7Rlm66VUdlE2FjhImRREpGcHwv1Ueb+T5T8m8n+r0Y0Sv/WPEs0UAyjBWgZ +aJ/Jhz9KWi1IMeC2nbFfo6l4vqm+PNeYOd+E5/f9UKImHAw/1JnbkaHtLrxmc8S9GPH6x3wafVtS j0/QKg1FaghGM6Omg2XIz0byyteMyCxETZsgLXi2XY3PQLyOEME0ZXFtYVN2A9y6lWBFY+LvyrXs4 /D9cESCl904rCDnf9aa4luWzs5H87/RbCRlbiqR1tsnBlziymlNlsLHnU7LH9QGozKdRo6bhLFeKK fcw2lqUA3gvCTaOLpADQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltLDn-004SGm-U3; Wed, 16 Jun 2021 02:24:04 +0000 Received: from ozlabs.org ([2401:3900:2:1::2]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltLDk-004SFb-Lz for linux-arm-kernel@lists.infradead.org; Wed, 16 Jun 2021 02:24:02 +0000 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4G4TWn4TqHz9sWX; Wed, 16 Jun 2021 12:23:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1623810234; bh=P3MCetIfzZtPqhiTVaYvru4yq+FzxZnPf34lNt0JVNs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bFttHDSYDF8hs1GhcNrBuxC8r7YR1FbbNwSxkDAL7lQtIx4XxJMkGgJ7lrWjuZU9K hHlMI3fju9iswEdIjo7GjpwxP1Gj1Fm/KYx+39MCmWGuFbgefyJ9+AnXWm5Gf/e/WE A3rk+pmgQ4nYUF6AN4aESjVY9NcZzs/XD9grffQ9ZgTrSzGhxqLEc7HLOf2IyR5wUs BEgh91+kA9k66Ony2Qct/YJq45j32aDa0BAlicNYsFLF+qSWSLxNmpFtktw78LYU6u aLSqG0ucZiktlwstD97l1OxIipFzxib0Y/fOq3lYLMw7V3BV6g9i2RPMf7XTojDwDI 6cNIWLPIEvGYQ== From: Michael Ellerman To: Rob Herring , nramas Cc: Geert Uytterhoeven , Mimi Zohar , Thiago Jung Bauermann , AKASHI Takahiro , Greg KH , Will Deacon , Joe Perches , Catalin Marinas , Stephen Rothwell , James Morse , Sasha Levin , Benjamin Herrenschmidt , Paul Mackerras , Frank Rowand , Vincenzo Frascino , Mark Rutland , dmitry.kasatkin@gmail.com, James Morris , "Serge E. Hallyn" , Pavel Tatashin , Allison Randal , Masahiro Yamada , Matthias Brugger , Hsin-Yi Wang , tao.li@vivo.com, Christophe Leroy , Prakhar Srivastava , balajib@linux.microsoft.com, linux-integrity , Linux Kernel Mailing List , Linux ARM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linuxppc-dev Subject: Re: [PATCH v19 05/13] of: Add a common kexec FDT setup function In-Reply-To: References: <20210221174930.27324-1-nramas@linux.microsoft.com> <20210221174930.27324-6-nramas@linux.microsoft.com> <54efb4fce5aac7efbd0b1b3885e9098b1d4ea745.camel@linux.microsoft.com> Date: Wed, 16 Jun 2021 12:23:44 +1000 Message-ID: <87y2basg27.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_192400_983534_729308E2 X-CRM114-Status: GOOD ( 24.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rob Herring writes: > On Tue, Jun 15, 2021 at 10:13 AM nramas wrote: >> >> On Tue, 2021-06-15 at 08:01 -0600, Rob Herring wrote: >> > On Tue, Jun 15, 2021 at 6:18 AM Geert Uytterhoeven < >> > geert@linux-m68k.org> wrote: >> > > >> > > > +void *of_kexec_alloc_and_setup_fdt(const struct kimage *image, >> > > > + unsigned long >> > > > initrd_load_addr, >> > > > + unsigned long initrd_len, >> > > > + const char *cmdline, size_t >> > > > extra_fdt_size) >> > > > +{ >> > > > + /* Did we boot using an initrd? */ >> > > > + prop = fdt_getprop(fdt, chosen_node, "linux,initrd- >> > > > start", NULL); >> > > > + if (prop) { >> > > > + u64 tmp_start, tmp_end, tmp_size; >> > > > + >> > > > + tmp_start = fdt64_to_cpu(*((const fdt64_t *) >> > > > prop)); >> > > > + >> > > > + prop = fdt_getprop(fdt, chosen_node, >> > > > "linux,initrd-end", NULL); >> > > > + if (!prop) { >> > > > + ret = -EINVAL; >> > > > + goto out; >> > > > + } >> > > > + >> > > > + tmp_end = fdt64_to_cpu(*((const fdt64_t *) >> > > > prop)); >> > > >> > > Some kernel code assumes "linux,initrd-{start,end}" are 64-bit, >> > > other code assumes 32-bit. >> > >> > It can be either. The above code was a merge of arm64 and powerpc >> > both >> > of which use 64-bit and still only runs on those arches. It looks >> > like >> > some powerpc platforms may use 32-bit, but this would have been >> > broken >> > before. >> of_kexec_alloc_and_setup_fdt() is called from elf_64.c (in >> arch/powerpc/kexec) which is for 64-bit powerpc platform only. > > 64-bit PPC could be writing 32-bit property values. The architecture > size doesn't necessarily matter. And if the values came from the > bootloader, who knows what size it used. > > This code is 32-bit powerpc only?: > > arch/powerpc/boot/main.c- /* Tell the kernel initrd address via device tree */ > arch/powerpc/boot/main.c: setprop_val(chosen, "linux,initrd-start", (u32)(initrd_addr)); > arch/powerpc/boot/main.c- setprop_val(chosen, "linux,initrd-end", (u32)(initrd_addr+initrd_size)); Historically that code was always built 32-bit, even when used with a 64-bit kernel. These days it is also built 64-bit (for ppc64le). It looks like the drivers/of/fdt.c code can handle either 64 or 32-bit, so I guess that's why it seems to be working. Although I'm not sure how much testing the 64-bit case gets, because the distros tend to just use the vmlinux. cheers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel