From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20E34C54EBE for ; Thu, 12 Jan 2023 20:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6RzcuiwLibNZLr0ijBk47TJGOW0fG8nuP30h1OHvLWQ=; b=Rx8c/gIbEr4JLW Z9lhqhBcmntrtM2aKE4TT2/yMbQLApMNPll3+15DhKvnLubZHrsQlo+zZ877tS/0CcnbY6SPyuaXG Kug4KnRxto9sWYfIUd2+wjHNy3U9jNl0Wju2hAodwAqcljvAQj0TGd3fuqODfAqffO9xNOTqrVvTS tuklsIu+bQqq7rI+tJ4RmXYoirzqzqnwWXZVMH5ZtmFcd3Y2BdcO1MW9ntcPHn76P5YvWXHK2ODb6 M1lN/i94UAxMAnBhRJOI1QW7XRJq+bNx+BVSbGo2+KrMDNbtIQbAyTIAY0ZdA8+11qtUiiQRLVvsa Z4OODmbvtKMR2I5vuyWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG3xi-00GoN3-IQ; Thu, 12 Jan 2023 20:14:11 +0000 Received: from golan.tkos.co.il ([84.110.109.230] helo=mail.tkos.co.il) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG3G1-00GUms-Pp for linux-arm-kernel@lists.infradead.org; Thu, 12 Jan 2023 19:29:05 +0000 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id 52EC54402B7; Thu, 12 Jan 2023 21:25:11 +0200 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1673551511; bh=EvjJ0/igxrI2zj27n/dQ2UDiz3t3gI09pwRm0+l9mrM=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=wAqJnFTk0OF4w3n70lHAHOy3kyCNnKIJfH7swrX6w6EdpqTQ5Dy80idfi5+NeZCPi 6QNS1vUStvzlD4cKZ5k9F44LL2jxHey6PsgQFNqxksBEp8v+CyDG17WULZXqaCM9+v W7PEPvHPTpNNq6+CcCKh/8ncVFT3w+axAg00vjEQxFhXzHkQCRzk4sHLLaYTvlZUUe pD27fq3XosuMLi0qSupyhoiJvA1jFV/4oiQfvHcICt6qe/7ACbdcN+BhyFdgUviZSM 4dNUjcNSVeARgesMilY0XhkWPU8Wv0Gdpd6dvzH2RigE3zIIf9+KdAI11pajE7eH+6 VEBdHPu9R9HRQ== References: <20230112184823.80349-1-andriy.shevchenko@linux.intel.com> User-agent: mu4e 1.8.10; emacs 28.2 From: Baruch Siach To: Andy Shevchenko Cc: Linus Walleij , Jianlong Huang , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells Date: Thu, 12 Jan 2023 21:28:16 +0200 In-reply-to: <20230112184823.80349-1-andriy.shevchenko@linux.intel.com> Message-ID: <87zganpn69.fsf@tarshish> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230112_112902_416263_353DB873 X-CRM114-Status: GOOD ( 15.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Thu, Jan 12 2023, Andy Shevchenko wrote: > The of_gpio_n_cells default is 2 when ->of_xlate() callback is > not defined. No need to assign it explicitly in the driver. > > Signed-off-by: Andy Shevchenko Acked-by: Baruch Siach baruch > --- > drivers/pinctrl/pinctrl-digicolor.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c > index cc3546fc4610..05213261b8a4 100644 > --- a/drivers/pinctrl/pinctrl-digicolor.c > +++ b/drivers/pinctrl/pinctrl-digicolor.c > @@ -248,7 +248,6 @@ static int dc_gpiochip_add(struct dc_pinmap *pmap) > chip->set = dc_gpio_set; > chip->base = -1; > chip->ngpio = PINS_COUNT; > - chip->of_gpio_n_cells = 2; > > spin_lock_init(&pmap->lock); -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel