From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43CCBC433FF for ; Wed, 7 Aug 2019 16:04:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1ABD822296 for ; Wed, 7 Aug 2019 16:04:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IZtWLcQN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1ABD822296 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xxn1yfi0V17+AEFN9MMMd2eq4zvQnrqZC0pz0AQg86M=; b=IZtWLcQNER0VCF vi/zEEX9a/BoMwf4AglC29cdH4W2bkwcNkfjZli/ysD1ow5BHRud+YJUwZUUWPUE2l80xe8Fk3mrB ul6DergYjL+VsOvw+eZ8xe5qDIb/x6OjlojOnm5vcqCNj7jGFZsx+DynnM4dGlOpFkhqMjqIwvuPW 9HHqD0OJ5UWhP4EeFwkX1BmeJW2P+rS4Rfaif+QqbPwltZoWB2T3hApEPl7+j+ZKn4g29WHZpD3V4 f89K1dC4Z7e+C5PxjJmC2lUfy5Oib7hRgkyi6JjgOjNffoBA8Y3KFTBrHhUzILTszqWxK0n+Mh0+F NbYqGAkZcrfAbO6TjdsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvOQF-000486-L7; Wed, 07 Aug 2019 16:04:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvOQD-00047e-5o for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2019 16:04:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A4C0A344; Wed, 7 Aug 2019 09:04:14 -0700 (PDT) Received: from [10.1.197.50] (e120937-lin.cambridge.arm.com [10.1.197.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 34FA93F706; Wed, 7 Aug 2019 09:04:14 -0700 (PDT) Subject: Re: [PATCH v3 11/11] kselftest: arm64: fake_sigreturn_misaligned_sp From: Cristian Marussi To: linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20190802170300.20662-1-cristian.marussi@arm.com> <20190802170300.20662-12-cristian.marussi@arm.com> Message-ID: <8811be0d-efb3-b6da-9f6b-acaeb3edce7d@arm.com> Date: Wed, 7 Aug 2019 17:04:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190802170300.20662-12-cristian.marussi@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190807_090417_311013_B7E83C39 X-CRM114-Status: GOOD ( 20.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave P Martin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/08/2019 18:03, Cristian Marussi wrote: > Added a simple fake_sigreturn testcase which places a valid > sigframe on a non-16 bytes aligned SP. > fake_sigretrun() helper function has been patched accordingly > to support placing a sigframe on a non-16 bytes aligned address. > Expects a SIGSEGV on test PASS. > > Adds also a test TODO lists holding some further test ideas. > > Signed-off-by: Cristian Marussi > --- > Re-added this text after fixing the forced misaglinment procedure in > fake_sigreturn() itself: require a ZERO alignment and you'll get > your sigframe placed on a misaligned SP (2-bytes off the 16-align) > --- > .../testing/selftests/arm64/signal/signals.S | 21 +++++++++---- > .../arm64/signal/testcases/TODO.readme | 8 +++++ > .../testcases/fake_sigreturn_misaligned_sp.c | 30 +++++++++++++++++++ > 3 files changed, 53 insertions(+), 6 deletions(-) > create mode 100644 tools/testing/selftests/arm64/signal/testcases/TODO.readme > create mode 100644 tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c > When this test was re-added in V3, the related .gitignore was missed. It will go in V4 Cheers Cristian > diff --git a/tools/testing/selftests/arm64/signal/signals.S b/tools/testing/selftests/arm64/signal/signals.S > index 6262b877400b..2099871176ed 100644 > --- a/tools/testing/selftests/arm64/signal/signals.S > +++ b/tools/testing/selftests/arm64/signal/signals.S > @@ -13,19 +13,28 @@ call_fmt: > > .globl fake_sigreturn > > -/* fake_sigreturn x0:&sigframe, x1:sigframe_size, x2:alignment_SP */ > +/* fake_sigreturn x0:&sigframe, x1:sigframe_sz, x2:align */ > fake_sigreturn: > - mov x20, x0 > - mov x21, x1 > - mov x22, x2 > - mov x23, sp > > - /* create space on the stack for fake sigframe..."x22"-aligned */ > + /* Save args and decide which aligment to enforce */ > + mov x23, sp > + mov x20, x0 > + mov x21, x1 > + /* x22 and x24 used for forcing alignment or misalignment */ > + mov x22, x2 > + mov x24, #0 > + cbnz x22, 1f > + mov x22, #16 > + mov x24, #2 > + > +1: /* create space on the stack for fake sigframe..."x22"-aligned */ > mov x0, #0 > add x0, x21, x22 > sub x22, x22, #1 > bic x0, x0, x22 > sub x23, x23, x0 > + /* force misaligned by x24 bytes if required alignment was zero */ > + add x23, x23, x24 > > ldr x0, =call_fmt > mov x1, x21 > diff --git a/tools/testing/selftests/arm64/signal/testcases/TODO.readme b/tools/testing/selftests/arm64/signal/testcases/TODO.readme > new file mode 100644 > index 000000000000..5c949492e7ab > --- /dev/null > +++ b/tools/testing/selftests/arm64/signal/testcases/TODO.readme > @@ -0,0 +1,8 @@ > +Some more possible ideas for signals tests: > + > +- fake_sigreturn_unmapped_sp > +- fake_sigreturn_kernelspace_sp > +- fake_sigreturn_sve_bad_extra_context > +- mangle_sve_invalid_extra_context > +- mangle_pstate_invalid_el for H modes (+ macroization ?) > +- fake_sigreturn_overflow_reserved > diff --git a/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c > new file mode 100644 > index 000000000000..3ee8c500c7d1 > --- /dev/null > +++ b/tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c > @@ -0,0 +1,30 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* Copyright (C) 2019 ARM Limited */ > + > +#include > + > +#include "test_signals_utils.h" > +#include "testcases.h" > + > +struct fake_sigframe sf; > + > +static int fake_sigreturn_misaligned_run(struct tdescr *td, > + siginfo_t *si, ucontext_t *uc) > +{ > + /* just to fill the ucontext_t with something real */ > + if (!get_current_context(td, &sf.uc)) > + return 1; > + > + /* Forcing sigframe on misaligned (=!16) SP */ > + fake_sigreturn(&sf, sizeof(sf), 0); > + > + return 1; > +} > + > +struct tdescr tde = { > + .name = "FAKE_SIGRETURN_MISALIGNED_SP", > + .descr = "Triggers a fake sigreturn with a misaligned sigframe on SP", > + .sig_ok = SIGSEGV, > + .timeout = 3, > + .run = fake_sigreturn_misaligned_run, > +}; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel