From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32F69C4332F for ; Mon, 3 Oct 2022 07:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xYYPycIu9dV/Fw4X3U4zL9li//Rd7zmIFMOgvgaihfs=; b=Aoynuk3xmJbf36 I1a7WugDDLyPsW33HIdly0SOX/EZLnXT7OiPyC0olcUhfvLMBdojVkoYamdBgKbS9C3RHsH14y0XI rlGsD4/rwdEAuLn01L5L6BE5tULo8zkJU6vFleIWt21HIY6K0Sfa+d2oReEk3h6hPQSrDY2mFU5wb yZmABMiyFRqGvSsl6nlxQ8Ydbnn56qRa++Jg4vPLcQTICZhbRu5koSP8/Z2ZIBdXJCOGU2lrY8U4P FhX0pAQWpzfsszRVSrmMLSlTr9ywXzeF0fMvMRQl5I1q1VlobwX2lS+yLecqaFt9vBKXkOUs/8XkA 2bfEcXDpstlAIqDufgsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofGJc-004XJ4-Q3; Mon, 03 Oct 2022 07:56:40 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofGJZ-004XH9-Ny for linux-arm-kernel@lists.infradead.org; Mon, 03 Oct 2022 07:56:39 +0000 Received: by mail-lf1-x135.google.com with SMTP id j16so15422849lfg.1 for ; Mon, 03 Oct 2022 00:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=e+d4ET8o0OR3zkYPmo0OiA0V7nJoYuTIpSvqddCGg2c=; b=R0uolEhXPYHlOkbpdEwgd0q8JDwITwNZDD4RiaZh9VzFiGQ1+7uddkAn60vv2QfEsh dJHCuGUVH8vixuLxJ8rhw6lAcFR8+0gue6ODTnpmlHm3KCzWaswse9eliQ9FaUcOXEiT tumjtGZrZMCtqbmWGrUu0eECHmdXMPSIOReL/zp9+w2H15Ex9Wv8OhOTOj4PublUQGc3 gVGqEUoPDxKVjClpad0HBSrQINg3cKOjByEGvTaAiMPPY5Fcu1geWjc7sM/8npj8Dfv6 hx9Nir45c/cCYIe3WMFU14EmyOyN8i7QGf3BZTDV3cAabSrp7EmSC0segR3GmoK2hQUC MEMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=e+d4ET8o0OR3zkYPmo0OiA0V7nJoYuTIpSvqddCGg2c=; b=TYBJdB2DobWxjdH42MB+3IPM0oe+YngNQA0E7SsQk+Q4fR1vJKPkr1OYlugspSWQn1 InrJGrJAGJ7dWifSB8pu5NjjejceqAvp1xI8TKdSt1KrWZNI/XxXIlT7W/IU/+n1uAhl a5iriGPhv79gwRKsauL7qd+6tAO6RvDyVSRj6sSjOyUHNrJ5pz2jV3y/jPdaLaahPRG9 uTOvx4hmxLknv7j+n+8NrlIqY9vkEttguVo1c7BF+LAz+6UyO3W/9R0Czaat94yi6sRt +O03/sL7xgoRAsIeqqXK5hb2EWZBWAuLRJthPOpehIy04QW9jujPhRdnkKHJSXb6bi1U rW/g== X-Gm-Message-State: ACrzQf2yMGbjqyrSrjSmDQidZsKRTpQdaCrxWa47U/KcVMCZgwqC3fgO h8pyHxm4qdAoT/a9tQcDYh8UyQ== X-Google-Smtp-Source: AMsMyM7PSSOenEuZQsvZRhSFXDEbLKt8lATbuzMcI5SNjafctLlLh2cJSlVjaoKlsZp3GxRj/we9qg== X-Received: by 2002:a05:6512:5d5:b0:4a2:3a71:16f7 with SMTP id o21-20020a05651205d500b004a23a7116f7mr1871650lfo.168.1664783796119; Mon, 03 Oct 2022 00:56:36 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id p4-20020a05651212c400b00497ac6b2b15sm1347904lfg.157.2022.10.03.00.56.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 00:56:35 -0700 (PDT) Message-ID: <89533acf-b741-f587-d2d4-0f5bc534e3ee@linaro.org> Date: Mon, 3 Oct 2022 09:56:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v9 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema Content-Language: en-US To: Kavyasree.Kotagiri@microchip.com, lee@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20220916075744.1879428-1-kavyasree.kotagiri@microchip.com> <20220916075744.1879428-2-kavyasree.kotagiri@microchip.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221003_005637_850469_B9EFB291 X-CRM114-Status: GOOD ( 19.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, robh@kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Sergiu.Moga@microchip.com, UNGLinuxDriver@microchip.com, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/09/2022 07:27, Kavyasree.Kotagiri@microchip.com wrote: >> Convert the Atmel flexcom device tree bindings to json schema. >> >> Signed-off-by: Kavyasree Kotagiri >> Reviewed-by: Rob Herring >> --- >> v8 -> v9: >> - Use full schema path for i2c bindings. >> >> Changing reference to SPI yaml bindings is covered in below patch series: >> https://lore.kernel.org/linux-arm-kernel/20220913142205.162399-6- >> sergiu.moga@microchip.com/ >> https://lore.kernel.org/linux-arm-kernel/dad37ca0-a44b-59ec-0be9- >> fb121de12244@linaro.org/ >> >> v7 -> v8: >> - Added back patternProperties for child nodes. >> >> v6 -> v7: >> - Change filename to atmel,sama5d2-flexcom.yaml >> - Add #address-cells, #size-cells to flexcom node - Fixed warnings. >> >> v5 -> v6: >> - Removed spi node from example as suggested by Rob and >> also pattern properties(spi dt-bindings conversion to yaml patch is under >> review). >> Once that is accepted, I will add back spi example through new patch. >> >> v4 -> v5: >> - Fixed indentations. >> >> v3 -> v4: >> - Corrected format of enum used for compatible string. >> >> v2 -> v3: >> - used enum for compatible string. >> - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example. >> - fixed dtschema errors. >> >> v1 -> v2: >> - Fix title. >> >> .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 92 +++++++++++++++++++ >> .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------- >> 2 files changed, 92 insertions(+), 63 deletions(-) >> create mode 100644 >> Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml >> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- >> flexcom.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2- >> flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2- >> flexcom.yaml >> new file mode 100644 >> index 000000000000..f28522cd987a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2- >> flexcom.yaml >> @@ -0,0 +1,92 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Atmel Flexcom (Flexible Serial Communication Unit) >> + >> +maintainers: >> + - Kavyasree Kotagiri >> + >> +description: >> + The Atmel Flexcom is just a wrapper which embeds a SPI controller, >> + an I2C controller and an USART. Only one function can be used at a >> + time and is chosen at boot time according to the device tree. >> + >> +properties: >> + compatible: >> + enum: >> + - atmel,sama5d2-flexcom >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + "#address-cells": >> + const: 1 >> + >> + "#size-cells": >> + const: 1 >> + >> + ranges: >> + description: >> + One range for the full I/O register region. (including USART, >> + TWI and SPI registers). >> + items: >> + maxItems: 3 >> + >> + atmel,flexcom-mode: >> + description: | >> + Specifies the flexcom mode as follows: >> + 1: USART >> + 2: SPI >> + 3: I2C. >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + enum: [1, 2, 3] >> + >> +patternProperties: >> + "^serial@[0-9a-f]+$": >> + type: object >> + description: >> + Child node describing USART. See atmel-usart.txt for details >> + of USART bindings. >> + >> + "^spi@[0-9a-f]+$": >> + type: object >> + description: >> + Child node describing SPI. See ../spi/spi_atmel.txt for details >> + of SPI bindings. >> + >> + "^i2c@[0-9a-f]+$": >> + $ref: /schemas/i2c/atmel,at91sam-i2c.yaml > > > Hi Krzysztof, > > I added full schema path for i2c bindings in v9. Please let me know your comments. > You sent the patch on 16th, pinged on 19th. Wait around two weeks before pinging. You got here Rob's review, what is missing? Why do you ping us? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel