From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E894BC2D0DB for ; Thu, 23 Jan 2020 09:58:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A052224655 for ; Thu, 23 Jan 2020 09:58:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r8Qw1v1X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A052224655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KpbbZplksvyfdYT/NEFN4nADiZ8BHptWE5qkUGsVS04=; b=r8Qw1v1XgwgLRv IOmWXpn568Vy3sk0kohSsk3GDv3OuoPAIt07h7RSCgeloJJdKE1F95nuB4HlXHcVuBqHJC7Eam0b7 1tmfWYC3FZXvP+nIYJNKwsRx9fYX+WFo89/flke6juC19J9AmtfoM83KnlIKxFuYB5gCW7mWGQa+X PnOIXhm7WMyXLou4dOZavgq1wtPvhPfG2JV+z+F1Fu00pkcjCSkP0XxZvmcRjty7B+HVWUb1PzjqH Tnn15TRNERMrGVIhJ5X3KN7Y5KPOZK1IJRWkgltHAdzRV5pUp5CJs1itP4DCa5+9albLs0V5Hg2FL BBQ6Mcy+bBTuPTXoIBHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuZGJ-0004dX-5n; Thu, 23 Jan 2020 09:58:55 +0000 Received: from ns.iliad.fr ([212.27.33.1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuZGE-0004d1-Un for linux-arm-kernel@lists.infradead.org; Thu, 23 Jan 2020 09:58:53 +0000 Received: from ns.iliad.fr (localhost [127.0.0.1]) by ns.iliad.fr (Postfix) with ESMTP id A3B732046B; Thu, 23 Jan 2020 10:58:47 +0100 (CET) Received: from [192.168.108.51] (freebox.vlq16.iliad.fr [213.36.7.13]) by ns.iliad.fr (Postfix) with ESMTP id 87A1E200B9; Thu, 23 Jan 2020 10:58:47 +0100 (CET) Subject: Re: sparse warnings for arch/arm64/kernel/vdso/vgettimeofday.c To: Vincenzo Frascino , Thomas Gleixner References: <848ca352-ea77-9840-d94a-96cc78b79795@arm.com> <23a4ac1c-40c2-94ba-63ff-8c74c26fdbf2@free.fr> <40d07c7d-5d43-534d-759e-1fe7766f8d04@arm.com> From: Marc Gonzalez Message-ID: <89ebe43d-e2df-fcfb-f31f-bd6dca528c02@free.fr> Date: Thu, 23 Jan 2020 10:58:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <40d07c7d-5d43-534d-759e-1fe7766f8d04@arm.com> Content-Language: en-US X-Virus-Scanned: ClamAV using ClamSMTP ; ns.iliad.fr ; Thu Jan 23 10:58:47 2020 +0100 (CET) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200123_015851_285350_77382509 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Arnd Bergmann , Ard Biesheuvel , Catalin Marinas , Will Deacon , Russell King , Dave Martin , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/11/2019 13:29, Vincenzo Frascino wrote: > On 28/11/2019 12:24, Marc Gonzalez wrote: > >> On 28/11/2019 11:44, Vincenzo Frascino wrote: >> >>> On 26/11/2019 10:42, Marc Gonzalez wrote: >>> >>>> Running 'make C=2' on v5.4 (arm64 defconfig) outputs: >>>> >>>> CHECK arch/arm64/kernel/vdso/vgettimeofday.c >>> >>> [...] >>> >>>> Are the above warnings all false positives? >>>> Do I need to update my version of sparse maybe? >>>> >>> >>> I downloaded the latest git of sparse and seems that the only warning I am >>> getting is: >>> >>> linux/lib/vdso/gettimeofday.c:224:5: warning: symbol '__cvdso_clock_getres' was >>> not declared. Should it be static? >> >> Interesting. Dunno which version I'm running, as sparse appears >> to ignores the --version flag. >> >> $ apt list --installed | grep ^sparse >> sparse/bionic,now 0.5.1-2 amd64 [installed] >> >> https://sparse.wiki.kernel.org/index.php/Main_Page >> >> I appear to be running a 2 year old version. >> > > I thought so ;) > >> Sorry for the noise. I need to figure out how to upgrade this without >> breaking apt... >> > > No problem. I use the latest version built from git in my dev environment and > export it in the PATH. This does not break apt. An alternative could be to > create a package and install it, but I find the first easier to update. I haven't upgraded sparse yet, but I've been playing with make W=1 lately, using gcc 9.2. On v5.5-rc1, I see the following warnings: CC arch/arm64/kernel/vdso/vgettimeofday.o In file included from : /home/mgonzalez/linux/lib/vdso/gettimeofday.c:224:5: warning: no previous prototype for '__cvdso_clock_getres' [-Wmissing-prototypes] 224 | int __cvdso_clock_getres(clockid_t clock, struct __kernel_timespec *res) | ^~~~~~~~~~~~~~~~~~~~ arch/arm64/kernel/vdso/vgettimeofday.c:11:5: warning: no previous prototype for '__kernel_clock_gettime' [-Wmissing-prototypes] 11 | int __kernel_clock_gettime(clockid_t clock, | ^~~~~~~~~~~~~~~~~~~~~~ arch/arm64/kernel/vdso/vgettimeofday.c:17:5: warning: no previous prototype for '__kernel_gettimeofday' [-Wmissing-prototypes] 17 | int __kernel_gettimeofday(struct __kernel_old_timeval *tv, | ^~~~~~~~~~~~~~~~~~~~~ arch/arm64/kernel/vdso/vgettimeofday.c:23:5: warning: no previous prototype for '__kernel_clock_getres' [-Wmissing-prototypes] 23 | int __kernel_clock_getres(clockid_t clock_id, | ^~~~~~~~~~~~~~~~~~~~~ I suppose the __cvdso_clock_getres warning is fixed in v5.6? The other warnings might be false positives? Regards. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel