From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EF0FC4363A for ; Tue, 6 Oct 2020 01:50:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9E782076B for ; Tue, 6 Oct 2020 01:50:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eKIVsF/T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9E782076B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+9fsBvtPIINUNrbDXw9+vua81cQHWGU/SSmdPKxfodc=; b=eKIVsF/TS6ZAWNq1VN+oruiHs rHys5i2Iwnnbju3K5As/4Kg1DBST/ja78c6lnapoAhnTQ1c/VjafS/Hmhr2K8n0VqRX9U2sZQu8t0 FSoCuQ4w9J5RwmSpiaJkkuFRio8tgFM3iY+cbW2wO3HBpO+MBgGqB6G+JzukOn2MdbRLmedQgPLrJ L9XtchnCBTlbh7P/ESJNfUnfdLOvx+f0DcjT8RoL9m791sRyRAYdVpznj9Niw79fsUzdJS739H2aO r7WIa7j2R59eKtsLtbHiLRR61SuO63lczP4hM0/VOqqPmJJwqhyJxfa3X8GpfGgTsXwlTISLs7r5W GfkZ7Kqbg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPc5d-0005kt-HV; Tue, 06 Oct 2020 01:48:29 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPc5a-0005jt-1A; Tue, 06 Oct 2020 01:48:27 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id E1AFD23746D1A48192D7; Tue, 6 Oct 2020 09:48:14 +0800 (CST) Received: from [10.174.176.61] (10.174.176.61) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Tue, 6 Oct 2020 09:48:07 +0800 Subject: Re: [PATCH v12 0/9] support reserving crashkernel above 4G on arm64 kdump To: Bhupesh Sharma , Catalin Marinas References: <20200907134745.25732-1-chenzhou10@huawei.com> <20201005170937.GA14576@gaia> From: chenzhou Message-ID: <8a050973-2eb6-61ed-9172-dd4fd0909f65@huawei.com> Date: Tue, 6 Oct 2020 09:48:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.174.176.61] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_214826_324438_1B2AA9E3 X-CRM114-Status: GOOD ( 23.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Horman , John Donnelly , guohanjun@huawei.com, xiexiuqi@huawei.com, Arnd Bergmann , Baoquan He , Jonathan Corbet , Will Deacon , Linux Doc Mailing List , kexec mailing list , Linux Kernel Mailing List , Rob Herring , wangkefeng.wang@huawei.com, Ingo Molnar , James Morse , linux-arm-kernel , huawei.libin@huawei.com, Prabhakar Kushwaha , Thomas Gleixner , RuiRui Yang , nsaenzjulienne@suse.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bhupesh, On 2020/10/6 1:42, Bhupesh Sharma wrote: > Hi Catalin, Chen, > > On Mon, Oct 5, 2020 at 10:39 PM Catalin Marinas wrote: >> On Sat, Sep 12, 2020 at 06:44:29AM -0500, John Donnelly wrote: >>> On 9/7/20 8:47 AM, Chen Zhou wrote: >>>> Chen Zhou (9): >>>> x86: kdump: move CRASH_ALIGN to 2M >>>> x86: kdump: make the lower bound of crash kernel reservation >>>> consistent >>>> x86: kdump: use macro CRASH_ADDR_LOW_MAX in functions >>>> reserve_crashkernel[_low]() >>>> x86: kdump: move reserve_crashkernel[_low]() into crash_core.c >>>> arm64: kdump: introduce some macroes for crash kernel reservation >>>> arm64: kdump: reimplement crashkernel=X >>>> kdump: add threshold for the required memory >>>> arm64: kdump: add memory for devices by DT property >>>> linux,usable-memory-range >>>> kdump: update Documentation about crashkernel >> [...] >>> I did a brief unit-test on 5.9-rc4. >>> >>> Please add: >>> >>> Tested-by: John Donnelly >> Thanks for testing. >> >>> This activity is over a year old. It needs accepted. >> It's getting there, hopefully in 5.11. There are some minor tweaks to >> address. > I think my earlier email with the test results on this series bounced > off the mailing list server (for some weird reason), but I still see > several issues with this patchset. I will add specific issues in the > review comments for each patch again, but overall, with a crashkernel > size of say 786M, I see the following issue: > > # cat /proc/cmdline > BOOT_IMAGE=(hd7,gpt2)/vmlinuz-5.9.0-rc7+ root=<..snip..> > rd.lvm.lv=<..snip..> crashkernel=786M > > I see two regions of size 786M and 256M reserved in low and high > regions respectively, So we reserve a total of 1042M of memory, which > is an incorrect behaviour: > > # dmesg | grep -i crash > [ 0.000000] Reserving 256MB of low memory at 2816MB for crashkernel > (System low RAM: 768MB) > [ 0.000000] Reserving 786MB of memory at 654158MB for crashkernel > (System RAM: 130816MB) > [ 0.000000] Kernel command line: > BOOT_IMAGE=(hd2,gpt2)/vmlinuz-5.9.0-rc7+ > root=/dev/mapper/rhel_ampere--hr330a--03-root ro > rd.lvm.lv=rhel_ampere-hr330a-03/root > rd.lvm.lv=rhel_ampere-hr330a-03/swap crashkernel=786M cma=1024M > > # cat /proc/iomem | grep -i crash > b0000000-bfffffff : Crash kernel (low) > bfcbe00000-bffcffffff : Crash kernel > > IMO, we should test this feature more before including this in 5.11 Thanks for you test. This behavior is what we what. What is the correct behavior you think? Besides, this feature is been tested by John and PK, and i test for various parameters. We may miss something, any comments are welcome. Thanks, Chen Zhou > > Thanks, > Bhupesh > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel