From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CF1CC433F5 for ; Tue, 4 Oct 2022 10:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J6pY4zYlC9tWbM35312VfffbcDCJWVXgdo8U5pJ79ic=; b=Bu3mHvLJHg4ibp 9gGaaZmu7yUwJ2E6OQ3/PKE7gTe8FmCR+0JHnHe/B/zkKMTetcFUwLAPiPzlp8E92AllOC4+axUIz xTHhsHv1t/19ylgRM+svsNcwcKvCTr66GRQacSFihfVVyHqThShMGXGYC/tuJJy2uNEnwCP3vKk7r lDk1Yc+BM8EUxhB44a0oFY13S7XaTY+1jHp2tPOVLxZVadTHaSnsqUzdBsALuWtIp283Aa2xrhtWn iVZ0e1WICKvL4KPp9uH24bXZQ8Y2011DN+gOVIugvvHohYgyiafhdn5G/BdBpG8ZjRfyAPS5A2Q8d aUkmdGb9MAijWNKs/W6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofevS-009Ji1-S2; Tue, 04 Oct 2022 10:13:22 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofevQ-009Jgz-Ek; Tue, 04 Oct 2022 10:13:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664878400; x=1696414400; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=unSBrfZWWQiaWR5VmWYGXL4IstFzYLo18uQjnoBzJyQ=; b=E5vH6S0dto6gmAZ3x1yLA+FT/iMv9zhGCnsS5tP6A2NDyKH2jBxl/yIB c4U1XQVBeViI3NP2GKusjaoWXAAfuE3FjN2NCVFxWVq54Tj5xqWRmJhOf ybVupr4O2yykmos9lrVJc2DGflcfUv6QSKqeWeiEew4boOyM+v3936/Zh i9ZsAk+gtbrYPz5XEbr+hujnmoAllvNXyz4pmTQo5Ky3Zz7EbqZVFbuNG 87a2xdKI2Mh7WhMBSjse8XQ1kaayTh7AoC91UaSdAMK57kEVK2ZfXeD2R fU2zXnRcTzkH3sxvvAiAZ6sjo0w333EaFbocHofxa4uxcAtSpahXBGLHJ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="282586489" X-IronPort-AV: E=Sophos;i="5.93,367,1654585200"; d="scan'208";a="282586489" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 03:13:18 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10489"; a="619053782" X-IronPort-AV: E=Sophos;i="5.93,367,1654585200"; d="scan'208";a="619053782" Received: from kmreisi-mobl.ger.corp.intel.com ([10.252.39.196]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 03:13:13 -0700 Date: Tue, 4 Oct 2022 13:13:10 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Irui Wang cc: Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Krzysztof Kozlowski , Tzung-Bi Shih , angelogioacchino.delregno@collabora.com, nicolas.dufresne@collabora.com, Tiffany Lin , Yunfei Dong , Maoguang Meng , Longfei Wang , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, LKML , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v6, 5/8] media: mediatek: vcodec: Add venc power on/off function In-Reply-To: <20221001031737.18266-6-irui.wang@mediatek.com> Message-ID: <8a19febc-8662-b9f7-8250-44c23af06f91@linux.intel.com> References: <20221001031737.18266-1-irui.wang@mediatek.com> <20221001031737.18266-6-irui.wang@mediatek.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221004_031320_562333_13C8775C X-CRM114-Status: GOOD ( 15.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 1 Oct 2022, Irui Wang wrote: > when enable multi-core encoding, all available encoder cores' power need > to be on/off, add new functions for encoder cores' power management. > > Signed-off-by: Irui Wang > --- > diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c > index 75de5031d292..213c3f50e9eb 100644 > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_pm.c > @@ -9,6 +9,7 @@ > #include > #include > > +#include "mtk_vcodec_enc_hw.h" > #include "mtk_vcodec_enc_pm.h" > #include "mtk_vcodec_util.h" > > @@ -56,6 +57,88 @@ int mtk_vcodec_init_enc_clk(struct platform_device *pdev, > } > EXPORT_SYMBOL_GPL(mtk_vcodec_init_enc_clk); > > +static int mtk_enc_core_power_on(struct mtk_vcodec_ctx *ctx) > +{ > + struct mtk_venc_hw_dev *sub_core; > + int ret, i; > + > + /* multi-core encoding need power on all available cores */ > + for (i = 0; i < MTK_VENC_HW_MAX; i++) { > + sub_core = (struct mtk_venc_hw_dev *)ctx->dev->enc_hw_dev[i]; > + if (!sub_core) > + continue; > + > + ret = pm_runtime_resume_and_get(&sub_core->plat_dev->dev); > + if (ret) { > + mtk_v4l2_err("power on sub_core[%d] fail %d", i, ret); > + goto pm_on_fail; > + } > + } > + return ret; > + > +pm_on_fail: > + for (i -= 1; i >= 0; i--) { while (i--) { achieves the same. > + sub_core = (struct mtk_venc_hw_dev *)ctx->dev->enc_hw_dev[i]; > + pm_runtime_put_sync(&sub_core->plat_dev->dev); > + } > + return ret; > +} -- i. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel