From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61280C10F27 for ; Tue, 10 Mar 2020 15:11:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 339B620873 for ; Tue, 10 Mar 2020 15:11:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hKUjxn4u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 339B620873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Itc+HayvnZPA2qjbMIHQARcAJXXIXcDROShysRELSbI=; b=hKUjxn4uvIvk9T dPEH+FaQY/OUgLg4HtLcOOozgTR7gYk6a+yrI9SLuP/NXkzvqKA8oiUYbX/aHZfim2SzRfRI7WsDm lFir8fBU5kNBglqZLrQXQ4zGfwLhDk0NWW4srD5keJudjh4FdIyGMuZoxHaI2oeapU/c22S4NQiS6 3T4AsBQYcTR2vCUT3NBtiLIq9qR2onkVSKtbLcAeuIxx9bQvWiWSfpnl2qq731kK3Y5Z9t1vWF5i8 PjaDAMn+Ijf2+etSD9Lu6oWJ/PCA9iHbAA57E31D9AxBWVtp6apERsPJN0gh7MmExGeANBZxqrjCk KNTutH9DpJgeF0M13QKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBgXO-0006D3-CN; Tue, 10 Mar 2020 15:11:18 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jBgXL-0006Cd-6K for linux-arm-kernel@lists.infradead.org; Tue, 10 Mar 2020 15:11:16 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A2981FB; Tue, 10 Mar 2020 08:11:14 -0700 (PDT) Received: from [10.37.12.115] (unknown [10.37.12.115]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 603393F6CF; Tue, 10 Mar 2020 08:11:12 -0700 (PDT) Subject: Re: [PATCH v6 14/18] arm64: __show_regs: strip PAC from lr in printk To: Amit Daniel Kachhap , linux-arm-kernel@lists.infradead.org References: <1583476525-13505-1-git-send-email-amit.kachhap@arm.com> <1583476525-13505-15-git-send-email-amit.kachhap@arm.com> From: Vincenzo Frascino Message-ID: <8a674f6f-50e8-07af-24e8-164908ab8966@arm.com> Date: Tue, 10 Mar 2020 15:11:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1583476525-13505-15-git-send-email-amit.kachhap@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200310_081115_277244_82A6E705 X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Suzuki K Poulose , Catalin Marinas , Kristina Martsenko , Dave Martin , Mark Brown , James Morse , Ramana Radhakrishnan , Will Deacon , Ard Biesheuvel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/6/20 6:35 AM, Amit Daniel Kachhap wrote: > lr is printed with %pS which will try to find an entry in kallsyms. > After enabling pointer authentication, this match will fail due to > PAC present in the lr. > > Strip PAC from the lr to display the correct symbol name. > Reviewed-by: Vincenzo Frascino > Suggested-by: James Morse > Acked-by: Catalin Marinas > Signed-off-by: Amit Daniel Kachhap > --- > arch/arm64/kernel/process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > index 7db0302..cacae29 100644 > --- a/arch/arm64/kernel/process.c > +++ b/arch/arm64/kernel/process.c > @@ -262,7 +262,7 @@ void __show_regs(struct pt_regs *regs) > > if (!user_mode(regs)) { > printk("pc : %pS\n", (void *)regs->pc); > - printk("lr : %pS\n", (void *)lr); > + printk("lr : %pS\n", (void *)ptrauth_strip_insn_pac(lr)); > } else { > printk("pc : %016llx\n", regs->pc); > printk("lr : %016llx\n", lr); > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel