From: Adrian Hunter <adrian.hunter@intel.com>
To: Baolin Wang <baolin.wang@linaro.org>,
ulf.hansson@linaro.org, zhang.lyra@gmail.com,
orsonzhai@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
arnd@arndb.de, olof@lixom.net
Cc: devicetree@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, arm@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/9] mmc: sdhci-sprd: Enable PHY DLL to make clock stable
Date: Mon, 3 Jun 2019 15:40:58 +0300 [thread overview]
Message-ID: <8a792a0c-ed53-56ca-ede8-4a2657158b81@intel.com> (raw)
In-Reply-To: <270e86bf6b1ce138e40830fb63c9bcf150440426.1558346019.git.baolin.wang@linaro.org>
On 20/05/19 1:11 PM, Baolin Wang wrote:
> For the Spreadtrum SD host controller, when we changed the clock to be
> more than 52M, we should enable the PHY DLL which is used to track the
> clock frequency to make the clock work more stable. Otherwise deviation
> may occur of the higher clock.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-sprd.c | 44 ++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 43 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index edec197..e6eda13 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -22,6 +22,13 @@
> /* SDHCI_ARGUMENT2 register high 16bit */
> #define SDHCI_SPRD_ARG2_STUFF GENMASK(31, 16)
>
> +#define SDHCI_SPRD_REG_32_DLL_CFG 0x200
> +#define SDHCI_SPRD_DLL_ALL_CPST_EN (BIT(18) | BIT(24) | BIT(25) | BIT(26) | BIT(27))
> +#define SDHCI_SPRD_DLL_EN BIT(21)
> +#define SDHCI_SPRD_DLL_SEARCH_MODE BIT(16)
> +#define SDHCI_SPRD_DLL_INIT_COUNT 0xc00
> +#define SDHCI_SPRD_DLL_PHASE_INTERNAL 0x3
> +
> #define SDHCI_SPRD_REG_32_DLL_DLY_OFFSET 0x208
> #define SDHCIBSPRD_IT_WR_DLY_INV BIT(5)
> #define SDHCI_SPRD_BIT_CMD_DLY_INV BIT(13)
> @@ -56,6 +63,7 @@
> #define SDHCI_SPRD_CLK_MAX_DIV 1023
>
> #define SDHCI_SPRD_CLK_DEF_RATE 26000000
> +#define SDHCI_SPRD_PHY_DLL_CLK 52000000
>
> struct sdhci_sprd_host {
> u32 version;
> @@ -200,9 +208,33 @@ static inline void _sdhci_sprd_set_clock(struct sdhci_host *host,
> }
> }
>
> +static void sdhci_sprd_enable_phy_dll(struct sdhci_host *host)
> +{
> + u32 tmp;
> +
> + tmp = sdhci_readl(host, SDHCI_SPRD_REG_32_DLL_CFG);
> + tmp &= ~(SDHCI_SPRD_DLL_EN | SDHCI_SPRD_DLL_ALL_CPST_EN);
> + sdhci_writel(host, tmp, SDHCI_SPRD_REG_32_DLL_CFG);
> + /* wait 1ms */
> + usleep_range(1000, 1250);
> +
> + tmp = sdhci_readl(host, SDHCI_SPRD_REG_32_DLL_CFG);
> + tmp |= SDHCI_SPRD_DLL_ALL_CPST_EN | SDHCI_SPRD_DLL_SEARCH_MODE |
> + SDHCI_SPRD_DLL_INIT_COUNT | SDHCI_SPRD_DLL_PHASE_INTERNAL;
> + sdhci_writel(host, tmp, SDHCI_SPRD_REG_32_DLL_CFG);
> + /* wait 1ms */
> + usleep_range(1000, 1250);
> +
> + tmp = sdhci_readl(host, SDHCI_SPRD_REG_32_DLL_CFG);
> + tmp |= SDHCI_SPRD_DLL_EN;
> + sdhci_writel(host, tmp, SDHCI_SPRD_REG_32_DLL_CFG);
> + /* wait 1ms */
> + usleep_range(1000, 1250);
> +}
> +
> static void sdhci_sprd_set_clock(struct sdhci_host *host, unsigned int clock)
> {
> - bool en = false;
> + bool en = false, clk_changed = false;
>
> if (clock == 0) {
> sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL);
> @@ -214,9 +246,19 @@ static void sdhci_sprd_set_clock(struct sdhci_host *host, unsigned int clock)
> en = true;
> sdhci_sprd_set_dll_invert(host, SDHCI_SPRD_BIT_CMD_DLY_INV |
> SDHCI_SPRD_BIT_POSRD_DLY_INV, en);
> + clk_changed = true;
> } else {
> _sdhci_sprd_set_clock(host, clock);
> }
> +
> + /*
> + * According to the Spreadtrum SD host specification, when we changed
> + * the clock to be more than 52M, we should enable the PHY DLL which
> + * is used to track the clock frequency to make the clock work more
> + * stable. Otherwise deviation may occur of the higher clock.
> + */
> + if (clk_changed && clock > SDHCI_SPRD_PHY_DLL_CLK)
> + sdhci_sprd_enable_phy_dll(host);
> }
>
> static unsigned int sdhci_sprd_get_max_clock(struct sdhci_host *host)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-03 12:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 10:11 [PATCH 0/9] Add SD host controller support for SC9860 platform Baolin Wang
2019-05-20 10:11 ` [PATCH 1/9] mmc: sdhci-sprd: Check the enable clock's return value correctly Baolin Wang
2019-06-03 12:09 ` Adrian Hunter
2019-05-20 10:11 ` [PATCH 2/9] dt-bindings: mmc: sprd: Add another optional clock documentation Baolin Wang
2019-06-03 13:34 ` Ulf Hansson
2019-06-04 2:33 ` Baolin Wang
2019-06-04 6:52 ` Ulf Hansson
2019-05-20 10:11 ` [PATCH 3/9] mmc: sdhci-sprd: Add optional gate clock support Baolin Wang
2019-06-03 12:20 ` Adrian Hunter
2019-05-20 10:11 ` [PATCH 4/9] mmc: sdhci-sprd: Implement the get_max_timeout_count() interface Baolin Wang
2019-06-03 12:34 ` Adrian Hunter
2019-06-04 8:03 ` Baolin Wang
2019-05-20 10:11 ` [PATCH 5/9] mmc: sdhci-sprd: Add HS400 enhanced strobe mode Baolin Wang
2019-06-03 12:39 ` Adrian Hunter
2019-05-20 10:11 ` [PATCH 6/9] mmc: sdhci-sprd: Enable PHY DLL to make clock stable Baolin Wang
2019-06-03 12:40 ` Adrian Hunter [this message]
2019-05-20 10:12 ` [PATCH 7/9] dt-bindings: mmc: sprd: Add PHY DLL delay documentation Baolin Wang
2019-05-20 10:12 ` [PATCH 8/9] mmc: sdhci-sprd: Add PHY DLL delay configuration Baolin Wang
2019-06-03 13:01 ` Adrian Hunter
2019-06-04 2:18 ` Baolin Wang
2019-05-20 10:12 ` [PATCH 9/9] arm64: dts: sprd: Add Spreadtrum SD host controller support Baolin Wang
2019-06-03 8:41 ` [PATCH 0/9] Add SD host controller support for SC9860 platform Baolin Wang
2019-06-04 7:13 ` Ulf Hansson
2019-06-04 7:21 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a792a0c-ed53-56ca-ede8-4a2657158b81@intel.com \
--to=adrian.hunter@intel.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).