From: Michal Simek <michal.simek@xilinx.com>
To: Sherry Sun <sherry.sun@nxp.com>, <bp@alien8.de>,
<mchehab@kernel.org>, <michal.simek@xilinx.com>,
<tony.luck@intel.com>, <james.morse@arm.com>, <rric@kernel.org>
Cc: <linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <linux-imx@nxp.com>
Subject: Re: [PATCH 1/2] EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR
Date: Wed, 20 Apr 2022 07:56:44 +0200 [thread overview]
Message-ID: <8c49091c-5bba-47fe-6479-8a2af69c7340@xilinx.com> (raw)
In-Reply-To: <20220318111742.15730-2-sherry.sun@nxp.com>
On 3/18/22 12:17, Sherry Sun wrote:
> V3.X Synopsys EDAC DDR doesn't have the QOS Interrupt register, need
> to change to use the ECC Clear Register to disable the interrupts.
>
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> ---
> drivers/edac/synopsys_edac.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
> index f05ff02c0656..1b630f0be119 100644
> --- a/drivers/edac/synopsys_edac.c
> +++ b/drivers/edac/synopsys_edac.c
> @@ -859,8 +859,11 @@ static void enable_intr(struct synps_edac_priv *priv)
> static void disable_intr(struct synps_edac_priv *priv)
> {
> /* Disable UE/CE Interrupts */
> - writel(DDR_QOSUE_MASK | DDR_QOSCE_MASK,
> - priv->baseaddr + DDR_QOS_IRQ_DB_OFST);
> + if (priv->p_data->quirks & DDR_ECC_INTR_SELF_CLEAR)
> + writel(0x0, priv->baseaddr + ECC_CLR_OFST);
> + else
> + writel(DDR_QOSUE_MASK | DDR_QOSCE_MASK,
> + priv->baseaddr + DDR_QOS_IRQ_DB_OFST);
> }
>
> static int setup_irq(struct mem_ctl_info *mci,
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-20 5:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 11:17 [PATCH 0/2] fix some bugs in V3.X Synopsys EDAC DDR driver Sherry Sun
2022-03-18 11:17 ` [PATCH 1/2] EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR Sherry Sun
2022-04-20 5:56 ` Michal Simek [this message]
2022-03-18 11:17 ` [PATCH 2/2] EDAC: synopsys: re-enable the interrupts in intr_handler " Sherry Sun
2022-04-20 5:57 ` Michal Simek
2022-04-20 6:23 ` Sherry Sun
2022-03-18 11:30 ` [PATCH 0/2] fix some bugs in V3.X Synopsys EDAC DDR driver Michal Simek
2022-04-19 15:34 ` Shubhrajyoti Datta
2022-03-25 1:28 ` Sherry Sun
2022-04-18 2:27 ` Sherry Sun
2022-04-18 8:34 ` Borislav Petkov
2022-04-18 10:12 ` Sherry Sun
2022-04-18 10:20 ` Borislav Petkov
2022-04-18 10:26 ` Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c49091c-5bba-47fe-6479-8a2af69c7340@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=sherry.sun@nxp.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).