From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7891BC433DF for ; Fri, 21 Aug 2020 12:47:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 491732078D for ; Fri, 21 Aug 2020 12:47:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eBMPKrox"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GC8Bv/ve" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 491732078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bPhlASQV4hxGLmKFi4JRFOKW+1p3rkBEiZTrdi1tN88=; b=eBMPKroxL4LBq63Vfw5wFIAHT LoR+GjjJoObwbkxZtCm8JN/QUGKt2XKM6hHFukqxkchze+yQ/3tvDsYjAYnRO7rFYUD1U4iesfACA 0l7D3zCm84HDhjm72U7tV3UBpDNrzPP5rE9lBOZx4Ppi/HcJW+jt88cPWwGayAoogZZhPbHjZXlQN JKko1hudBvBFu8US+VGamzgL4egMbp/Ax4Sypxx7Hh6GQI8C/8F/a4O6JfLxNCEfY/jADm4E8p6af uKjlnNtknFwvVbLC/WXv+HsXnqbJzfCnxJnAIxavrlNfog+vHpoj+D5yjJMeJT4KOAmRRrvSyIVDa +gRFCmN+A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k96QT-0001ip-5V; Fri, 21 Aug 2020 12:45:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k96QQ-0001i4-Th for linux-arm-kernel@lists.infradead.org; Fri, 21 Aug 2020 12:45:43 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0395E2078D; Fri, 21 Aug 2020 12:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598013942; bh=+m+pk9tP+dvLl4RuuawbUoq3y+/lwD8wVqsM+12XCr4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GC8Bv/vejINTmgHLUFOM8Bkp9Jav2vH3AmH9bKQT04LL9m7OmOIbLTak4z3W2TFWw QA8DVtuA0HFxkVVFeJlVMk4RHQsyJBLECoqMHKEcN+o98LOZqE/W7J+khC+BWFWsbN U8Rqq5dIEy9XqTjUl+g8pZeXZ5xVk/geuBY+eGo4= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k96QO-004rdb-Ey; Fri, 21 Aug 2020 13:45:40 +0100 MIME-Version: 1.0 Date: Fri, 21 Aug 2020 13:45:40 +0100 From: Marc Zyngier To: Catalin Marinas Subject: Re: [PATCH v4 3/3] arm64: Add workaround for Arm Cortex-A77 erratum 1508412 In-Reply-To: <20200821122633.GC6823@gaia> References: <20200803193127.3012242-1-robh@kernel.org> <20200803193127.3012242-4-robh@kernel.org> <20200821120659.GB6823@gaia> <20200821121209.GB20833@willie-the-truck> <20200821122633.GC6823@gaia> User-Agent: Roundcube Webmail/1.4.7 Message-ID: <8c641833ff20d5a35981c456d4fe1d5a@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, will@kernel.org, robh@kernel.org, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, ascull@google.com, julien.thierry.kdev@gmail.com, kvmarm@lists.cs.columbia.edu X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200821_084543_072351_5308C4F7 X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Suzuki K Poulose , James Morse , Andrew Scull , Julien Thierry , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-08-21 13:26, Catalin Marinas wrote: > On Fri, Aug 21, 2020 at 01:12:10PM +0100, Will Deacon wrote: >> On Fri, Aug 21, 2020 at 01:07:00PM +0100, Catalin Marinas wrote: >> > On Mon, Aug 03, 2020 at 01:31:27PM -0600, Rob Herring wrote: >> > > @@ -979,6 +980,14 @@ >> > > write_sysreg(__scs_new, sysreg); \ >> > > } while (0) >> > > >> > > +#define read_sysreg_par() ({ \ >> > > + u64 par; \ >> > > + asm(ALTERNATIVE("nop", "dmb sy", ARM64_WORKAROUND_1508412)); \ >> > > + par = read_sysreg(par_el1); \ >> > > + asm(ALTERNATIVE("nop", "dmb sy", ARM64_WORKAROUND_1508412)); \ >> > > + par; \ >> > > +}) >> > >> > I was about to queue this up but one more point to clarify: can we get >> > an interrupt at either side of the PAR_EL1 read and the handler do a >> > device read, triggering the erratum? Do we need a DMB at exception >> > entry/return? >> >> Disabling irqs around the PAR access would be simpler, I think >> (assuming >> this is needed). > > This wouldn't work if it interrupts a guest. If we take an interrupt either side of the PAR_EL1 read and that we fully exit, the saving of PAR_EL1 on the way out solves the problem. If we don't fully exit, but instead reenter the guest immediately (fixup_guest_exit() returns true), we'd need a DMB at that point, at least because of the GICv2 proxying code which performs device accesses on the guest's behalf. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel