From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 542D5C43381 for ; Mon, 1 Apr 2019 19:17:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21EA22084B for ; Mon, 1 Apr 2019 19:17:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cXJ0nG9O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21EA22084B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ifMn5G1WrHL8HIBvnexwPRYn0SWYRneszYt8sa53uYY=; b=cXJ0nG9Om63RPvQ1sTVh+ZszD hcM53POKfQASHzwbi3eWSQ5Zypd6or6ZmPAK9LH/XJV2DbVxpR/9Gf2dDM1qW7vZmq3zYKLICo7AW YELivRxz1Z4aU89PSi8lsYi0IimP1V6n4U/rUIDr+dJ5cjZ9cJuYCMczrT7VUR2LuQSKcOPZuhtvg 2SemtJmfSxxprZ/R+bdy+/KKZrkUjyo2gA94bPnOgW8TlfncQ6jROcOOpMVwBiqCCeyMMFi+/LaZv vRIMsok2/5zSEM9veJyDU+PaUoGXbUj6rN3QVdDWYuPUTX4ibKCLek8D0SJfoaXWQsvepvJWffFtB wGvc0bcbQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB2R3-00055I-76; Mon, 01 Apr 2019 19:17:33 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB2Qz-00054s-Rj for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 19:17:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 667F915AB; Mon, 1 Apr 2019 12:17:29 -0700 (PDT) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 81E623F59C; Mon, 1 Apr 2019 12:17:26 -0700 (PDT) Subject: Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver To: Neil Armstrong , Rob Herring , dri-devel@lists.freedesktop.org References: <20190401074730.12241-1-robh@kernel.org> <20190401074730.12241-4-robh@kernel.org> <40a521b3-a99c-2cd3-f3ac-cfec873fc934@baylibre.com> From: Robin Murphy Message-ID: <8cc9ab56-3c50-9081-7276-a918ab23c924@arm.com> Date: Mon, 1 Apr 2019 20:17:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <40a521b3-a99c-2cd3-f3ac-cfec873fc934@baylibre.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_121729_905672_512DA57E X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lyude Paul , Tomeu Vizoso , Eric Anholt , Maxime Ripard , Will Deacon , Joerg Roedel , Maarten Lankhorst , linux-kernel@vger.kernel.org, David Airlie , iommu@lists.linux-foundation.org, Alyssa Rosenzweig , Daniel Vetter , "Marty E . Plummer" , Sean Paul , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/04/2019 09:24, Neil Armstrong wrote: > On 01/04/2019 09:47, Rob Herring wrote: >> This adds the initial driver for panfrost which supports Arm Mali >> Midgard and Bifrost family of GPUs. Currently, only the T860 and >> T760 Midgard GPUs have been tested. >> >> v2: >> - Add GPU reset on job hangs (Tomeu) >> - Add RuntimePM and devfreq support (Tomeu) >> - Fix T760 support (Tomeu) >> - Add a TODO file (Rob, Tomeu) >> - Support multiple in fences (Tomeu) >> - Drop support for shared fences (Tomeu) >> - Fill in MMU de-init (Rob) >> - Move register definitions back to single header (Rob) >> - Clean-up hardcoded job submit todos (Rob) >> - Implement feature setup based on features/issues (Rob) >> - Add remaining Midgard DT compatible strings (Rob) >> >> Cc: Maarten Lankhorst >> Cc: Maxime Ripard >> Cc: Sean Paul >> Cc: David Airlie >> Cc: Daniel Vetter >> Cc: Alyssa Rosenzweig >> Cc: Lyude Paul >> Cc: Eric Anholt >> Signed-off-by: Marty E. Plummer >> Signed-off-by: Tomeu Vizoso >> Signed-off-by: Rob Herring >> --- >> Neil, I've kept your reset support separate for now. Let me know if you >> prefer me to squash it or keep it separate. > > You can squash all my changes and add my sign-off. FWIW, looking at Rob's branch there's a little bug in panfrost_reset_init(): + if (IS_ERR(pfdev->rstc)) { + dev_err(pfdev->dev, "get reset failed %ld\n", PTR_ERR(pfdev->clock)); Looks like that "pfdev->clock" should be "pfdev->rstc". Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel