From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B485C433DB for ; Fri, 5 Feb 2021 15:05:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16B46650DD for ; Fri, 5 Feb 2021 15:05:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16B46650DD Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LjD+hmdnvfg13rWd15MUZstD47ETEauUaw7NAlsqxL0=; b=mnQBpecyoP41jPTCxNezwZ8R5 PiPzJ4GvPxW/oVSEc/m7FLarouz/GFdEnvXh2wAEAX6XWNzrxCgtcxWminp1CT53W6dZoGjJu0602 JavaE+ycYxNX80g0RfgqjKMa7s1yjtrwqEFNZg/hkq8wB+k++PDd5utg151SOzK5yBcRSLUDOuMZF nXSpXi9BYkJRPR0zssoMLv+aoL1y13nYPwzXK665yq87ms0M+h+AlKM+R09B2piqyQaeDBZgFvdyh +NJsVRq+5omhJO1wdSONz5RpG/SGQDo24bhmT/wDdVZlltbFLg+j3DvLa5OSJHbkytMfGcsB3vlz8 95bIwTNLQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l82ei-0005M9-5f; Fri, 05 Feb 2021 15:04:20 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l82ef-0005LL-1O for linux-arm-kernel@lists.infradead.org; Fri, 05 Feb 2021 15:04:17 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 115F49g7009021; Fri, 5 Feb 2021 09:04:09 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1612537449; bh=tgXH0jDlzSuMvnwwTfnKlyIjhADidsODFnKRxzXzEik=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=LBeps3WPW3s/+y9bQeHBU93RH0dev6IU4YhvQrfO9y3Snopf3nm89bFwVpNZ7ImFO 7f+exNeDR+Ytmm+k/wSz91gPC2rNXhs3KWnImq108y1VBp1I9KxAkFgd6aFDqe9oLx pxTwy/9TAbynWF3+P6LdVjG9de5IqcHz7z87kGTE= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 115F49Lh044774 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Feb 2021 09:04:09 -0600 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 5 Feb 2021 09:04:09 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 5 Feb 2021 09:04:09 -0600 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 115F479B085244; Fri, 5 Feb 2021 09:04:07 -0600 Subject: Re: [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options. To: Tony Lindgren References: <20210203113426.18964-1-parazyd@dyne.org> <20210203113426.18964-2-parazyd@dyne.org> <4b32f566-92ad-3c49-0453-b44df23f1384@ti.com> <20210205131736.3jivrc5lln4t2onr@fq> <8ab86ccf-7568-c173-75f6-0d572fd43fec@ti.com> From: Grygorii Strashko Message-ID: <8daa6fce-bfad-ea28-e8dd-f3083bf43b01@ti.com> Date: Fri, 5 Feb 2021 17:04:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210205_100417_171983_47B79BE8 X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-omap@vger.kernel.org, "Ivan J." , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/02/2021 16:46, Tony Lindgren wrote: > * Grygorii Strashko [210205 14:25]: >> On 05/02/2021 15:30, Tony Lindgren wrote: >>> Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig >>> for the other cases that do not use KS8851? >> >> The KS8851 config was added like 10years ago and is used on some omap4 platforms, >> it does select MICREL_PHY. >> >> From other side, *some* am57x, am437 platforms uses MICREL PHYs with no dependency from KS8851. >> >> The omap2plus_defconfig is also used as base for custom configs and first thing people are doing - >> remove not needed options. As result, removal of KS8851 plus this patch will immediately >> cause MICREL_PHY=n and so breakage on existing and custom platforms. >> >> I do not see how it can be resolved by using Kconfig changes within much-omap2. >> >> So, sry, but NACK for this patch as it is. > > We can wait on this patch no problem while we figure this out. > But certainly we need to fix things so make savedefconfig > produces valid configs that don't need to be manually edited. > >> if some Kconfig dependencies need to be sorted out - probably the best way might be >> to get rid of select MICREL_PHY in KS8851/KS8851_MLL. > > That will potentially break things too as the configs now expect > it to be selected :) Looks like that got changed with commit > f0791b92d2b6 ("net: ks8851: Select PHYLIB and MICREL_PHY in > Kconfig"). Yah. It's really has to be "depends on". > > So why can't we do similar patches to select MICREL_PHY for > the other non-ks8851 configurations in drivers/net/ethernet > Kconfig files as needed? because there is no dependency between Ethernet controller (CPSW) and Ethernet PHY - any MII capable PHY can be used with CPSW. -- Best regards, grygorii _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel