From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 771CCC433B4 for ; Mon, 17 May 2021 10:27:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBCC360E0C for ; Mon, 17 May 2021 10:27:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBCC360E0C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e+jDWadIZar4XP9mTlmILTAQOGyD4ydI2uDbjJ1bc1g=; b=N9zDrRa9Sk2Gc2flD29WF020e RcAPUUdZXADcaaadjovhgScXyYl/Bey+x0Yis/vpJ9hRLgBFTQouzWu9B//AzwIek+cP9F+eg5NB5 V2LSFP1ZwkZNItFiYN2cyxNFYxNqJR8XP7MzdIDeOGNocwzZ0CocLfLiCxxPfngZK/x2CUCgmeoCt Jfw+gIuDdHfocaXnhKbfEstYZ6UtZowyV/ou9IrMKONoS1nX6a2zuWNkyq9PPspuhUiw94Bkm1hzW FvHGJW6X88kX4b+y4Df8oO0TH+qOSu2V5eiJAm98/hbcYm51KD+Bn2o0R9msfJwNRdNwxqDrlnkPI cZhDwndvg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liaR6-00EZWk-Hx; Mon, 17 May 2021 10:25:20 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liaQn-00EZR7-3g for linux-arm-kernel@desiato.infradead.org; Mon, 17 May 2021 10:25:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=1uqNXUpVyuomhEWX3uzRubVqH//B/oaEGgllzNXN/bQ=; b=BzZP+z145YE0z8/l3hu678aSds an4+IVbj70921eLmHy5KBqTZHF6z9kpJDyDorGxQdl9WQjx0EE4GjZFvRkjEX2TxGOXATlpPArzZI gAuZcaJZhFjBsG4ApXDZA7TyYbhOsvkFUL6KhhUiqHUQgsMKIWxNzpP7J9xqAWqfNV/tNGKLn/WM3 UDdJ1g7f9dh0hhsjmeloet3zpQ2aPu0DAwuCBlE4lsAZB9KnfsazyqX+b+g/IU7i8vD2QJwW1tVdx cg1Yqm28GA9vV0h113CJ07oIVAGhQYBZ7IBLgxv2GISU1dt/COEStuB2q+uOS9k6FKLvT/JN5tohm 4HzWAGCQ==; Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liaQj-00Dg2C-9b for linux-arm-kernel@lists.infradead.org; Mon, 17 May 2021 10:24:59 +0000 Received: by mail-wr1-x430.google.com with SMTP id j14so4052088wrq.5 for ; Mon, 17 May 2021 03:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1uqNXUpVyuomhEWX3uzRubVqH//B/oaEGgllzNXN/bQ=; b=s71N+Em/VMij/lL/5g5CtNDBocNukAPXqlIoUo7Uyt+f+cF+yWkr9s7CQ3qv/6lQPI Yb1UdBUD14KQw3qsG84gfZ96qWozHhlyj7gbdOp2qWx4DWj6jGhPCTil3B0F67k9zQhu woOh/nF21F8Uo06a9hXOu+1I53OjT9b/Zbzgp6kVbk6yE3CAfVAbVEeiXlwImzDwFIc+ N0PFWdi+jEVZvATjC+4QXCHSMbFwCiSdRb1s3FrIlrTivn17VUtNPX5piWM1g1l1KXyX ifPebyVmh9iKuncI9eKLJoRmBW2/lCPjw5lDbjpCJsNHIA/nrzNh32PJgOhE6GRa/1bL p6yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1uqNXUpVyuomhEWX3uzRubVqH//B/oaEGgllzNXN/bQ=; b=b2uj/U/onlGYwM0vgUfriNpgXXrUa9pQkbYr/VM4wDBd0hzVObdft4qMwPIFff/1XX 3xBsIqojYwAPb/2cSUxLAIha1L0B19Aklec8H34vghA658ZKTrmKyiAGKLYm3d1yxi0U tRzcDE8GxNc+yzmY6FHScLwqjeYis/eNXPiFID0i8u9KDS78d0pCmM1r0O9mTSO1rP9m UOxVK6cF4wjUPaS1jQxol0vmYBdw9W4aS3z4LqYWex5jtcB/mmq6jWcHo9Q4Xu5OISdn 5aaqzDkTBr+iOD2+teUnYI4ZN4UBP7IwETPSV/LLmH97+3TXu21eyloGq2GWjTEb4zf8 Bg7Q== X-Gm-Message-State: AOAM5303C4scoeNoPO3nm4Ffmh1uJDHtKmpmGjMQ0Bnqs3nt1g/ID3X1 XEcQtvE+8PrTT+rsxZycC6vhWEgLdfVqmWV5 X-Google-Smtp-Source: ABdhPJyvDDcgOB1SFtKlawbsc996gmsnMdi83ARlyPr2D3PYLKd4sf/6Tow1BtYpLrEXi7LIhr3ebg== X-Received: by 2002:a05:6000:188d:: with SMTP id a13mr38290175wri.61.1621247094350; Mon, 17 May 2021 03:24:54 -0700 (PDT) Received: from ?IPv6:2a01:e0a:90c:e290:3044:ffc:eaa9:6a70? ([2a01:e0a:90c:e290:3044:ffc:eaa9:6a70]) by smtp.gmail.com with ESMTPSA id y21sm21092169wmi.15.2021.05.17.03.24.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 May 2021 03:24:53 -0700 (PDT) Subject: Re: [PATCH v13 0/4] drm/panfrost: Add support for mt8183 GPU To: Steven Price , Ezequiel Garcia Cc: Nicolas Boichat , Rob Herring , Alyssa Rosenzweig , devicetree , Tomeu Vizoso , fshao@chromium.org, David Airlie , Linux Kernel Mailing List , Rob Herring , Boris Brezillon , "moderated list:ARM/Mediatek SoC support" , dri-devel , hsinyi@chromium.org, Matthias Brugger , hoegsberg@chromium.org, linux-arm-kernel References: <20210421052855.1279713-1-drinkcat@chromium.org> <373d0803-8658-9413-2f51-1e9804c39126@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: <8e35886c-7b51-aa93-5f9c-df0fae635828@baylibre.com> Date: Mon, 17 May 2021 12:24:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210517_032457_350445_DD0F808A X-CRM114-Status: GOOD ( 30.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/05/2021 17:27, Steven Price wrote: > On 14/05/2021 15:48, Neil Armstrong wrote: >> On 13/05/2021 16:55, Ezequiel Garcia wrote: >>> Hi Neil, >>> >>> On Mon, 26 Apr 2021 at 06:59, Neil Armstrong wrote: >>>> >>>> Hi, >>>> >>>> On 21/04/2021 07:28, Nicolas Boichat wrote: >>>>> Hi! >>>>> >>>>> This is just a rebase of the v11, untested (but it seems like >>>>> Neil Armstrong recently tested it), with small changes in >>>>> binding and dts. v11 cover follows: >>>>> >>>>> Follow-up on the v5 [1], things have gotten significantly >>>>> better in the last year, thanks to the efforts on Bifrost >>>>> support by the Collabora team (and probably others I'm not >>>>> aware of). >>>>> >>>>> I've been testing this series on a MT8183/kukui device, with a >>>>> chromeos-5.10 kernel [2], and got basic Chromium OS UI up with >>>>> mesa 20.3.2 (lots of artifacts though). >>>>> >>>>> devfreq is currently not supported, as we'll need: >>>>> - Clock core support for switching the GPU core clock (see 2/4). >>>>> - Platform-specific handling of the 2-regulator (see 3/4). >>>>> >>>>> Since the latter is easy to detect, patch 3/4 just disables >>>>> devfreq if the more than one regulator is specified in the >>>>> compatible matching table. >>>>> >>>>> [1] https://patchwork.kernel.org/project/linux-mediatek/cover/20200306041345.259332-1-drinkcat@chromium.org/ >>>>> [2] https://crrev.com/c/2608070 >>>>> >>>>> Changes in v13: >>>>> - devfreq: Fix conflict resolution mistake when rebasing, didn't >>>>> even compile. Oops. >>>>> >>>>> Changes in v12: >>>>> - binding: Fix min/maxItems logic (Rob Herring) >>>>> - Add gpu node to mt8183-pumpkin.dts as well (Neil Armstrong). >>>>> >>>>> Changes in v11: >>>>> - binding: power-domain-names not power-domainS-names >>>>> - mt8183*.dts: remove incorrect supply-names >>>>> >>>>> Changes in v10: >>>>> - Fix the binding to make sure sram-supply property can be provided. >>>>> >>>>> Changes in v9: >>>>> - Explain why devfreq needs to be disabled for GPUs with >1 >>>>> regulators. >>>>> >>>>> Changes in v8: >>>>> - Use DRM_DEV_INFO instead of ERROR >>>>> >>>>> Changes in v7: >>>>> - Fix GPU ID in commit message >>>>> - Fix GPU ID in commit message >>>>> >>>>> Changes in v6: >>>>> - Rebased, actually tested with recent mesa driver. >>>>> - Add gpu regulators to kukui dtsi as well. >>>>> - Power domains are now attached to spm, not scpsys >>>>> - Drop R-B. >>>>> - devfreq: New change >>>>> - Context conflicts, reflow the code. >>>>> - Use ARRAY_SIZE for power domains too. >>>>> >>>>> Changes in v5: >>>>> - Rename "2d" power domain to "core2" >>>>> - Rename "2d" power domain to "core2" (keep R-B again). >>>>> - Change power domain name from 2d to core2. >>>>> >>>>> Changes in v4: >>>>> - Add power-domain-names description >>>>> (kept Alyssa's reviewed-by as the change is minor) >>>>> - Add power-domain-names to describe the 3 domains. >>>>> (kept Alyssa's reviewed-by as the change is minor) >>>>> - Add power domain names. >>>>> >>>>> Changes in v3: >>>>> - Match mt8183-mali instead of bifrost, as we require special >>>>> handling for the 2 regulators and 3 power domains. >>>>> >>>>> Changes in v2: >>>>> - Use sram instead of mali_sram as SRAM supply name. >>>>> - Rename mali@ to gpu@. >>>>> >>>>> Nicolas Boichat (4): >>>>> dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 >>>>> arm64: dts: mt8183: Add node for the Mali GPU >>>>> drm/panfrost: devfreq: Disable devfreq when num_supplies > 1 >>>>> drm/panfrost: Add mt8183-mali compatible string >>>>> >>>>> .../bindings/gpu/arm,mali-bifrost.yaml | 30 ++++- >>>>> arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 5 + >>>>> .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 5 + >>>>> .../boot/dts/mediatek/mt8183-pumpkin.dts | 5 + >>>>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 105 ++++++++++++++++++ >>>>> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 ++ >>>>> drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ++ >>>>> 7 files changed, 168 insertions(+), 1 deletion(-) >>>>> >>>> >>>> Seems this version is ready to be applied if we get a review on the DT ? >>>> >>>> Mathias ? could you have a look ? >>>> >>> >>> Given Rob has Acked the DT bindings, I think it's OK to apply patches >>> 1, 3 and 4 via drm-misc, letting Mediatek people sort out the DT changes. >>> >>> My two unsolicited cents :-) > > You make a convincing point - and if everyone is happy for the DT > changes to be handled separately I don't see a reason for the other > patches to be held up. > >> Yeah sure, is there a panfrost maintainer in the room ? I can apply them if you ack me. > > I seem to be applying most Panfrost changes these days, so I'll save you > the effort and push 1,3,4 to drm-misc-next. Thanks ! Neil > > Thanks, > > Steve > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel