From: Peter Rosin <peda@axentia.se>
To: Ingo van Lil <inguin@gmx.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>
Subject: Re: [PATCH] ARM: dts: at91: Reenable UART TX pull-ups
Date: Tue, 3 Dec 2019 13:04:56 +0000 [thread overview]
Message-ID: <8e8dfc02-bdab-d6f1-f6e9-e1dba7e38bfd@axentia.se> (raw)
In-Reply-To: <20191128100629.10247-1-inguin@gmx.de>
On 2019-11-28 11:06, Ingo van Lil wrote:
> Pull-ups for SAM9 UART/USART TX lines were disabled in 5e04822f.
> However, several chips in the SAM9 family require pull-ups to prevent
> the TX lines from falling (and causing an endless break condition) when
> the transceiver is disabled.
>
> From the SAM9G20 datasheet, 32.5.1: "To prevent the TXD line from
> falling when the USART is disabled, the use of an internal pull up
> is mandatory.". This commit reenables the pull-ups for all chips having
> that sentence in their datasheets.
>
> Signed-off-by: Ingo van Lil <inguin@gmx.de>
Sounds reasonable, and sorry for the breakage. However, perhaps a proper
fixes tag (with the prescribed length of the commit hash) should be in
there somewhere?
Fixes: 5e04822f7db5 ("ARM: dts: at91: fixes uart pinctrl, set pullup on rx, clear pullup on tx")
Also, I think the same kind of change was made to the barebox bootloader
at about the same time. Is there a fix for that queued up as well?
Cheers,
Peter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-03 13:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 10:06 [PATCH] ARM: dts: at91: Reenable UART TX pull-ups Ingo van Lil
2019-12-03 13:04 ` Peter Rosin [this message]
2019-12-03 13:22 ` Ingo van Lil
2019-12-03 14:21 Ingo van Lil
2019-12-10 10:57 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e8dfc02-bdab-d6f1-f6e9-e1dba7e38bfd@axentia.se \
--to=peda@axentia.se \
--cc=alexandre.belloni@bootlin.com \
--cc=inguin@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).