From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88AA8C7618A for ; Mon, 20 Mar 2023 06:57:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eW8XnEsF1ZUzj9lc+01pydiq9J8oRdwJQMz8+KKxE1E=; b=y2e8RtkVrsHse6 1GrTDf1PTLuMB6H07vY4LmgSDPOxzpxqEm7Ot7jhCGxs+y7z1C7zwj8KRpWfcRY1u/RMY2y3stvGA YIlkrLy0FJj+VV6XTte7wP56DpGwySYkvrlhfD4f/Tewk9OQqzWynWBOce1cij5FuDrSwny3Z/i5B tR6VlJ8mUQ3AVARWypu0YFEOc1y0zXPxEk8h9E296oYMEQX+a1FnCjeqdVOjfnu2cENzb8KtQnstT othZoe1rCGrI3PpET3P2MRRuNhzS63rDTgMCxX3u7QG1tlX0yxs9mrki6X6iw7B65tXEnMTo0Dkmv 3+Vdf6B9vOKxJPDft88Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pe9Ri-008G6u-0z; Mon, 20 Mar 2023 06:56:42 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pe9Rf-008G6L-2n for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 06:56:41 +0000 Received: by mail-ed1-x532.google.com with SMTP id cy23so42501161edb.12 for ; Sun, 19 Mar 2023 23:56:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679295398; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vfLXUx+fo1d9D24eInD6agATEFZbbnm2b1x2hRrynjc=; b=WmgeT1VbmEwuWwx3DdsvKVOfiv+2YAjbT+eIbMM+TCeEBqgzCxeP+bq7Mhsru2qKNe stMevTmKALpZSrZr8J2AABqJTUAJg6vZy3can26JzN1tVL0ED2urd6w4DBxJvkL0Q8/X 0PmsxOhEjDh+GJGGlkl51nC0NlqQQa2tIR/rJ1Wkrx+wyCwd0p8LVW2e7eqtvYTyqFVS +/WwBeh5v/VvbzFDSUoCab3OAV55efT9jDlruR27rzTMDVdmlmu48l+yjej0MsO3ZzVf F/CJpzfhqd8pis8RaM7KwjsuhGL3YwLOERotFI0Sj+xUmKR0wYLD/GL/Pka4ENTE6Zd+ IicA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679295398; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vfLXUx+fo1d9D24eInD6agATEFZbbnm2b1x2hRrynjc=; b=5J2BFZ1is5yzhBAvlzI1t76Nw4FhFsHN9T4J0cOSr9V+3pDliyFM+2AmaASzLEqnNQ 0Z2wfFpiUQy09HWJ2Qr55UOcvcYcoZGiD9ZujEXK4xQB5mxI6/I4jiPmgm3mwyWszUzt cwt9iUzJuu/ln2ysA8CsDDpsvT/b+7TrhBKE1z+2Wna394mltjj8evcoz4/47txcuVDq ZqC+HM7Rr42+E46G91Wmz/qyY2W+K2CY5GpPEcflJsxHzHdcHQc/7tP7iHvPhglMZGAG cAvfrdP7iC9a/waNWjWNjx4YP5NI9ds3OMWauWp6sbk3kHe+GX8wRT8y3PsOAgSD1uY/ yXVQ== X-Gm-Message-State: AO0yUKXWbKBMY+6EPGdzaYTwB9TiExS1rZ2PPrIFeq1A1xNWFwMHdMjL 5l0GLq2DPSOpN7uLEJHiTw2nNQ== X-Google-Smtp-Source: AK7set+eelwgbHAfQDS1bd88SeVWm0S+doVlMXVqJxptbcf3JDl94fX2visYiyudEs6esSi3ew68Qg== X-Received: by 2002:a17:906:8cd:b0:922:446b:105a with SMTP id o13-20020a17090608cd00b00922446b105amr7847083eje.19.1679295398508; Sun, 19 Mar 2023 23:56:38 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:4428:8354:afb6:2992? ([2a02:810d:15c0:828:4428:8354:afb6:2992]) by smtp.gmail.com with ESMTPSA id n18-20020a170906379200b0093237bd4bc3sm3521846ejc.116.2023.03.19.23.56.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Mar 2023 23:56:37 -0700 (PDT) Message-ID: <8efe78d3-ff50-1970-3a90-28bab4992bad@linaro.org> Date: Mon, 20 Mar 2023 07:56:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH linux-next] dt-bindings: usb: snps,dwc3: correct i.MX8MQ support Content-Language: en-US To: "Peng Fan (OSS)" , gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, xu.yang_2@nxp.com Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jun.li@nxp.com, Peng Fan References: <20230320020714.955800-1-peng.fan@oss.nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20230320020714.955800-1-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230319_235639_912145_55ABAA83 X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/03/2023 03:07, Peng Fan (OSS) wrote: > From: Peng Fan > > The previous i.MX8MQ support breaks rockchip,dwc3 support, > so use select to restrict i.MX8MQ support and avoid break others. > > Fixes: 3754c41c7686 ("dt-bindings: usb: snps,dwc3: support i.MX8MQ") > Signed-off-by: Peng Fan > --- > .../devicetree/bindings/usb/snps,dwc3.yaml | 21 ++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > index 16c7d06c9172..6347a6769ee3 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > @@ -28,15 +28,22 @@ allOf: > else: > $ref: usb-xhci.yaml# > > +select: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mq-dwc3 And what about all snps,dwc3 devices there (without specific compatible)? Previously they were selected and now they are not... so you just disabled schema for all of them. > + required: > + - compatible > + > properties: > compatible: > - oneOf: > - - items: > - - const: fsl,imx8mq-dwc3 I don't understand why you remove your compatible. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel