From: Matthias Brugger <matthias.bgg@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v3] arm64: dts: mediatek: align GPIO hog names with dtschema
Date: Thu, 29 Oct 2020 16:52:34 +0100 [thread overview]
Message-ID: <8f3369aa-ebb2-0e4e-fc1f-109e54d63b7d@gmail.com> (raw)
In-Reply-To: <20201002163940.7837-1-krzk@kernel.org>
On 02/10/2020 18:39, Krzysztof Kozlowski wrote:
> The convention for node names is to use hyphens, not underscores.
> dtschema for pca95xx expects GPIO hogs to end with 'hog' suffix.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Pushed to v5.10-next/dts64
Thanks!
> ---
> .../boot/dts/mediatek/pumpkin-common.dtsi | 26 +++++++++----------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> The dt-schema changes were applied.
>
> diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> index 29d8cf6df46b..351a1905a074 100644
> --- a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> @@ -63,91 +63,91 @@
> gpio-controller;
> #gpio-cells = <2>;
>
> - eint20_mux_sel0 {
> + eint20-mux-sel0-hog {
> gpio-hog;
> gpios = <0 0>;
> input;
> line-name = "eint20_mux_sel0";
> };
>
> - expcon_mux_sel1 {
> + expcon-mux-sel1-hog {
> gpio-hog;
> gpios = <1 0>;
> input;
> line-name = "expcon_mux_sel1";
> };
>
> - mrg_di_mux_sel2 {
> + mrg-di-mux-sel2-hog {
> gpio-hog;
> gpios = <2 0>;
> input;
> line-name = "mrg_di_mux_sel2";
> };
>
> - sd_sdio_mux_sel3 {
> + sd-sdio-mux-sel3-hog {
> gpio-hog;
> gpios = <3 0>;
> input;
> line-name = "sd_sdio_mux_sel3";
> };
>
> - sd_sdio_mux_ctrl7 {
> + sd-sdio-mux-ctrl7-hog {
> gpio-hog;
> gpios = <7 0>;
> output-low;
> line-name = "sd_sdio_mux_ctrl7";
> };
>
> - hw_id0 {
> + hw-id0-hog {
> gpio-hog;
> gpios = <8 0>;
> input;
> line-name = "hw_id0";
> };
>
> - hw_id1 {
> + hw-id1-hog {
> gpio-hog;
> gpios = <9 0>;
> input;
> line-name = "hw_id1";
> };
>
> - hw_id2 {
> + hw-id2-hog {
> gpio-hog;
> gpios = <10 0>;
> input;
> line-name = "hw_id2";
> };
>
> - fg_int_n {
> + fg-int-n-hog {
> gpio-hog;
> gpios = <11 0>;
> input;
> line-name = "fg_int_n";
> };
>
> - usba_pwr_en {
> + usba-pwr-en-hog {
> gpio-hog;
> gpios = <12 0>;
> output-high;
> line-name = "usba_pwr_en";
> };
>
> - wifi_3v3_pg {
> + wifi-3v3-pg-hog {
> gpio-hog;
> gpios = <13 0>;
> input;
> line-name = "wifi_3v3_pg";
> };
>
> - cam_rst {
> + cam-rst-hog {
> gpio-hog;
> gpios = <14 0>;
> output-low;
> line-name = "cam_rst";
> };
>
> - cam_pwdn {
> + cam-pwdn-hog {
> gpio-hog;
> gpios = <15 0>;
> output-low;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-10-29 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 16:39 [RESEND PATCH v3] arm64: dts: mediatek: align GPIO hog names with dtschema Krzysztof Kozlowski
2020-10-29 15:52 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f3369aa-ebb2-0e4e-fc1f-109e54d63b7d@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).