From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Mike Leach <mike.leach@linaro.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: mathieu.poirier@linaro.org, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org,
linux-perf-users@vger.kernel.org, leo.yan@linaro.org,
quic_jinlmao@quicinc.com
Subject: Re: [PATCH v3 04/13] coresight: etm4x: Update ETM4 driver to use Trace ID API
Date: Mon, 3 Oct 2022 10:37:26 +0100 [thread overview]
Message-ID: <8f865045-aa95-46b6-a455-c3d9c6d26494@arm.com> (raw)
In-Reply-To: <01570ba2-81c9-e4b5-6669-0e4087a4bd1f@arm.com>
On 03/10/2022 10:31, Suzuki K Poulose wrote:
> On 09/08/2022 23:33, Mike Leach wrote:
>> The trace ID API is now used to allocate trace IDs for ETM4.x / ETE
>> devices.
>>
>> For perf sessions, these will be allocated on enable, and released on
>> disable.
>>
>> For sysfs sessions, these will be allocated on enable, but only released
>> on reset. This allows the sysfs session to interrogate the Trace ID used
>> after the session is over - maintaining functional consistency with the
>> previous allocation scheme.
>>
>> The trace ID will also be allocated on read of the mgmt/trctraceid file.
>> This ensures that if perf or sysfs read this before enabling trace, the
>> value will be the one used for the trace session.
>>
>> Trace ID initialisation is removed from the _probe() function.
>>
>> Signed-off-by: Mike Leach <mike.leach@linaro.org>
>> ---
>> .../coresight/coresight-etm4x-core.c | 79 +++++++++++++++++--
>> .../coresight/coresight-etm4x-sysfs.c | 27 ++++++-
>> drivers/hwtracing/coresight/coresight-etm4x.h | 3 +
>> 3 files changed, 100 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c
>> b/drivers/hwtracing/coresight/coresight-etm4x-core.c
>> index cf249ecad5a5..b4fb28ce89fd 100644
>> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
>> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
>> @@ -42,6 +42,7 @@
>> #include "coresight-etm4x-cfg.h"
>> #include "coresight-self-hosted-trace.h"
>> #include "coresight-syscfg.h"
>> +#include "coresight-trace-id.h"
>> static int boot_enable;
>> module_param(boot_enable, int, 0444);
>> @@ -234,6 +235,50 @@ static int etm4_trace_id(struct coresight_device
>> *csdev)
>> return drvdata->trcid;
>> }
>> +int etm4_read_alloc_trace_id(struct etmv4_drvdata *drvdata)
>> +{
>> + int trace_id;
>> +
>> + /*
>> + * This will allocate a trace ID to the cpu,
>> + * or return the one currently allocated.
>> + */
>> + /* trace id function has its own lock */
>> + trace_id = coresight_trace_id_get_cpu_id(drvdata->cpu);
>> + if (IS_VALID_ID(trace_id))
>> + drvdata->trcid = (u8)trace_id;
>> + else
>> + dev_err(&drvdata->csdev->dev,
>> + "Failed to allocate trace ID for %s on CPU%d\n",
>> + dev_name(&drvdata->csdev->dev), drvdata->cpu);
>> + return trace_id;
>> +}
>> +
>> +static int etm4_set_current_trace_id(struct etmv4_drvdata *drvdata)
>> +{
>> + int trace_id;
>> +
>> + /*
>> + * Set the currently allocated trace ID - perf allocates IDs
>> + * as part of setup_aux for all CPUs it may use.
>> + */
>> + trace_id = coresight_trace_id_read_cpu_id(drvdata->cpu);
>> + if (IS_VALID_ID(trace_id)) {
>> + drvdata->trcid = (u8)trace_id;
>> + return 0;
>> + }
>> +
>> + dev_err(&drvdata->csdev->dev, "Failed to set trace ID for %s on
>> CPU%d\n",
>> + dev_name(&drvdata->csdev->dev), drvdata->cpu);
>> +
>> + return -EINVAL;
>> +}
>
>
>> +
>> +void etm4_release_trace_id(struct etmv4_drvdata *drvdata)
>> +{
>> + coresight_trace_id_put_cpu_id(drvdata->cpu);
>> +}
>> +
>> struct etm4_enable_arg {
>> struct etmv4_drvdata *drvdata;
>> int rc;
>> @@ -729,6 +774,15 @@ static int etm4_enable_perf(struct
>> coresight_device *csdev,
>> ret = etm4_parse_event_config(csdev, event);
>> if (ret)
>> goto out;
>> +
>> + /*
>> + * perf allocates cpu ids as part of setup - device needs to use
>> + * the allocated ID.
>> + */
>> + ret = etm4_set_current_trace_id(drvdata);
>
> So, when do we allocate an id in perf mode ? As far as I can see, this
> should be the same as etm4_read_alloc_trace_id() ? Why are they any
> different ?
>
>> + if (ret < 0)
>> + goto out;
>> +
>> /* And enable it */
>> ret = etm4_enable_hw(drvdata);
>> @@ -753,6 +807,11 @@ static int etm4_enable_sysfs(struct
>> coresight_device *csdev)
>> spin_lock(&drvdata->spinlock);
>> + /* sysfs needs to read and allocate a trace ID */
>> + ret = etm4_read_alloc_trace_id(drvdata);
>> + if (ret < 0)
>> + goto unlock_sysfs_enable;
>> +
>> /*
>> * Executing etm4_enable_hw on the cpu whose ETM is being enabled
>> * ensures that register writes occur when cpu is powered.
>> @@ -764,6 +823,11 @@ static int etm4_enable_sysfs(struct
>> coresight_device *csdev)
>> ret = arg.rc;
>> if (!ret)
>> drvdata->sticky_enable = true;
>> +
>> + if (ret)
>> + etm4_release_trace_id(drvdata);
>> +
>> +unlock_sysfs_enable:
>> spin_unlock(&drvdata->spinlock);
>> if (!ret)
>> @@ -895,6 +959,8 @@ static int etm4_disable_perf(struct
>> coresight_device *csdev,
>> /* TRCVICTLR::SSSTATUS, bit[9] */
>> filters->ssstatus = (control & BIT(9));
>> + /* The perf event will release trace ids when it is destroyed */
>> +
>
> At this patch level, there is no release of trace id ? Is that missed in
> this patch ? Or am I missing something ?
I think the above change only comes in PATCH 7. May be that patch needs
to be rearranged in order ? Otherwise git-bisect can break running a
perf session on cs_etm, with missing traceid.
Suzuki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-03 9:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 22:33 [PATCH v3 00/13] coresight: Add new API to allocate trace source ID values Mike Leach
2022-08-09 22:33 ` [PATCH v3 01/13] coresight: trace-id: Add API to dynamically assign Trace " Mike Leach
2022-10-03 8:55 ` Suzuki K Poulose
2022-10-11 10:22 ` Mike Leach
2022-08-09 22:33 ` [PATCH v3 02/13] coresight: Remove obsolete Trace ID unniqueness checks Mike Leach
2022-10-03 8:56 ` Suzuki K Poulose
2022-08-09 22:33 ` [PATCH v3 03/13] coresight: stm: Update STM driver to use Trace ID API Mike Leach
2022-10-03 9:04 ` Suzuki K Poulose
2022-10-06 13:54 ` Mike Leach
2022-10-07 17:53 ` Suzuki K Poulose
2022-10-11 11:10 ` Mike Leach
2022-10-11 15:10 ` Suzuki K Poulose
2022-08-09 22:33 ` [PATCH v3 04/13] coresight: etm4x: Update ETM4 " Mike Leach
2022-10-03 9:31 ` Suzuki K Poulose
2022-10-03 9:37 ` Suzuki K Poulose [this message]
2022-10-06 13:47 ` Mike Leach
2022-08-09 22:33 ` [PATCH v3 05/13] coresight: etm3x: Update ETM3 " Mike Leach
2022-08-13 9:53 ` kernel test robot
2022-08-13 13:48 ` kernel test robot
2022-08-09 22:33 ` [PATCH v3 06/13] coresight: etmX.X: stm: Remove trace_id() callback Mike Leach
2022-08-09 22:33 ` [PATCH v3 07/13] coresight: perf: traceid: Add perf notifiers for Trace ID Mike Leach
2022-08-09 22:33 ` [PATCH v3 08/13] perf: cs-etm: Move mapping of Trace ID and cpu into helper function Mike Leach
2022-08-09 22:33 ` [PATCH v3 09/13] perf: cs-etm: Update record event to use new Trace ID protocol Mike Leach
2022-08-09 22:33 ` [PATCH v3 10/13] kernel: events: Export perf_report_aux_output_id() Mike Leach
2022-08-09 22:33 ` [PATCH v3 11/13] perf: cs-etm: Handle PERF_RECORD_AUX_OUTPUT_HW_ID packet Mike Leach
2022-08-09 22:34 ` [PATCH v3 12/13] coresight: events: PERF_RECORD_AUX_OUTPUT_HW_ID used for Trace ID Mike Leach
2022-08-09 22:34 ` [PATCH v3 13/13] coresight: trace-id: Add debug & test macros to Trace ID allocation Mike Leach
2022-10-03 11:06 ` Suzuki K Poulose
2022-10-06 13:22 ` Mike Leach
2022-08-12 19:50 ` [PATCH v3 00/13] coresight: Add new API to allocate trace source ID values Arnaldo Carvalho de Melo
2022-08-15 19:04 ` Mike Leach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f865045-aa95-46b6-a455-c3d9c6d26494@arm.com \
--to=suzuki.poulose@arm.com \
--cc=acme@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=quic_jinlmao@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).