From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20D91C433F7 for ; Fri, 10 Jul 2020 14:23:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5AB22082E for ; Fri, 10 Jul 2020 14:23:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Gw8fIDa9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X9+/pEXd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5AB22082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e/KpwkaCvh0GgwoVFaPOAHS/bAOghuN3VHr0kHXPj90=; b=Gw8fIDa9WJMijN9rPsGWbzNKr 5lperR4+/P/LMl94F8lCO68MBKixpdw5gmToHHCWIwDG4xMrrcQD7CeWsSArL15DaGjSpXTTxgjfi bqukxblJAr4xEBQnpSfdaY88L5G72hyPqF0LlCLkOq1YNtMbOVIj6yAuk1G13niPiV7CNgCbDAEPO ra+EuuJV+14JDz2qBOJ6jey1ogi2DVDjCBquzwZG8l+sfz5zTH4jPvHnDN1VRqLKmK/n+MWZiQFGa 0oqbm3gklcbW8IFX6t8YlSA/hqRVXQHLpxrjVn6EzX0cbXkRI31rVCft7ctqG9dsq4orzokyKBdvS zW02kT6rg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jttvA-0001Zl-4v; Fri, 10 Jul 2020 14:22:36 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jttv6-0001Yq-It; Fri, 10 Jul 2020 14:22:33 +0000 Received: by mail-wr1-x444.google.com with SMTP id q5so6147982wru.6; Fri, 10 Jul 2020 07:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LEJ3zYvTfGrKmD+ae/cPl+VgTxAxQL0fzNUPamOViPo=; b=X9+/pEXdpr1K4+XSEpiihmAVrzlTSh9AvhCpZ1TT5EtzVA8SYaVCzSQ9BMSanw+fKK WdlhXgKWZwECObQPt26ubfSqHlU3O2ktgUFH2XTbZXurl+94BgHmVlJWInN/I1EHmcQb Xb8v6waUWAlg5Ru3NZ7BFYlugCUr3PGrRbbzVdCplVs7JHkyKRZF3Ooa8EBncSMB9mDm K73NYwapKl57R36txM6pqc5U8Be96pM5Tx8yNyoqyZ4sPa/4vjndKAVeo2OG6tK3PUG6 vvKk8AJfidqMUv66SWHxXl46EqaFF6AUv//8GZVRq2oZLXEDUEkC/Bxbu+0I0w9vIJo6 NbZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LEJ3zYvTfGrKmD+ae/cPl+VgTxAxQL0fzNUPamOViPo=; b=iZHmLB2PpXSf+R9z7QehUwCUFf4/tq13bKeZc069rRWNXk1s5Pqn8Gd7fZAZ1kaixz /L7WpTvTP8n3BvyZlXCuTd+0IeNn5cQRkJAdmUlkDg+OFMrkldG634VCroxCfWRYae8m 68HXOqbuNDG1mqBj9lEy3eO+kSXNg2vZPfeJFqQ3DX4syn081rOxFT3P/fLVuuVodUkC hQ4D4VnxTWL3hX8aWyZFeF2xBXPB5AFloKmEHRmmo7xL/Ha7QjITCaF6AgAhLPQd99lG 5AjyIpFlHKY3NK/xhXPXdoqRbIS3QBlffRkFT2w8fCEaVVC4k+0CjGDJSvzeGgvrn1/d Ht7g== X-Gm-Message-State: AOAM532DAIVLVlw/LaQtv2BihTKYtCWYbPczYECgybvCfs3soYB42XHG KrbcU/3EZd5+9y3Yjb0AL8E= X-Google-Smtp-Source: ABdhPJz1Za73KdbK9/8MGC1MEJtJodCx3hWEMA1G66Dae+DZ3G7snbuf+Xb/YCQtgqSP7L7TPVGyuA== X-Received: by 2002:a5d:5084:: with SMTP id a4mr70431336wrt.191.1594390951534; Fri, 10 Jul 2020 07:22:31 -0700 (PDT) Received: from ziggy.stardust ([213.195.114.245]) by smtp.gmail.com with ESMTPSA id h199sm3888351wme.42.2020.07.10.07.22.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2020 07:22:30 -0700 (PDT) Subject: Re: [PATCH 2/4] mfd: mt6360: Remove handle_post_irq callback function To: Gene Chen , lee.jones@linaro.org References: <1594117856-14343-1-git-send-email-gene.chen.richtek@gmail.com> <1594117856-14343-3-git-send-email-gene.chen.richtek@gmail.com> From: Matthias Brugger Message-ID: <8fa489a0-7672-cbbd-ec04-32803ca69084@gmail.com> Date: Fri, 10 Jul 2020 16:22:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <1594117856-14343-3-git-send-email-gene.chen.richtek@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_102232_645558_83473A5D X-CRM114-Status: GOOD ( 21.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gene_chen@richtek.com, linux-kernel@vger.kernel.org, cy_huang@richtek.com, benjamin.chao@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/07/2020 12:30, Gene Chen wrote: > From: Gene Chen > > Remove handle_post_irq which is used to retrigger irq. > Set irq level low trigger to keep irq always be handled. > > Signed-off-by: Gene Chen > --- > drivers/mfd/mt6360-core.c | 25 ++++++++----------------- > include/linux/mfd/mt6360.h | 6 +++--- > 2 files changed, 11 insertions(+), 20 deletions(-) > > diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c > index 5dfc13e..2dd5918 100644 > --- a/drivers/mfd/mt6360-core.c > +++ b/drivers/mfd/mt6360-core.c > @@ -208,24 +208,16 @@ static const struct regmap_irq mt6360_irqs[] = { > REGMAP_IRQ_REG_LINE(MT6360_LDO7_PGB_EVT, 8), > }; > > -static int mt6360_pmu_handle_post_irq(void *irq_drv_data) > -{ > - struct mt6360_data *data = irq_drv_data; > - > - return regmap_update_bits(data->regmap, > - MT6360_PMU_IRQ_SET, MT6360_IRQ_RETRIG, MT6360_IRQ_RETRIG); > -} > - > -static struct regmap_irq_chip mt6360_irq_chip = { > +static const struct regmap_irq_chip mt6360_irq_chip = { > + .name = "mt6360_irqs", > .irqs = mt6360_irqs, > .num_irqs = ARRAY_SIZE(mt6360_irqs), > - .num_regs = MT6360_PMU_IRQ_REGNUM, > - .mask_base = MT6360_PMU_CHG_MASK1, > - .status_base = MT6360_PMU_CHG_IRQ1, > - .ack_base = MT6360_PMU_CHG_IRQ1, > + .num_regs = MT6360_IRQ_REGNUM, > + .mask_base = MT6360_REG_PMU_CHGMASK1, > + .status_base = MT6360_REG_PMU_CHGIRQ1, > + .ack_base = MT6360_REG_PMU_CHGIRQ1, Non relevant patches for the commit. Please drop this. > .init_ack_masked = true, > .use_ack = true, > - .handle_post_irq = mt6360_pmu_handle_post_irq, > }; > > static const struct regmap_config mt6360_pmu_regmap_config = { > @@ -339,10 +331,9 @@ static int mt6360_probe(struct i2c_client *client) > return -ENODEV; > } > > - mt6360_irq_chip.irq_drv_data = data; > ret = devm_regmap_add_irq_chip(&client->dev, data->regmap, client->irq, > - IRQF_TRIGGER_FALLING, 0, > - &mt6360_irq_chip, &data->irq_data); > + IRQF_ONESHOT, 0, &mt6360_irq_chip, From what I see IRQF_ONESHOT is set implicitly in regmap_add_irq_chip_fwnode. Actually I think what you want to add is IRQF_TRIGGER_LOW. > + &data->irq_data); > if (ret) { > dev_err(&client->dev, "Failed to add Regmap IRQ Chip\n"); > return ret; > diff --git a/include/linux/mfd/mt6360.h b/include/linux/mfd/mt6360.h > index 76077e4..9fc6718 100644 > --- a/include/linux/mfd/mt6360.h > +++ b/include/linux/mfd/mt6360.h > @@ -179,7 +179,7 @@ struct mt6360_data { > #define MT6360_PMU_SPARE2 (0xA0) > #define MT6360_PMU_SPARE3 (0xB0) > #define MT6360_PMU_SPARE4 (0xC0) > -#define MT6360_PMU_CHG_IRQ1 (0xD0) > +#define MT6360_REG_PMU_CHGIRQ1 (0xD0) > #define MT6360_PMU_CHG_IRQ2 (0xD1) > #define MT6360_PMU_CHG_IRQ3 (0xD2) > #define MT6360_PMU_CHG_IRQ4 (0xD3) > @@ -211,7 +211,7 @@ struct mt6360_data { > #define MT6360_PMU_BUCK2_STAT (0xED) > #define MT6360_PMU_LDO_STAT1 (0xEE) > #define MT6360_PMU_LDO_STAT2 (0xEF) > -#define MT6360_PMU_CHG_MASK1 (0xF0) > +#define MT6360_REG_PMU_CHGMASK1 (0xF0) > #define MT6360_PMU_CHG_MASK2 (0xF1) > #define MT6360_PMU_CHG_MASK3 (0xF2) > #define MT6360_PMU_CHG_MASK4 (0xF3) > @@ -230,7 +230,7 @@ struct mt6360_data { > #define MT6360_PMU_MAXREG (MT6360_PMU_LDO_MASK2) > > /* MT6360_PMU_IRQ_SET */ > -#define MT6360_PMU_IRQ_REGNUM (MT6360_PMU_LDO_IRQ2 - MT6360_PMU_CHG_IRQ1 + 1) Not relevant for the commit. But why did you use this strange computation in the first place? > +#define MT6360_IRQ_REGNUM 16 > #define MT6360_IRQ_RETRIG BIT(2) > > #define CHIP_VEN_MASK (0xF0) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel