From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: ChiaEn Wu <peterwu.pub@gmail.com>, Rob Herring <robh+dt@kernel.org>
Cc: krzysztof.kozlowski+dt@linaro.org, lee@kernel.org,
matthias.bgg@gmail.com, sre@kernel.org, chiaen_wu@richtek.com,
cy_huang@richtek.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: mfd: mt6370: fix the interrupt order of the charger in the example
Date: Wed, 5 Oct 2022 10:33:16 +0200 [thread overview]
Message-ID: <9004b427-66b7-f783-9258-4f6b893899ef@linaro.org> (raw)
In-Reply-To: <CABtFH5Ld91S65RiDu4iSpFhAMiFWaQdj-yDRM79=WUkArpA0JA@mail.gmail.com>
On 05/10/2022 10:14, ChiaEn Wu wrote:
> On Mon, Oct 3, 2022 at 11:34 PM Rob Herring <robh+dt@kernel.org> wrote:
>> This doesn't fix all the warnings. These still remain:
>>
>> /home/rob/proj/linux-dt/.build-arm64/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:
>> pmic@34: indicator: 'color' is a required property
>> From schema:
>> /home/rob/proj/linux-dt/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml
>> /home/rob/proj/linux-dt/.build-arm64/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:
>> indicator: $nodename:0: 'indicator' does not match
>> '^multi-led(@[0-9a-f])?$'
>> From schema:
>> /home/rob/proj/linux-dt/Documentation/devicetree/bindings/leds/mediatek,mt6370-indicator.yaml
>
> Hi Rob,
>
> In my opinion, the root cause of these warnings is the incorrect usage
> of 'allOf' in our LED indicator dts as follows,
> (https://lore.kernel.org/all/27df85c30277a171ae85ff6d5b7d867625765d0a.1663926551.git.chiaen_wu@richtek.com/)
Eh, my patch was merged in July... and yours from September still does
not use updated multi-led bindings. Was it even tested before sending?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-05 8:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 9:04 [PATCH v2] dt-bindings: mfd: mt6370: fix the interrupt order of the charger in the example ChiaEn Wu
2022-10-03 14:46 ` AngeloGioacchino Del Regno
2022-10-03 15:34 ` Rob Herring
2022-10-05 8:14 ` ChiaEn Wu
2022-10-05 8:33 ` Krzysztof Kozlowski [this message]
2022-10-05 8:59 ` ChiaEn Wu
2022-10-05 16:35 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9004b427-66b7-f783-9258-4f6b893899ef@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chiaen_wu@richtek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=peterwu.pub@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).