From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7769C433FF for ; Mon, 5 Aug 2019 07:19:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF0DF205F4 for ; Mon, 5 Aug 2019 07:19:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H9wr/kiJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=toradex.com header.i=@toradex.com header.b="VUwdd8B5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF0DF205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=toradex.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LEWrYZZPo97i5IzQoqps5ZSOwT1BKwqE6/k+e6BDp1k=; b=H9wr/kiJ4aIde0 6kW1vDen/u50fZnxerrBa6OL/0Jz39tREGJlVB0UNnaSU2H+NMnri0hebtUwFG8p5Hskz/kvR81Bk FEgRuh0IkgcPO7U5AmxVduZBOd7gKhPHsxAjhkC8Ss+tVQvbUkyt30I3AdudsLsEXneER0/zU6hrB WR77MbVJmc1jXcpLrskpnrmmBMMWGbUa4loXYdav7rj2lm0Ea6Ouwlx+KmA/a8t6iW/koP5B4NXr5 EFELA2CSK/ooruKzeeZkgNcsLllzaJ6cal301MonDdlEvtz1eawDwYVBeNZNpV5cRVHpB92xKhBeq szG1bG5GxPRXMEuQMD8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huXH1-0004kd-Bc; Mon, 05 Aug 2019 07:19:15 +0000 Received: from mail-eopbgr80124.outbound.protection.outlook.com ([40.107.8.124] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huXGx-0004jg-Uo for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2019 07:19:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YMRyjgJy1vzyAta/K/XbUmcdj0cc/o4+uz2GCknr4fmz1UVykpltSmlSjqzWn/wSlEptdSzPnK1aT6eNX+4aKaLGwBB0gWdKcCZz6zCWDxRvCsEn6nZ9aqcB8CccZ1MElPiBnZHVsLuqF0i3zJ6ys8gppSaYnPhWDhBfcISZNMBeIE+RW1nI7UmlaNLaFwTpI7evNPiICUZ/yZ3zLgBE2B+lgKERPOhn6RBTHQT2fhdOXAPQ1PSRc2uiZ8uvQULThObhy3pO0f7d7gI8yaB/I7Ij7yvGQVTCAA0Wr2ri9hd97DTSF+CIDea+LbymwtghC+XD9NxTsXHIM+XV1hrSZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ifzT0Rd2fgYCxbAlomcJsAOHjMab4VeLkWhU/H7j6xc=; b=aBFMzwscwR8jL+jAXmdZtFORTW279dhSZV/PUxZG6eFOJFmPWg/xaFpdKf2XhytuuM59ZMK5zLFQRDAoF2dXQDkAk64VPUyhzm9TITuygBlEO3AVYtdhN+Zi9Vnkto2Fc/o8qtoGKxKlOC1tkhE0nRPhy7yvCATmZa9M5Oi1kXw8B4G6stOHEv5gdVMy58C/L53hN/Ykma+GRK1Q3/lFsYyDFrQ0+7GFNq48+1ETDiMWKAKoFULhcsmXndvP7I1J7pVCFsNQce8igXi86RFgc55FP+2EwW/z7SWmHbL5Ej6iEs6E25mMhMbcdzWZjnjWJMPLKonCOZGXl7y66uSZyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=toradex.com;dmarc=pass action=none header.from=toradex.com;dkim=pass header.d=toradex.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toradex.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ifzT0Rd2fgYCxbAlomcJsAOHjMab4VeLkWhU/H7j6xc=; b=VUwdd8B58qO2wTjlnSekBeTWz6CZDiUL4xSLPWOU8HaDD4hqe+pq9lafnC9DNgwi9ODxYSJ3iJJcnzRLC+ziiIjOoHpTVy3PRhJRX47CfZVCBgB8imOykfVwJr3kdpI1I2488b+uAQnuSnSnVg5OniT1XYBvhr/+kdAFokr3iQ8= Received: from VI1PR0502MB3965.eurprd05.prod.outlook.com (52.134.17.157) by VI1PR0502MB3053.eurprd05.prod.outlook.com (10.175.22.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.16; Mon, 5 Aug 2019 07:18:59 +0000 Received: from VI1PR0502MB3965.eurprd05.prod.outlook.com ([fe80::8405:5b51:b25d:39a2]) by VI1PR0502MB3965.eurprd05.prod.outlook.com ([fe80::8405:5b51:b25d:39a2%6]) with mapi id 15.20.2136.018; Mon, 5 Aug 2019 07:18:59 +0000 From: Philippe Schenker To: "stefan@agner.ch" Subject: Re: [PATCH v2 07/20] ARM: dts: imx7-colibri: fix 1.8V/UHS support Thread-Topic: [PATCH v2 07/20] ARM: dts: imx7-colibri: fix 1.8V/UHS support Thread-Index: AQHVR5zQtB0dzN8FYEudcspMVKQYmabkr2aAgAAgjgCAAr/AgIAEnSoA Date: Mon, 5 Aug 2019 07:18:59 +0000 Message-ID: <90509acd1da1aa85699952e012fa1034255f1a06.camel@toradex.com> References: <20190731123750.25670-1-philippe.schenker@toradex.com> <20190731123750.25670-8-philippe.schenker@toradex.com> <723f191c5893984c8fbe711163524dc7ebf09a5b.camel@toradex.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=philippe.schenker@toradex.com; x-originating-ip: [46.140.72.82] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bc248fa8-9b65-4054-774b-08d719752f85 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:VI1PR0502MB3053; x-ms-traffictypediagnostic: VI1PR0502MB3053: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 01208B1E18 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(396003)(366004)(376002)(136003)(39840400004)(346002)(199004)(189003)(3846002)(2906002)(229853002)(7416002)(6116002)(6436002)(54906003)(6486002)(8676002)(1730700003)(81156014)(86362001)(81166006)(99286004)(5640700003)(76176011)(186003)(486006)(102836004)(71200400001)(71190400001)(2501003)(2616005)(476003)(14444005)(316002)(8936002)(6506007)(53546011)(26005)(2351001)(44832011)(256004)(118296001)(478600001)(66476007)(64756008)(76116006)(91956017)(66946007)(446003)(11346002)(66066001)(6512007)(14454004)(6916009)(5660300002)(66446008)(66556008)(6246003)(36756003)(68736007)(7736002)(25786009)(53936002)(305945005)(4326008); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR0502MB3053; H:VI1PR0502MB3965.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: toradex.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: tUGv+UQDWwYdzHzTF//jSapVHDWo9eEJ02EtG/us1cT5mvfr7f+5NfWovgZBYm17euZ3e3ev8sJRa3YPBn2UQBtornIBVvgObyB3oT0sgcvKapLxbxA1IKcTAAd/Jy5reoblnNjanAMJdFMPZgn3j0tJ8i7KhT94Cc9cULg1PmCKmJWFYbDr8SrU/itUMblstTbMq445S56oKiBJ6YCaELzAgvkUXRoe8xcdABiPZloeWUHbZDqAf4XNYiKXUw+3FWiJxvGWnJ4l4T/ZDxq2ClRAygiZO+jwvYdEVPAQPfLu419ap1Awg1vumkcshgxUiP6X8LR5rBHjOpSpAPdWOj5xQTEKLU6YpM4pXG5Qh9MeL2lJtYhSXdtJbJt7GUY3oLu3yueTxr4ecw83zUwfyvEDSInxYXjQ0e0aDirj9cE= Content-ID: <1D6770331469E54389A2882CE1F4A824@eurprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc248fa8-9b65-4054-774b-08d719752f85 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2019 07:18:59.1720 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: philippe.schenker@toradex.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3053 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_001911_999888_20D6DA79 X-CRM114-Status: GOOD ( 25.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "michal.vokac@ysoft.com" , Max Krummenacher , Stefan Agner , Marcel Ziswiler , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-imx@nxp.com" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2019-08-02 at 10:51 +0200, Stefan Agner wrote: > On 2019-07-31 16:52, Philippe Schenker wrote: > > On Wed, 2019-07-31 at 09:56 -0300, Fabio Estevam wrote: > > > On Wed, Jul 31, 2019 at 9:38 AM Philippe Schenker > > > wrote: > > > > From: Stefan Agner > > > > > > > > Add pinmuxing and do not specify voltage restrictions in the > > > > module level device tree. > > > > > > It would be nice to explain the reason for doing this. > > > > This commit is in preparation of another patch that didn't made into this > > patchset (downstream stuff in there). But I will do another patch on top > > that > > will use this patch here. That should anyway be in mainline. > > I guess what Fabio meant here is explain this patch. > > The commit message really could be improved, e.g.: > > Add pinmuxing and do not specify voltage restrictions for the usdhc > instance > available on the modules edge connector. This allows to use SD-cards > with > higher transfer modes if supported by the carrier board. > > -- > Stefan Ah, sorry Fabio. I indeed understood you wrong and thanks Stefan for clarifying. I have the new message in for v3. Philippe > > > Philippe > > > > > > Signed-off-by: Stefan Agner > > > > Signed-off-by: Philippe Schenker > > > > --- > > > > > > > > Changes in v2: None > > > > > > > > arch/arm/boot/dts/imx7-colibri.dtsi | 23 ++++++++++++++++++++++- > > > > 1 file changed, 22 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi > > > > b/arch/arm/boot/dts/imx7- > > > > colibri.dtsi > > > > index 16d1a1ed1aff..67f5e0c87fdc 100644 > > > > --- a/arch/arm/boot/dts/imx7-colibri.dtsi > > > > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi > > > > @@ -326,7 +326,6 @@ > > > > &usdhc1 { > > > > pinctrl-names = "default"; > > > > pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_cd_usdhc1>; > > > > - no-1-8-v; > > > > cd-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; > > > > disable-wp; > > > > vqmmc-supply = <®_LDO2>; > > > > @@ -671,6 +670,28 @@ > > > > >; > > > > }; > > > > > > > > + pinctrl_usdhc1_100mhz: usdhc1grp_100mhz { > > > > + fsl,pins = < > > > > + MX7D_PAD_SD1_CMD__SD1_CMD 0x5a > > > > + MX7D_PAD_SD1_CLK__SD1_CLK 0x1a > > > > + MX7D_PAD_SD1_DATA0__SD1_DATA0 0x5a > > > > + MX7D_PAD_SD1_DATA1__SD1_DATA1 0x5a > > > > + MX7D_PAD_SD1_DATA2__SD1_DATA2 0x5a > > > > + MX7D_PAD_SD1_DATA3__SD1_DATA3 0x5a > > > > + >; > > > > + }; > > > > + > > > > + pinctrl_usdhc1_200mhz: usdhc1grp_200mhz { > > > > + fsl,pins = < > > > > + MX7D_PAD_SD1_CMD__SD1_CMD 0x5b > > > > + MX7D_PAD_SD1_CLK__SD1_CLK 0x1b > > > > + MX7D_PAD_SD1_DATA0__SD1_DATA0 0x5b > > > > + MX7D_PAD_SD1_DATA1__SD1_DATA1 0x5b > > > > + MX7D_PAD_SD1_DATA2__SD1_DATA2 0x5b > > > > + MX7D_PAD_SD1_DATA3__SD1_DATA3 0x5b > > > > + >; > > > > + }; > > > > > > You add the entries for 100MHz and 200MHz, but I don't see them being > > > referenced anywhere. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel