From: Sricharan Ramabadhran <quic_srichara@quicinc.com>
To: Mukesh Ojha <quic_mojha@quicinc.com>,
POOVENDHAN SELVARAJ <quic_poovendh@quicinc.com>,
<agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <lee@kernel.org>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<shawnguo@kernel.org>, <arnd@arndb.de>,
<marcel.ziswiler@toradex.com>, <robimarko@gmail.com>,
<dmitry.baryshkov@linaro.org>, <nfraprado@collabora.com>,
<broonie@kernel.org>, <quic_gurus@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: <quic_gokulsri@quicinc.com>, <quic_sjaganat@quicinc.com>,
<quic_kathirav@quicinc.com>, <quic_arajkuma@quicinc.com>,
<quic_anusha@quicinc.com>, <quic_devipriy@quicinc.com>
Subject: Re: [PATCH V5 5/5] firmware: scm: Modify only the DLOAD bit in TCSR register for download mode
Date: Wed, 22 Feb 2023 13:19:13 +0530 [thread overview]
Message-ID: <90919327-650f-210d-ecdf-9f35827fe72f@quicinc.com> (raw)
In-Reply-To: <cdb5b07f-6767-3162-532b-2c80178b8b92@quicinc.com>
<..>
>>>>>> };
>>>>>> - desc.args[1] = enable ? QCOM_SCM_BOOT_SET_DLOAD_MODE : 0;
>>>>>> + desc.args[1] = enable ? val | QCOM_SCM_BOOT_SET_DLOAD_MODE :
>>>>>> + val & ~(QCOM_SCM_BOOT_SET_DLOAD_MODE);
>>>>>> return qcom_scm_call_atomic(__scm->dev, &desc, NULL);
>>>>>> }
>>>>>> @@ -426,15 +427,25 @@ static void qcom_scm_set_download_mode(bool
>>>>>> enable)
>>>>>> {
>>>>>> bool avail;
>>>>>> int ret = 0;
>>>>>> + u32 dload_addr_val;
>>>>>> avail = __qcom_scm_is_call_available(__scm->dev,
>>>>>> QCOM_SCM_SVC_BOOT,
>>>>>> QCOM_SCM_BOOT_SET_DLOAD_MODE);
>>>>>> + ret = qcom_scm_io_readl(__scm->dload_mode_addr,
>>>>>> &dload_addr_val);
>>>>>> +
>>>>>> + if (ret) {
>>>>>> + dev_err(__scm->dev,
>>>>>> + "failed to read dload mode address value: %d\n", ret);
>>>>>> + return;
>>>>>> + }
>>>>>> +
>>>>>> if (avail) {
>>>>>> - ret = __qcom_scm_set_dload_mode(__scm->dev, enable);
>>>>>> + ret = __qcom_scm_set_dload_mode(__scm->dev,
>>>>>> dload_addr_val, enable);
>>>>>
>>>>> Did you test this on a target where it comes under this if
>>>>> statement? does it really need to know dload_mode_addr for this
>>>>> target ?
>>>>
>>>>
>>>> Can we do something like this? I would let other review as well.
>>>>
>>>> --------------------------------------->0-------------------------------------------
>>>>
>>>> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
>>>> index cdbfe54..26b7eda 100644
>>>> --- a/drivers/firmware/qcom_scm.c
>>>> +++ b/drivers/firmware/qcom_scm.c
>>>> @@ -419,6 +419,7 @@ static void qcom_scm_set_download_mode(bool enable)
>>>> {
>>>> bool avail;
>>>> int ret = 0;
>>>> + u32 dload_addr_val;
>>>>
>>>> avail = __qcom_scm_is_call_available(__scm->dev,
>>>> QCOM_SCM_SVC_BOOT,
>>>> @@ -426,8 +427,16 @@ static void qcom_scm_set_download_mode(bool
>>>> enable)
>>>> if (avail) {
>>>> ret = __qcom_scm_set_dload_mode(__scm->dev, enable);
>>>> } else if (__scm->dload_mode_addr) {
>>>> - ret = qcom_scm_io_writel(__scm->dload_mode_addr,
>>>> - enable ?
>>>> QCOM_SCM_BOOT_SET_DLOAD_MODE : 0);
>>>> + ret = qcom_scm_io_readl(__scm->dload_mode_addr,
>>>> &dload_addr_val);
>>>> + if (ret) {
>>>> + dev_err(__scm->dev,
>>>> + "failed to read dload mode address
>>>> value: %d\n", ret);
>>>> + return;
>>>> + }
>>>> +
>>>> + ret = qcom_scm_io_writel(__scm->dload_mode_addr,
>>>> enable ?
>>>> + dload_addr_val |
>>>> QCOM_SCM_BOOT_SET_DLOAD_MODE :
>>>> + dload_addr_val &
>>>> ~(QCOM_SCM_BOOT_SET_DLOAD_MODE));
>>>> } else {
>>>> dev_err(__scm->dev,
>>>> "No available mechanism for setting download
>>>> mode\n");
>>>>
>>>> -Mukesh
>>>
>>> Okay sure..Agreed, will address this in the next patch.
>>
>> Also, not sure, if its better to keep the old behavior working for
>> targets that does not support 'READ' of this address. If one such
>> thing exists, that will be broken now. In such a case, we should
>> ignore if scm_io_readl fails, still write and dload_addr_val should
>> be '0' initialised.
>
> Why would a secure read of this register would fail, if one is allowed
> to do secure write ?
>
> Honestly, i was not understanding the purpose of this bitwise handling
> of this patch, i thought it is trying to fix existing issue for
> some target.
>
> For some of the upstream target(e.g sm8450, i verified it myself), it is
> not an issue.
>
> arch/arm64/boot/dts/qcom/msm8916.dtsi: qcom,dload-mode
> = <&tcsr 0x6100>;
> arch/arm64/boot/dts/qcom/msm8976.dtsi: qcom,dload-mode
> = <&tcsr 0x6100>;
> arch/arm64/boot/dts/qcom/msm8996.dtsi: qcom,dload-mode
> = <&tcsr_2 0x13000>;
> arch/arm64/boot/dts/qcom/sm8450.dtsi: qcom,dload-mode
> = <&tcsr 0x13000>;
>
>
> However, it looks valid to handle only the effective bits. I have worked
> on top of this patch and tested it and posted here.
>
> https://lore.kernel.org/lkml/1676990381-18184-1-git-send-email-quic_mojha@quicinc.com/
>
>
> Do you have any example of any upstream target where this would fail ?
Actually not sure. I was saying just based on the fact that,
previously it was 'unconditional write' on all targets, now its a
'conditional write'. If 'read' would never fail from secure,
then your patch looks fine.
Regards,
Sricharan
y
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-22 7:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 12:00 [PATCH V5 0/5] Enable crashdump collection support for IPQ9574 Poovendhan Selvaraj
2023-02-16 12:00 ` [PATCH V5 1/5] dt-bindings: scm: Add compatible " Poovendhan Selvaraj
2023-02-16 12:00 ` [PATCH V5 2/5] dt-bindings: mfd: Add the tcsr " Poovendhan Selvaraj
2023-02-16 12:00 ` [PATCH V5 3/5] arm64: dts: qcom: ipq9574: Enable the download mode support Poovendhan Selvaraj
2023-02-16 12:00 ` [PATCH V5 4/5] arm64: dts: qcom: ipq9574: Add SMEM support Poovendhan Selvaraj
2023-02-16 12:00 ` [PATCH V5 5/5] firmware: scm: Modify only the DLOAD bit in TCSR register for download mode Poovendhan Selvaraj
2023-02-16 14:00 ` Mukesh Ojha
2023-02-17 19:49 ` Mukesh Ojha
2023-02-20 10:30 ` POOVENDHAN SELVARAJ
2023-02-22 6:52 ` Sricharan Ramabadhran
2023-02-22 7:22 ` Mukesh Ojha
2023-02-22 7:49 ` Sricharan Ramabadhran [this message]
2023-03-15 23:35 ` (subset) [PATCH V5 0/5] Enable crashdump collection support for IPQ9574 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90919327-650f-210d-ecdf-9f35827fe72f@quicinc.com \
--to=quic_srichara@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=nfraprado@collabora.com \
--cc=quic_anusha@quicinc.com \
--cc=quic_arajkuma@quicinc.com \
--cc=quic_devipriy@quicinc.com \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_gurus@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_mojha@quicinc.com \
--cc=quic_poovendh@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).