From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D17ADC433EF for ; Wed, 20 Oct 2021 02:29:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C5806115A for ; Wed, 20 Oct 2021 02:29:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8C5806115A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rShMvGCpinfTEYhzTP7Jm4xnbVhdZaqSzu9TiV/m33U=; b=gA6mdWcqlyhpek stsHQWh9jMQ3Bqt9LwIpRynCUI5M2NIfILNBTpp1DrQ0OwDklSAQqcf+OvEzk1lygw1qorFF/0U5p nIOCrt2MgsyDZmV2d1S39rLjM9ax7yUP0SY1JFJc47eBr2hLJQD7B5pmlYiKmVdDvj6XrGtj9QHue 8dEi9/BSXQ1gD/EIVMFCYZ4aUQf2RaPK0t9OTZbdmWAouj3ruZ7c+7YWtjZhmeANV2A7cI0DjnIy/ pzGuKgDYSgBw3Nsgna0FzSQtmfRHswgS+CprVTdauUOlbqwhYMGfZ0ly9cVxI8v0ldV8JmEHIYGv7 GCyikjJR71Auv38SiSlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1md1Ky-003GBH-DN; Wed, 20 Oct 2021 02:28:16 +0000 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1md1Ku-003G9r-20 for linux-arm-kernel@lists.infradead.org; Wed, 20 Oct 2021 02:28:14 +0000 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R201e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04400; MF=xuesong.chen@linux.alibaba.com; NM=1; PH=DS; RN=14; SR=0; TI=SMTPD_---0Ut-jNXD_1634696886; Received: from 30.225.212.40(mailfrom:xuesong.chen@linux.alibaba.com fp:SMTPD_---0Ut-jNXD_1634696886) by smtp.aliyun-inc.com(127.0.0.1); Wed, 20 Oct 2021 10:28:07 +0800 Message-ID: <90a632cc-352f-1067-718a-a6b515bf87d7@linux.alibaba.com> Date: Wed, 20 Oct 2021 10:28:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v3 0/2] PCI MCFG consolidation and APEI resource filterin To: Bjorn Helgaas Cc: catalin.marinas@arm.com, lorenzo.pieralisi@arm.com, james.morse@arm.com, will@kernel.org, rafael@kernel.org, tony.luck@intel.com, bp@alien8.de, mingo@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211019151258.GA2336650@bhelgaas> From: Xuesong Chen In-Reply-To: <20211019151258.GA2336650@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_192812_325643_F9F2BB99 X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/10/2021 23:12, Bjorn Helgaas wrote: > On Tue, Oct 19, 2021 at 12:49:16PM +0800, Xuesong Chen wrote: >> Hello All, >> >> The idea of this patch set is very strainforward, it's somehow a refactor >> of the original codes to share some ones that they should do. Based on that, >> we can resolve the MCFG address access issue in APEI module on x86 in a >> command way instead of the current arch-dependent one, while this issue also >> does happen on ARM64 platform. >> >> The logic of the series is very clear(IMO it's even time-wasting to explain that): > > If you want people to look at and care about your changes, it is never > a waste of time to explain them. En, very good point and professional, I'll keep in mind ;-) > >> Patch #1: Escalating the 'pci_mmcfg_list' and 'pci_mmcfg_region' to the >> pci.[c,h] which will shared by all the arches. A common sense, in some degree. >> >> Patch #2: Since the 'pci_mmcfg_list' now can be shared across all arches, >> the arch-specific fix method can be replaced by the new solution naturally. >> >> Now the v3 patch has been finalized, can we move forward to the next step? - >> either give the concerns/objections or pick it up. > > It's helpful to your reviewers if you include a note about changes > between v2 and v3, as you did in your v2 0/2 cover letter. > > It's also helpful if you thread the series with patches 1 and 2 as > responses to the cover letter. That makes it easy to download the > patches using b4. Here's a little more background: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/5.Posting.rst?id=v5.14#n320 OK, I will rewrite it in the next version... > >> Xuesong Chen (2): >> PCI: MCFG: Consolidate the separate PCI MCFG table entry list >> ACPI: APEI: Filter the PCI MCFG address with an arch-agnostic method >> >> arch/x86/include/asm/pci_x86.h | 17 +--------------- >> arch/x86/pci/mmconfig-shared.c | 30 ---------------------------- >> drivers/acpi/apei/apei-base.c | 45 ++++++++++++++++++++++++++++-------------- >> drivers/acpi/pci_mcfg.c | 34 ++++++++++++------------------- >> drivers/pci/pci.c | 2 ++ >> include/linux/pci.h | 17 ++++++++++++++++ >> 6 files changed, 63 insertions(+), 82 deletions(-) >> >> -- >> 1.8.3.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel