From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A8FC48BDF for ; Sun, 13 Jun 2021 20:13:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E1EC6124B for ; Sun, 13 Jun 2021 20:13:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E1EC6124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZM1G1MeGlTyaa6ageIWs4hi+k03GNiNVsDHxDjJSm7c=; b=1D8cr/lh5eByUM U4IUwsomtRyTb336ySQ5OSYPNOFdaGWx05b9woEpuDe1ykfVTiIyCZw39GK8VdYPNX6vbcZTwFJkm zVfbzM/WhzkcN9Os7ZozqBlb/GOjtWNYFjakOO81WIAA9/W1gf1LrUgR1+wNgY5z+qSNiUl+R9yHF 6XSFgubFS7YWOAEanc2dIsJ6x1Z087rZYoTs2NbNVY2Zn+Yef8pnNJ7KQBmW+ERzW/YnS1oXwx+Jt 1OKzhKKg90+jKR7oi2NVn8ZXM4+OfYU1nzFYvxi1LdeGDsAzqvgi7bBitfBMj4nXXsIrE32Vw7gaf cl0LmLSw6UiOa8coomjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsWSp-00B8Yn-2u; Sun, 13 Jun 2021 20:12:11 +0000 Received: from mail-wm1-f51.google.com ([209.85.128.51]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsWSl-00B8XT-Ni for linux-arm-kernel@lists.infradead.org; Sun, 13 Jun 2021 20:12:09 +0000 Received: by mail-wm1-f51.google.com with SMTP id k5-20020a05600c1c85b02901affeec3ef8so11649512wms.0 for ; Sun, 13 Jun 2021 13:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=RoW78HdbRz9bg85++1AVT5jNn/ssWS7W6V6tF3IYT4M=; b=CQDTQHwrw1kO4HaXl6z4wW9fLI4vgVO1zT9hVfdbAj0st7B8rO8Fi0mwFL3Xia8aOp VBhfm84jICSgIoqg555Cqf1Q8D3swjtYNn2vOs6FpMUSrVsxX5FTG0S8HVE15ZNG3qUu wM6Vmc1iVXQA3mDVRHgmQS6bJpNRb91zp10MI9mWTuHYJ/Euk5MOATk7EgWnh3pjYjTN OoubzszeaBemNTw6n1yJ2hadHd5K8Ul8weLoaU2urfBw2EEPuyPo4iignZ9AS1VsVO4M jmkNzJOVbkHgoO6Nv9E+7zexp8lbqeF/tFtEEfZcHu2nk+cAN4CPhsk6v+gElykQ3qHO TnoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=RoW78HdbRz9bg85++1AVT5jNn/ssWS7W6V6tF3IYT4M=; b=OPBFwZ6FieMAVX/sT6RkF3TwPJolw7j/Dukwy2mYZpY/goZopDMT+yzhs3CB2xlcF8 ySNmgGf+SOw4Rz595gHZ59PCxtIV397ZhPK1LTUGfskDGX5ogW5QQnJla6hX5brn5BEf fpa+t93bz+M+iCz7dezdIJ4EcSGdBBrhWP4hBIvpqMOgQCEd1GEnVwucJrsAJsrE171m OIoH2lTrjMd3rctjFwYSN1AE13l19Do00nh3astPiwTsG5jcd1JxTZ29XZf3Yy2Cb/ex vNR5BPsLEl5iiy4kr2LFo/0Th3U00kstKsIh+oBOkZQ+3BxfmBMnUKtHDEUVMdX4KC4o wiVw== X-Gm-Message-State: AOAM533W3Z/7BcKM/QhfcX0xBkCPyqsQp/WPgzV0gK8JNRRFCY4YH0E1 HBx1nsOu/Nf6aYTwwVYKSTE= X-Google-Smtp-Source: ABdhPJz71OlHNFPhwgKHbPoX01x1Y1ohYDTr7spSQtdUwbj2P3ySZrDgZauLApnkwFpco+503IpoSQ== X-Received: by 2002:a05:600c:c9:: with SMTP id u9mr12751722wmm.156.1623615064411; Sun, 13 Jun 2021 13:11:04 -0700 (PDT) Received: from [192.168.1.21] ([195.245.23.224]) by smtp.gmail.com with ESMTPSA id 89sm14779412wrq.14.2021.06.13.13.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Jun 2021 13:11:03 -0700 (PDT) Message-ID: <90c958bacfb77080ee524c55f5e1a01696b27017.camel@gmail.com> Subject: Re: [PATCH 1/1] ep93xx: clock: convert in-place to COMMON_CLK From: Alexander Sverdlin To: Geert Uytterhoeven Cc: Nikita Shubin , Russell King , Hartley Sweeten , Arnd Bergmann , Linus Walleij , Ard Biesheuvel , Mike Rapoport , Gregory Fong , Geert Uytterhoeven , YiFei Zhu , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Linux ARM , Linux Kernel Mailing List Date: Sun, 13 Jun 2021 22:11:02 +0200 In-Reply-To: References: <20210525083340.27722-1-nikita.shubin@maquefel.me> <20210525083340.27722-2-nikita.shubin@maquefel.me> <8cdf2b130ae02ba00324d0a70cbbcd3ba53e1d09.camel@gmail.com> User-Agent: Evolution 3.40.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210613_131207_849773_872930FC X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Geert! On Sat, 2021-06-12 at 11:18 +0200, Geert Uytterhoeven wrote: > > WARNING: CPU: 0 PID: 36 at drivers/clk/clk.c:952 clk_core_disable+0xbc/0xd8 > > ep93xx-spi.0 already disabled > > [] (ep93xx_spi_unprepare_hardware) from [] (__spi_pump_messages+0x388/0x620) > > These are issues in individual drivers, not in the CCF implementation. > All drivers using the clock API should be converted from > clk_{en,dis}able() to clk_{prepare_enable,disable_unprepare}() first. You are right! I'm currently testing a series, which will convert the calls. -- Alexander Sverdlin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel