From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4BFC4338F for ; Tue, 3 Aug 2021 12:57:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5670060F38 for ; Tue, 3 Aug 2021 12:57:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5670060F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=HCkYnJUNDQDhqFVRvF6dPubJM4V72EPPgc6YQ3CzXTM=; b=LbQsXc/tXkwHlwvRP4gGo01+Ge ++XRZEx/eXAH+7IsowW4mGH6TfhGhWcsay9tWo8cmrqC0xctpdPxcbHX7dEutPWEi7ZEseCOodmqb GzcDcT2dFmmC1QkiFAfRBJoNDA+W+mWXmPm8YjuzIY00+HT0dNp0aQpGNO82twlVPZ+meBsaKLqVL BzhidFdqjy6Utby228jo0j92QnR8SpsYhjHi5gXXXMddVsSrmEQmEcNwW8QlvUbmSed4BBw5/sL5l axWE6MexsRu65laSpKCUoPM+M+2CrwkgHpXAUBS6i2hmD3Dmw9cLE1zHqcds68+2BQYTG8JpkCZkn JDUs1BJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAtwd-002mLJ-Ru; Tue, 03 Aug 2021 12:54:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAtd2-002fOH-TF for linux-arm-kernel@lists.infradead.org; Tue, 03 Aug 2021 12:34:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C8C6D11FB; Tue, 3 Aug 2021 05:34:39 -0700 (PDT) Received: from [10.57.36.239] (unknown [10.57.36.239]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 878B43F40C; Tue, 3 Aug 2021 05:34:37 -0700 (PDT) Subject: Re: [PATCH 3/6] perf cs-etm: Save TRCDEVARCH register To: Leo Yan , Mike Leach Cc: Arnaldo Carvalho de Melo , Mathieu Poirier , Coresight ML , Al Grant , "Suzuki K. Poulose" , Anshuman Khandual , John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel , Linux Kernel Mailing List , linux-perf-users@vger.kernel.org References: <20210721090706.21523-1-james.clark@arm.com> <20210721090706.21523-4-james.clark@arm.com> <20210731063731.GC7437@leoy-ThinkPad-X240s> From: James Clark Message-ID: <9156d7a1-3676-ab98-2c38-26f9765b845c@arm.com> Date: Tue, 3 Aug 2021 13:34:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210731063731.GC7437@leoy-ThinkPad-X240s> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210803_053441_057019_18D53AB2 X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/07/2021 07:37, Leo Yan wrote: >>> diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c >>> index 85168d87b2d7..65a863bdf5cc 100644 >>> --- a/tools/perf/arch/arm/util/cs-etm.c >>> +++ b/tools/perf/arch/arm/util/cs-etm.c >>> @@ -53,6 +53,7 @@ static const char *metadata_etmv4_ro[CS_ETMV4_PRIV_MAX] = { >>> [CS_ETMV4_TRCIDR2] = "trcidr/trcidr2", >>> [CS_ETMV4_TRCIDR8] = "trcidr/trcidr8", >>> [CS_ETMV4_TRCAUTHSTATUS] = "mgmt/trcauthstatus", >>> + [CS_ETE_TRCDEVARCH] = "mgmt/trcdevarch" > ETMv4 supports TRCDEVARCH, so I think it's good to use the naming > "CS_ETMV4_TRCDEVARCH"? > Based on the other discussions do you still think I should do this? As part of the new magic number I moved it into a new enum so it might be clearer now? James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel