From: Matthias Brugger <matthias.bgg@gmail.com>
To: "Jitao Shi" <jitao.shi@mediatek.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
srv_heupstream@mediatek.com, yingjoe.chen@mediatek.com,
eddie.huang@mediatek.com, ck.hu@mediatek.com, stonea168@163.com,
huijuan.xie@mediatek.com, shuijing.li@mediatek.com
Subject: Re: [PATCH v6 2/5] pwm: mtk_disp: fix force reg to working reg.
Date: Wed, 4 Aug 2021 19:12:42 +0200 [thread overview]
Message-ID: <925e1dcb-1f6b-1762-8342-b102d5e928e8@gmail.com> (raw)
In-Reply-To: <20210724081849.182108-3-jitao.shi@mediatek.com>
On 24/07/2021 10:18, Jitao Shi wrote:
> Disable reg double buffer before writing register.
The commit message does not explain why you move this from probe to pwm_config.
Can you please explain exactly why you need to do that.
Regards,
Matthias
>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---
> drivers/pwm/pwm-mtk-disp.c | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c
> index 3ade525adcc3..1070d78d4940 100644
> --- a/drivers/pwm/pwm-mtk-disp.c
> +++ b/drivers/pwm/pwm-mtk-disp.c
> @@ -128,6 +128,17 @@ static int mtk_disp_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
> mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
> mdp->data->commit_mask,
> 0x0);
> + } else {
> + /*
> + * For MT2701, disable double buffer before writing register
> + * and select manual mode and use PWM_PERIOD/PWM_HIGH_WIDTH.
> + */
> + mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
> + mdp->data->bls_debug_mask,
> + mdp->data->bls_debug_mask);
> + mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
> + mdp->data->con0_sel,
> + mdp->data->con0_sel);
> }
>
> clk_disable_unprepare(mdp->clk_mm);
> @@ -213,19 +224,6 @@ static int mtk_disp_pwm_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, mdp);
>
> - /*
> - * For MT2701, disable double buffer before writing register
> - * and select manual mode and use PWM_PERIOD/PWM_HIGH_WIDTH.
> - */
> - if (!mdp->data->has_commit) {
> - mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
> - mdp->data->bls_debug_mask,
> - mdp->data->bls_debug_mask);
> - mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
> - mdp->data->con0_sel,
> - mdp->data->con0_sel);
> - }
> -
> return 0;
> }
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-04 17:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 8:18 [PATCH v6 0/5] fix the clks on/off mismatch issue and switch pwm-mtk-disp to atomic APIs Jitao Shi
2021-07-24 8:18 ` [PATCH v6 1/5] pwm: mtk-disp: adjust the clocks to avoid them mismatch Jitao Shi
2021-07-24 8:18 ` [PATCH v6 2/5] pwm: mtk_disp: fix force reg to working reg Jitao Shi
2021-08-04 17:12 ` Matthias Brugger [this message]
2021-07-24 8:18 ` [PATCH v6 3/5] pwm: mtk_disp: implement atomic API .apply() Jitao Shi
2021-07-24 8:18 ` [PATCH v6 4/5] pwm: mtk_disp: fix overflow in period and duty calcalation Jitao Shi
2021-07-24 8:18 ` [PATCH v6 5/5] pwm: mtk_disp: implement atomic API .get_state() Jitao Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=925e1dcb-1f6b-1762-8342-b102d5e928e8@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=ck.hu@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=huijuan.xie@mediatek.com \
--cc=jitao.shi@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=shuijing.li@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=stonea168@163.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).