From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 526E5C433ED for ; Wed, 28 Apr 2021 13:19:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97DE660E0B for ; Wed, 28 Apr 2021 13:19:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97DE660E0B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nI4fR9pIO1rTdg/ZIAB4j3BQOUoeZ1Y/bCiYzU4LLos=; b=jEmLQi3lITFxE99IGFbLwv5So a7qQ6pcQ53NPF804+SpCX2qKZJ7fxqdeK2Sc3PsTPYNeKo9jRFw+n+8hUjeeW7ejUoSCycbEyLV27 afowX9shzEW3E5rnH8QPMxWRxRR9x42tm9LynEIpIjpk3iIUOB4Guiq2RF8pUnccWMT32xRwQq7Rn DG9DaM7IhZAqkCPY7xIHD00r8a17KtkJ59pB5Xsf3NM1Dtu0AYd8sioZPgbHn45yQPwZ1y0iEkR2y HG3IhQMicWNFBGT6PE+ZWcob4dumOniVcU8+kTafKyfiBJ4HnjZxkf0WkbrKNkyu1IUt6pwW+tLTn 6GypBOXYg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbk4R-003WrJ-CW; Wed, 28 Apr 2021 13:17:39 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbk4N-003Wr3-S9 for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 13:17:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=NbDwdSsrJBHIcyAtoOd+xV5vofMTYrAK2lXe/IRVBnE=; b=Eux4hSivJFtDm139uA89GX9bzN bGOdD17NrqU5uS/OgFlomWxLDW0BB+g/b6DQIFzLUI6le3aNnpljYIkK1HiwHCLZHoU3bUEvswklM 4iu7XWuH6JTk0jMrl+lJXL+gKOJPLJpuvUgyfppDk/GMAIB2tehLCocduK32c2NljBB41ubX3nPAV Vke2za95dt4agnpjvnRDvIqFbwTq8HWV9cAkD3j8YIpvCv6UFXRy6df40VUzYiwFrW1giKCh25fpC mGwS4wPhg5A6njxOB0FSH5Z8jclZ6RQorqMW1AOvo5Nk1/kqzfxKSnnKxcb91q35yvx7fUYE7X664 YR2CKpfg==; Received: from mail-dm6nam11on2046.outbound.protection.outlook.com ([40.107.223.46] helo=NAM11-DM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbk4L-00HS47-1q for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 13:17:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cu7zzd7Fh8yQaBFIzANzwLv8UCUsO8Px+H1Y5zycdkEqoFcUOllIl3XyMVE9uKSBFk3yNqj6448AOAMyod9XwM5b19yAAzez0y7jyn62q4oa8NVLX5znUjZFCZXv+Me/lwVEwxBQzxSslMxneeL6RJNBiCwEQPpUzkHOT8Juw5S0bnsFezGcUjzLeUF0EAT6bZ+ZNMpZ8Rphh8zdj1leLbIIqsW3xbGBf46pGLtc394taOFGNFn2q4Y/6pMjnkwz/oszSqLBuSTnqYIfMg91j0iHyErqBdM2gVEChtCyIr0QZnI+AKGY/8bjWALBGkKzOtRSSwT++mbYKPWxmMjj3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NbDwdSsrJBHIcyAtoOd+xV5vofMTYrAK2lXe/IRVBnE=; b=M2OA2Fj/cg1MvW92x4MtpRsv4rrWm8Yvo92v5WPoV0X2SGivbdraD3opweG9wBqR3bVulN31V++ZkZ1amo3PtOStamrCT0ErHOk1/dns6M2w3GLZ4Y6E0m+7K8MVkE8Cydq8BPakWCkg/el0PAOPDHgmVSB4DMLoVmNrzEAdc9XTb2u9Rp1nmsWp9KPgP57KbYk6Tbk+2eO2JvxJNPEuIWA9MJi6Uqwl1pOKcAHIetKdldw/Grf5G1jzef+dPGWn5LBI0A5h5QD5qrCwj7UDYyFdKnrvPqAFcpg4Ojx4pUu3l3ZbFaOsj9/OyC50AruqaRQpK2MeWnBqDtW1OTT+ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NbDwdSsrJBHIcyAtoOd+xV5vofMTYrAK2lXe/IRVBnE=; b=J9SUzQNRTLKNqdoDe285Y5uf0CWsxXVTUmP7JGJrO/IJ7IIdA0jVND+bkXFvujleBNXCRmFz5EIogAt1OV6icdMQ16/KuXHs0Y+DyLXYzoLlrqSZrkGO3E9Ube6rSljr6MHzd0jDxOWBWj9NjO111Z4qsm08vjPkpHXkhwN0YmQ= Received: from DM5PR12CA0002.namprd12.prod.outlook.com (2603:10b6:4:1::12) by BY5PR02MB6081.namprd02.prod.outlook.com (2603:10b6:a03:1f7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.20; Wed, 28 Apr 2021 13:17:29 +0000 Received: from DM3NAM02FT018.eop-nam02.prod.protection.outlook.com (2603:10b6:4:1:cafe::28) by DM5PR12CA0002.outlook.office365.com (2603:10b6:4:1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.25 via Frontend Transport; Wed, 28 Apr 2021 13:17:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT018.mail.protection.outlook.com (10.13.4.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4065.21 via Frontend Transport; Wed, 28 Apr 2021 13:17:28 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 28 Apr 2021 06:17:27 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Wed, 28 Apr 2021 06:17:27 -0700 Received: from [172.30.17.109] (port=42610) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1lbk4F-0003Ig-GC; Wed, 28 Apr 2021 06:17:27 -0700 Subject: Re: [PATCH 0/4] soc: xilinx: pm_domains: cleanup and fix PM_INIT_FINALIZE To: Sudeep Holla , Michael Tretter CC: Rajan Vaja , "linux-arm-kernel@lists.infradead.org" References: <20210317160410.2097178-1-m.tretter@pengutronix.de> <20210419073239.GA12636@pengutronix.de> <20210420141847.blcjrrvekjt6llck@bogus> From: Michal Simek Message-ID: <93cdc435-448f-233b-5b3f-b4ff1d47f897@xilinx.com> Date: Wed, 28 Apr 2021 15:17:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210420141847.blcjrrvekjt6llck@bogus> Content-Language: en-US X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b5ae6412-1d02-4afa-230b-08d90a47f934 X-MS-TrafficTypeDiagnostic: BY5PR02MB6081: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CQjNZEFkWl7vVvPXnU+BCtDFv9j2c3+v0pv+1dYcvn3MErlcqKtUS5C0JkeXvH13Zx1AOpi2A5Yn8C6YojbPk7baOizRUAqIImDoUif5N+bwR+41wODkjUUe//NvVhd19ko3HrTWCy9CRQ5Ihj8199UvYRiZxnRsLKojk5MZEwlIYZ3Nsz3oIpi/vjozRIGDDt2OLUDE8xAn7l5W4y00oZKbuPXswGmsWdoLs4aWnIy5ocL9RO++jfJXx6MnUphrzmLk6x4LKtDdewlHlto0f1eTo1fctVPGicCaZoFm9hCcYo9Y3rl8qxg8mxrR6mlP5duI/ptVMpDGkHw880JQnKSTDP4AOuCiT+w3inFPE1EA1Vb4JqMGcFzcO9nOgu2LZD7tNOXA8JBwD0jqM8tVxpdFIRJelPMOUie+Ogv8K8h67nJPyazlj0YuH7KyAD3BEkpxtBXmJpb9mF63ZdA7iCxOztNLAvVJhzB+t9a0tdMXTrCtVfELCx37TZKekD4RXdXIxmWIJwnInU6qOZ76rCP/L4TLQj7QppOTzWNwBr5CV/xPxZB6zALD0GlaXvrBRV/GHzpptURsaivD2iSOqDtrJupaust/GwLpLU/GnUKb4el5CzvjZNr4vG7Z9RrC1aVvHffM+yKexto1h0NHaeoBPXBN/9zcOZUrYtx41bKSuCB0HYDstPQA6wRkKPj2LeNvLXNVVn6iQgeTr/U+tw== X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(39860400002)(396003)(346002)(376002)(136003)(36840700001)(46966006)(36906005)(70586007)(82740400003)(426003)(316002)(9786002)(31696002)(53546011)(8676002)(336012)(54906003)(110136005)(44832011)(4326008)(5660300002)(356005)(70206006)(7636003)(83380400001)(8936002)(26005)(2906002)(2616005)(31686004)(47076005)(186003)(478600001)(82310400003)(36860700001)(36756003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2021 13:17:28.8635 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b5ae6412-1d02-4afa-230b-08d90a47f934 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT018.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6081 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_061733_147201_BB45702C X-CRM114-Status: GOOD ( 26.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 4/20/21 4:18 PM, Sudeep Holla wrote: > On Mon, Apr 19, 2021 at 09:32:39AM +0200, Michael Tretter wrote: > > Sorry for chiming in randomly. I always though the way PM_INIT_FINALIZE > is designed has issues(e.g. racy). I was involved in discussion with > Xilinx when we will designing more generic version of EEMI - SCMI > which is now supported in upstream. EEMI was in production already when > we started on SCMI 3-4 years back and wanted to get feedback. > > [...] > >> >> What is the reason why all devices have to be requested before calling >> zynqmp_pm_init_finalize()? >> > > Yes that is wrong assumption/expectation from the firmware. > >> I was expecting that calling PM_INIT_FINALIZE only would tell the PMU_FW that >> Linux is using the PM API and the PMU_FW should power down/up PM slaves as >> requested by Linux. It is somewhat surprising that this isn't the case and all >> PM slaves have to be powered up before calling PM_INIT_FINALIZE. >> > > Agreed that was my understanding too. > >> What would happen if some driver is built as a module? In that case, the >> module would be loaded and request the pm node only after PM_INIT_FINALIZE was >> called. Do we have to avoid/disallow such cases? >> > > I was told it will work. But it will be always racy if there are multiple > channels to talk to firmware. > > My argument firmware can turn off all the devices before giving control > to OS and no need for that. But there is some boot time optimisation > possible I am told which I could well be. But this interface for too > racy IMO, just happens to be fine with limited configurations it operates > in. Rajan: Can you please do deep dive to this in pmufw and try to figured it out how to fix this on firmware side? Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel