From: William Zhang <william.zhang@broadcom.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Linux ARM List <linux-arm-kernel@lists.infradead.org>
Cc: kursad.oney@broadcom.com, anand.gore@broadcom.com,
dan.beygelman@broadcom.com, f.fainelli@gmail.com,
Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
joel.peshkin@broadcom.com,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
rafal@milecki.pl
Subject: Re: [RFC PATCH 1/3] dt-bindings: arm64: bcmbca: Merge BCM4908 into BCMBCA
Date: Tue, 12 Jul 2022 10:37:34 -0700 [thread overview]
Message-ID: <94b0ab39-279d-d3c2-98a4-054c10ad041c@broadcom.com> (raw)
In-Reply-To: <ca8c3003-1bcb-6658-592c-566609fd7bd2@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 2221 bytes --]
On 7/12/22 00:45, Krzysztof Kozlowski wrote:
> On 12/07/2022 04:11, William Zhang wrote:
>> Merge BCM4908 SoC device tree description into BCMBCA and combined
>> all BCM4908 chip variants into the same BCM4908 chip family item.
>
> Merge means you combine some entries, so I would expect to see the
> removal here as well.
>
Will combine with the removal patch as you pointed out
>>
>> Each compatible string represent the whole chip family. The board
>> variants and chip varints go into the first and second enum in the
>> compatible string item list.
>>
>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>> ---
>>
>> .../bindings/arm/bcm/brcm,bcmbca.yaml | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
>> index d9dc4f22f4a5..906c3e1de372 100644
>> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
>> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
>> @@ -28,6 +28,23 @@ properties:
>> - const: brcm,bcm47622
>> - const: brcm,bcmbca
>>
>> + - description: BCM4908 Family based boards
>> + items:
>> + - enum:
>> + # BCM4908 SoC based boards
>> + - brcm,bcm94908
>> + - asus,gt-ac5300
>> + - netgear,raxe500
>> + # BCM4906 SoC based boards
>> + - brcm,bcm94906
>> + - netgear,r8000p
>> + - tplink,archer-c2300-v1
>> + - enum:
>> + - brcm,bcm4908
>> + - brcm,bcm4906
>> + - brcm,bcm49408
>
> This is wrong. brcm,bcm94908 followed by brcm,bcm4906 does not look
> like valid list of compatibles.
>
For 4908 board variant, it will need to be followed by 4908 chip. Sorry
for the basic question but is there any requirement to enforce this kind
of rule? I would assume dts writer know what he/she is doing and select
the right combination.
>> + - const: brcm,bcmbca
>> +
>> - description: BCM4912 based boards
>> items:
>> - enum:
>
>
> Best regards,
> Krzysztof
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-12 17:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 2:11 [RFC PATCH 0/3] arm: bcmbca: Update BCM4908 dts for BCMBCA merge William Zhang
2022-07-12 2:11 ` [RFC PATCH 1/3] dt-bindings: arm64: bcmbca: Merge BCM4908 into BCMBCA William Zhang
2022-07-12 7:45 ` Krzysztof Kozlowski
2022-07-12 17:37 ` William Zhang [this message]
2022-07-12 18:18 ` Krzysztof Kozlowski
2022-07-13 0:57 ` William Zhang
2022-07-13 10:50 ` Rafał Miłecki
2022-07-13 10:58 ` Rafał Miłecki
2022-07-13 18:37 ` William Zhang
2022-07-13 20:23 ` Rafał Miłecki
2022-07-13 20:29 ` William Zhang
2022-07-18 20:02 ` Rob Herring
2022-07-18 22:59 ` William Zhang
2022-07-13 16:21 ` Florian Fainelli
2022-07-12 2:11 ` [RFC PATCH 2/3] dt-bindings: arm64: bcm4908: remove binding document William Zhang
2022-07-12 7:46 ` Krzysztof Kozlowski
2022-07-12 2:11 ` [RFC PATCH 3/3] arm64: dts: bcmbca: update bcm4808 board dts file William Zhang
2022-07-12 7:47 ` Krzysztof Kozlowski
2022-07-12 15:36 ` Florian Fainelli
2022-07-12 15:50 ` Krzysztof Kozlowski
2022-07-12 17:48 ` William Zhang
2022-07-12 18:20 ` Krzysztof Kozlowski
2022-07-13 0:59 ` William Zhang
2022-07-13 10:55 ` Rafał Miłecki
2022-07-13 11:09 ` Krzysztof Kozlowski
2022-07-13 12:00 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94b0ab39-279d-d3c2-98a4-054c10ad041c@broadcom.com \
--to=william.zhang@broadcom.com \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.beygelman@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=joel.peshkin@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).