From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E887C433F5 for ; Tue, 24 May 2022 11:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=piPIG00jzceNHjkfYzEPAbzmh1kBP3AzzKr1CbbxnZQ=; b=LUqHrEICepfFfW C2jEVKvd8pejUNO7MhO4YW1H1ekm1CfSXWwFkHplsM8tEBDXd/W1feEYJATxUPRV0e7j2tjQUmSnY vkhUjlze8eqX0Zp9cpZBJrIFsRdDJUTw3DJwIM7amZK3Qp4iP9UIlAu6BK1Q0S++1syk0fTHtqlye yPndfy7W0ZGDm2PlUUPtx8+sWN10EJnjQq8Pg4lrQKSOY6ODg6FElkFaMkKzuIFIxsbjSG74Jy82C Dwa+u3Qkcu0zrXxGwcAXY7UEQj59IJMDePwTgzg0bDbuy7VqbvaXWYzxu9vsOPNyxRxK952KzROMr 4TpJPBaVXDtp6FQ/pMFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntSaM-007lx1-TQ; Tue, 24 May 2022 11:20:23 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntSaH-007lwA-Ub for linux-arm-kernel@lists.infradead.org; Tue, 24 May 2022 11:20:19 +0000 Received: by mail-lf1-x12d.google.com with SMTP id w14so30218374lfl.13 for ; Tue, 24 May 2022 04:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=o+P126SPmH870R49rZnjVtAQ0lLibINOxU3kSrrv/z8=; b=SMvYItxQoIa4+8n2A81HdVNR5Z/Hx33wm5H0xD1nUqEQdCWbeN4tMO0ZjR0AUGJ2mY lPNI5rWq8KDx0D8vwOee98mhmo4a1oAh1SDdvTU/gdlscLL6Sxu6nakF2OyBWeaK0h75 FCXZjRYMvXglCUp20LO+/9U91BjDAiB1jiksNdcA/q7Wgu3xF1Nq4huPDYm/YQNgRDKU P3mANTADrLRpTSgtapYACgbxYFGIxB26u93BNoYNHVhjKTbAxFOEOxBD3pY+X24NawYM x53/fxFrDPIOyUPjVIqUif3Y6rAYtEN5464K1gdnn2r3Zfs7kfcdnw+U87gzDWBJtNx0 rxsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=o+P126SPmH870R49rZnjVtAQ0lLibINOxU3kSrrv/z8=; b=fNHeLdoeUBgfD0lQohcy+gxk7MIkBJOml4DhmyMJY8MZDFl97kmOYA9PzlAAO3I057 6ZXarnVlbYC/zq8iWII4tAR/mwe1ZEExlc+E+lpEOdBflpnsAEdDI5fc49qgR6WZx+cz VZ3oK1/8ZxmJbm5CVRtPZoMQ/acsuvwxKlCtAjEPZumzDgcQfZvk/xNrKAUyx6vbLPI3 T4/bsPvOTtq3wHtAadLNJOsjb/a4I7rBNBjp9tOxOK4OTzsrkQDspUvju7WIxKZzkUVH qxQl1t3zqUKDCt0VfZpfk8APGLBBCkxfaEtIRbaCfHJo2HY0Jxm5zf17xhQTsXY7xfol k9qg== X-Gm-Message-State: AOAM530CnT74gXLBlPmnOnSZEzAb3VI8FChiShU70wxyyqPTWOmU+hJa CcU81VkFm05Ai9SUmOkBIegJEg== X-Google-Smtp-Source: ABdhPJzmHrk/56T37ils6m/MiRllzq9R03TSRVqArMoj3ScLBwg+xIn7CZIv4hN266uJZrfvwWpf1w== X-Received: by 2002:a05:6512:3a96:b0:478:7abd:52e with SMTP id q22-20020a0565123a9600b004787abd052emr5245487lfu.446.1653391214165; Tue, 24 May 2022 04:20:14 -0700 (PDT) Received: from [172.20.68.48] ([91.221.145.6]) by smtp.gmail.com with ESMTPSA id g7-20020a2ea4a7000000b00253d8962fffsm2445974ljm.18.2022.05.24.04.20.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 04:20:13 -0700 (PDT) Message-ID: <94bf86ee-2458-924e-1a7f-b7723bfcf04e@linaro.org> Date: Tue, 24 May 2022 13:20:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/7] dt-bindings: soc: add bindings for i.MX93 mediamix blk ctrl Content-Language: en-US To: "Peng Fan (OSS)" , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, sboyd@kernel.org, mturquette@baylibre.com, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: aisheng.dong@nxp.com, l.stach@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan References: <20220523113029.842753-1-peng.fan@oss.nxp.com> <20220523113029.842753-3-peng.fan@oss.nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220523113029.842753-3-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220524_042018_037728_6D4CF08B X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/05/2022 13:30, Peng Fan (OSS) wrote: > From: Peng Fan > > Add DT bindings for i.MX93 MEDIAMIX BLK CTRL. In the subject - you duplicate "bindings", so just "dt-bindings: soc: add i.MX93 mediamix blk ctrl" > > Signed-off-by: Peng Fan > --- > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 81 +++++++++++++++++++ > include/dt-bindings/power/imx93-power.h | 6 ++ > 2 files changed, 87 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > new file mode 100644 > index 000000000000..775c08d763b8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/imx/fsl,imx93-media-blk-ctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX93 Media blk-ctrl > + > +maintainers: > + - Peng Fan > + > +description: > + The i.MX93 MEDIAMIX domain contains control and status registers known > + as MEDIAMIX Block Control (MEDIAMIX BLK_CTRL). These registers include > + clocking, reset, and miscellaneous top-level controls for peripherals > + within the MEDIAMIX domain > + > +properties: > + compatible: > + items: > + - const: fsl,imx93-media-blk-ctrl > + - const: syscon > + > + reg: > + maxItems: 1 > + > + '#power-domain-cells': > + const: 1 Missing ref to power domains. > + > + power-domains: > + maxItems: 1 > + > + clocks: > + minItems: 10 minItems is not needed in such case. > + maxItems: 10 > + > + clock-names: > + items: > + - const: apb > + - const: axi > + - const: nic > + - const: disp > + - const: cam > + - const: pxp > + - const: lcdif > + - const: isi > + - const: csi > + - const: dsi > + > +required: > + - compatible > + - reg > + - power-domains > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + media_blk_ctrl: blk_ctrl@4ac10000 { No underscores in node names. Generic node name, so "system-controller" or "power-controller"? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel