From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Florian Fainelli <f.fainelli@gmail.com>,
Stefan Wahren <wahrenst@gmx.net>,
catalin.marinas@arm.com, devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Eric Anholt <eric@anholt.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: bcm2711: force CMA into first GB of memory
Date: Mon, 04 Nov 2019 19:53:39 +0100 [thread overview]
Message-ID: <95359117f4f14f296db1cabc6fa68fbfcf78b2f5.camel@suse.de> (raw)
In-Reply-To: <05f00d57-6151-45df-67ee-b49a18a611c7@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1388 bytes --]
On Mon, 2019-11-04 at 09:51 -0800, Florian Fainelli wrote:
> On 11/4/19 9:09 AM, Stefan Wahren wrote:
>
> [snip]
>
> > > + reserved-memory {
> > > + #address-cells = <2>;
> > > + #size-cells = <1>;
> > > + ranges;
> > > +
> > > + /*
> > > + * arm64 reserves the CMA by default somewhere in ZONE_DMA32,
> > > + * that's not good enough for the Raspberry Pi 4 as some
> > > + * devices can only address the lower 1G of memory (ZONE_DMA).
> > > + */
> > > + linux,cma {
> > > + compatible = "shared-dma-pool";
> > > + size = <0x2000000>; /* 32MB */
> > > + alloc-ranges = <0x0 0x00000000 0x40000000>;
> > > + reusable;
> > > + linux,cma-default;
> > > + };
> > > + };
> > > +
> >
> > i think this is a SoC-specific issue not a board specifc one. Please
> > move this to bcm2711.dtsi
>
> This sounds like a possibly fragile solution if someone changes
> CONFIG_CMA_SIZE_MBYTES to a value greater than 32MB no?
I agree it's not the most flexible solution in the world. It also bypasses the
command line interface. But I can't see any alternatives as of today.
Overall, I suggest that we set CMA's size to whatever is needed for a sensible
desktop use. And let odd users with custom HW modify it trough overlays (which
they will most likely be forced to do anyway).
That said I'm open to suggestions.
Regards,
Nicolas
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-04 18:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 13:54 [PATCH 0/2] arm64: Fix CMA/crashkernel reservation Nicolas Saenz Julienne
2019-11-04 13:54 ` [PATCH 1/2] ARM: dts: bcm2711: force CMA into first GB of memory Nicolas Saenz Julienne
2019-11-04 17:09 ` Stefan Wahren
2019-11-04 17:19 ` Nicolas Saenz Julienne
2019-11-04 17:51 ` Florian Fainelli
2019-11-04 18:48 ` Florian Fainelli
2019-11-04 18:53 ` Nicolas Saenz Julienne [this message]
2019-11-05 14:51 ` Catalin Marinas
2019-11-05 22:04 ` Stefan Wahren
2019-11-04 13:54 ` [PATCH 2/2] arm64: mm: reserve CMA and crashkernel in ZONE_DMA32 Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95359117f4f14f296db1cabc6fa68fbfcf78b2f5.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).