From: "Zhang, Jerry(Junwei)" <Jerry.Zhang@amd.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
<linux-kernel@vger.kernel.org>
Cc: Carsten.Haitzler@arm.com, David Airlie <airlied@linux.ie>,
will.deacon@arm.com, dri-devel@lists.freedesktop.org,
Huang Rui <ray.huang@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
linux-arm-kernel@lists.infradead.org,
Bernhard.Rosenkranzer@linaro.org
Subject: Re: [RFC PATCH] drm/ttm: force cached mappings for system RAM on ARM
Date: Thu, 10 Jan 2019 16:36:05 +0800 [thread overview]
Message-ID: <95b377d3-6d85-c296-d32e-a6d7f941b5b8@amd.com> (raw)
In-Reply-To: <20190110072841.3283-1-ard.biesheuvel@linaro.org>
On 1/10/19 3:28 PM, Ard Biesheuvel wrote:
> ARM systems do not permit the use of anything other than cached
> mappings for system memory, since that memory may be mapped in the
> linear region as well, and the architecture does not permit aliases
> with mismatched attributes.
>
> So short-circuit the evaluation in ttm_io_prot() if the flags include
> TTM_PL_SYSTEM when running on ARM or arm64, and just return cached
> attributes immediately.
It sounds a case for ARM system memory access from CPU only?
If that always applies to ARM memory, suppose we should do that for
TTM_PL_TT as well.
While TTM_PL_TT | TTM_PL_FLAG_WC is likely to work as below mention.
Regards,
Jerry
> This fixes the radeon and amdgpu [TBC] drivers when running on arm64.
> Without this change, amdgpu does not start at all, and radeon only
> produces corrupt display output.
>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Cc: Huang Rui <ray.huang@amd.com>
> Cc: Junwei Zhang <Jerry.Zhang@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Reported-by: Carsten Haitzler <Carsten.Haitzler@arm.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> drivers/gpu/drm/ttm/ttm_bo_util.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index 046a6dda690a..0c1eef5f7ae3 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -530,6 +530,11 @@ pgprot_t ttm_io_prot(uint32_t caching_flags, pgprot_t tmp)
> if (caching_flags & TTM_PL_FLAG_CACHED)
> return tmp;
>
> +#if defined(__arm__) || defined(__aarch64__)
> + /* ARM only permits cached mappings of system memory */
> + if (caching_flags & TTM_PL_SYSTEM)
> + return tmp;
> +#endif
> #if defined(__i386__) || defined(__x86_64__)
> if (caching_flags & TTM_PL_FLAG_WC)
> tmp = pgprot_writecombine(tmp);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-10 8:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 7:28 [RFC PATCH] drm/ttm: force cached mappings for system RAM on ARM Ard Biesheuvel
2019-01-10 8:36 ` Zhang, Jerry(Junwei) [this message]
2019-01-10 8:36 ` Koenig, Christian
2019-01-10 9:34 ` Michel Dänzer
2019-01-14 10:53 ` Ard Biesheuvel
2019-01-14 11:38 ` Koenig, Christian
2019-01-14 17:32 ` Ard Biesheuvel
[not found] ` <9f956898-7973-98ee-6bf1-e1d445e9d365@amd.com>
2019-01-14 19:13 ` Will Deacon
2019-01-14 19:21 ` Koenig, Christian
2019-01-14 19:35 ` Will Deacon
2019-01-15 11:31 ` Michael Ellerman
2019-01-16 0:33 ` Benjamin Herrenschmidt
2019-01-16 7:35 ` Koenig, Christian
2019-01-16 7:47 ` Ard Biesheuvel
2019-01-17 6:07 ` Benjamin Herrenschmidt
2019-01-17 8:02 ` Ard Biesheuvel
2019-01-17 5:59 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95b377d3-6d85-c296-d32e-a6d7f941b5b8@amd.com \
--to=jerry.zhang@amd.com \
--cc=Bernhard.Rosenkranzer@linaro.org \
--cc=Carsten.Haitzler@arm.com \
--cc=airlied@linux.ie \
--cc=ard.biesheuvel@linaro.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ray.huang@amd.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).