From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5F3C433DB for ; Thu, 4 Mar 2021 07:01:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBB4664EE3 for ; Thu, 4 Mar 2021 07:01:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBB4664EE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=St7b6gpBX0/CmLogCJrD1P5+JVlTbScgGD12RuUewgM=; b=Je238yzBk0nhTu3H+W4jh6pNR aQBlGXP1rlIQXWiMSktChBf1A20r2cnMgODCILGap78b9aHrisXe44hl4KCRG3i+K31LRXkLD/JlL JdpCKgdvCItSY3VkTTi12RA/IOylSZs4zTZRfkxsLNXHaaBgPfMdVsq1kq4ApJtwS4ZhmMvVzpr1K /Wgd0XMsQwg2Qtkcjc5qqLO3uzSyU3qUKf0hXCaFatisEhilGogs8tyk3Iz9xt0BdPT9AOCTdvmgj MU8SAMYClbRqS0JM2vUNqTudT8QP56AwfeTZyyjL1iW/2pDMKciPQTZTiY1H/rKg7BXyiHRmasBtW nhm9VEohA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHhwT-007zPs-N1; Thu, 04 Mar 2021 06:58:38 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHhwL-007zOi-Ea for linux-arm-kernel@lists.infradead.org; Thu, 04 Mar 2021 06:58:34 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1246wNDH102724; Thu, 4 Mar 2021 00:58:23 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1614841103; bh=4ud8kZ1bZeikUJSDGbMVvjTvW9JdEr9/2XJ/vMSr4dI=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=NKA2DlLHddlpjapdYttVJUPapQ5C5yTqCsPa3tf52qcSM5DsSMnoIPt7NKYcrfAUm b4oIbfV/RDtCMilyLYRb1VnLw+RAsHqQAVeF6gs/zmWwCOyDc7HNUzMGZARxZpTFjI bWppFgFW/OmBg9KYEzXFn6TgoNCgw0+Yqy34vacg= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1246wNUP044152 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Mar 2021 00:58:23 -0600 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 4 Mar 2021 00:58:22 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 4 Mar 2021 00:58:22 -0600 Received: from [10.250.234.120] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1246wJBO032193; Thu, 4 Mar 2021 00:58:20 -0600 Subject: Re: [PATCH v2 3/4] arm64: dts: ti: Add support for Siemens IOT2050 boards To: Jan Kiszka , Nishanth Menon , Tero Kristo , Rob Herring CC: , Bao Cheng Su , , , Le Jin References: <0c64b6ad43e7a691c1547524da4a9fd33e61c70c.1613071976.git.jan.kiszka@siemens.com> From: Vignesh Raghavendra Message-ID: <95e4231c-6bee-ba64-412f-87d257df61c4@ti.com> Date: Thu, 4 Mar 2021 12:28:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0c64b6ad43e7a691c1547524da4a9fd33e61c70c.1613071976.git.jan.kiszka@siemens.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 2/12/21 1:02 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Add support for two Siemens SIMATIC IOT2050 variants, Basic and > Advanced. They are based on the TI AM6528 GP and AM6548 SOCs HS, thus > differ in their number of cores and availability of security features. > Furthermore the Advanced version comes with more RAM, an eMMC and a few > internal differences. > > Based on original version by Le Jin. > > Link: https://new.siemens.com/global/en/products/automation/pc-based/iot-gateways/simatic-iot2050.html > Link: https://github.com/siemens/meta-iot2050 > Signed-off-by: Jan Kiszka Reviewed-by: Vignesh Raghavendra Few minor comments below: [...] > + > +&mcu_i2c0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mcu_i2c0_pins_default>; > + clock-frequency = <400000>; > + > + psu: tps62363@60 { Please use generic node names: psu: regulator@60 { ... }; > + compatible = "ti,tps62363"; > + reg = <0x60>; > + regulator-name = "tps62363-vout"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1500000>; > + regulator-boot-on; > + ti,vsel0-state-high; > + ti,vsel1-state-high; > + ti,enable-vout-discharge; > + }; > + > + /* D4200 */ > + pcal9535_1: gpio@20 { > + compatible = "nxp,pcal9535"; > + reg = <0x20>; > + #gpio-cells = <2>; > + gpio-controller; > + gpio-line-names = > + "A0-pull", "A1-pull", "A2-pull", "A3-pull", "A4-pull", > + "A5-pull", "", "", > + "IO14-enable", "IO15-enable", "IO16-enable", > + "IO17-enable", "IO18-enable", "IO19-enable"; > + }; > + > + /* D4201 */ > + pcal9535_2: gpio@21 { > + compatible = "nxp,pcal9535"; > + reg = <0x21>; > + #gpio-cells = <2>; > + gpio-controller; > + gpio-line-names = > + "IO0-direction", "IO1-direction", "IO2-direction", > + "IO3-direction", "IO4-direction", "IO5-direction", > + "IO6-direction", "IO7-direction", > + "IO8-direction", "IO9-direction", "IO10-direction", > + "IO11-direction", "IO12-direction", "IO13-direction", > + "IO19-direction"; > + }; > + > + /* D4202 */ > + pcal9535_3: gpio@25 { > + compatible = "nxp,pcal9535"; > + reg = <0x25>; > + #gpio-cells = <2>; > + gpio-controller; > + gpio-line-names = > + "IO0-pull", "IO1-pull", "IO2-pull", "IO3-pull", > + "IO4-pull", "IO5-pull", "IO6-pull", "IO7-pull", > + "IO8-pull", "IO9-pull", "IO10-pull", "IO11-pull", > + "IO12-pull", "IO13-pull"; > + }; > +}; [...] > +&dwc3_0 { > + status = "okay"; > +}; > + > +&usb0_phy { > + status = "okay"; > +}; > + These nodes are enabled by default right? Above is redundant. > +&usb0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&usb0_pins_default>; > + dr_mode = "host"; > +}; > + > +&dwc3_1 { > + status = "okay"; > +}; > + > +&usb1_phy { > + status = "okay"; > +}; > + Same here... > +&usb1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&usb1_pins_default>; > + dr_mode = "host"; > +}; > + [...] > +&mcu_spi0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mcu_spi0_pins_default>; > + > + #address-cells = <1>; > + #size-cells= <0>; > + ti,pindir-d0-out-d1-in = <1>; > + > + spidev@0 { > + compatible = "rohm,dh2228fv"; > + spi-max-frequency = <20000000>; > + reg = <0>; > + }; Is the device really dh2228fv? > +}; > + > +&tscadc0 { > + status = "disabled"; > +}; > + > +&tscadc1 { > + adc { > + ti,adc-channels = <0 1 2 3 4 5>; > + }; > +}; > + > +&ospi0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mcu_fss0_ospi0_pins_default>; > + > + flash@0 { > + compatible = "jedec,spi-nor"; > + reg = <0x0>; > + spi-tx-bus-width = <1>; > + spi-rx-bus-width = <1>; > + spi-max-frequency = <50000000>; > + cdns,tshsl-ns = <60>; > + cdns,tsd2d-ns = <60>; > + cdns,tchsh-ns = <60>; > + cdns,tslch-ns = <60>; > + cdns,read-delay = <2>; > + #address-cells = <1>; > + #size-cells = <1>; > + }; > +}; > + > +&dss { > + status = "okay"; > + Node is enabled by default. Please drop above line for consistency. > + pinctrl-names = "default"; > + pinctrl-0 = <&dss_vout1_pins_default>; > + > + assigned-clocks = <&k3_clks 67 2>; > + assigned-clock-parents = <&k3_clks 67 5>; > +}; > + > +&dss_ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@1 { > + reg = <1>; > + > + dpi_out: endpoint { > + remote-endpoint = <&bridge_in>; > + }; > + }; > +}; > + [...] Regards Vignesh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel