From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC16C282DD for ; Thu, 23 May 2019 21:53:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F135C21773 for ; Thu, 23 May 2019 21:53:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b+nk3WWK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="lydjv4HV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F135C21773 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:From:Date: MIME-Version:Subject:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=z9cnjeazTCYyZNZMlRsrSrFYz7Sc9+c5ULLPjqibAjA=; b=b+nk3WWKJLzYHYNZraJU/xUKm cP1G3BQnk9pMAwFFwxoz1TkWu8lVMM2QXLeosP26niVuLPplTJcizKvh5acaqjKiE4Ro4ZiWPxIrT A2WX2Hlqgg8Tgmr9hvp1+fspKLFSllcJZ2zeAvI22ylxdXzWfOamHvKLwMnSEtngzihzJrEUsX91U NXFJ9pTvC1mDgzyHAyq8OeH3ru2zc9lExMSdeFUkOmTzTjlWggklOpGhFcO6ct0Wgi37OkNht+QBy 4BslOi+iUYX7z3p56Q4pGRxnFjAEgEI5Jg39Pvor1BPTEcZOq++GbrlkGMDpAGqHwevYN9namX2cT 5/hfsBlWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTve1-0006kt-St; Thu, 23 May 2019 21:53:01 +0000 Received: from node.akkea.ca ([192.155.83.177]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTvdy-0006k5-Ma for linux-arm-kernel@lists.infradead.org; Thu, 23 May 2019 21:52:59 +0000 Received: by node.akkea.ca (Postfix, from userid 33) id EE1D44E204B; Thu, 23 May 2019 21:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1558648376; bh=EEx6+r+EW8Gn9LAjThkYPyrhI3Zs+zGHNmTtqinmKv4=; h=To:Subject:Date:From:Cc:In-Reply-To:References; b=lydjv4HV77oK6COWSrTB1aH1fzxQCpWZn3f9c5YJdUPbwSs9j4jrs+wewljakLQ7n SuVyaPb07lQ5iHRWYIVaoMcXhR2PcSdEsn9Gj4eL9enTjgl4octPYeaEFmGc7eJJ+x uVBAjCgayvFpSuhgomr0JoIhmwvSb+a0fFBEHF90= To: Pavel Machek Subject: Re: [PATCH v13 2/4] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit X-PHP-Originating-Script: 1000:rcube.php MIME-Version: 1.0 Date: Thu, 23 May 2019 14:52:56 -0700 From: Angus Ainslie In-Reply-To: <20190523191922.GA3803@xo-6d-61-c0.localdomain> References: <20190520142330.3556-1-angus@akkea.ca> <20190520142330.3556-3-angus@akkea.ca> <20190523191922.GA3803@xo-6d-61-c0.localdomain> Message-ID: <9626cd324eaaab2b49c37cf3c824aa5e@www.akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190523_145258_780367_797AB838 X-CRM114-Status: GOOD ( 14.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel-owner@vger.kernel.org, Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , angus.ainslie@puri.sm, Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Pavel, On 2019-05-23 12:19, Pavel Machek wrote: > Hi! > >> This is for the development kit board for the Librem 5. The current >> level >> of support yields a working console and is able to boot userspace from >> the network or eMMC. >> >> Additional subsystems that are active : > >> - haptic motor > > Haptic motor is not a LED. It should be controlled by input subsystem. > >> + pwmleds { >> + compatible = "pwm-leds"; >> + >> + haptic { >> + label = "librem5::haptic"; >> + pwms = <&pwm2 0 200000>; >> + active-low; >> + max-brightness = <255>; >> + power-supply = <®_3v3_p>; >> + }; >> + }; > > You can take a look at N900, that has reasonable interface. > I wanted to control the haptic with the pwm-vibra driver but "fsl,imx27-pwm" doesn't seem to respect the PWM_POLARITY_INVERTED flag so when I start the system the vibrator is full on. I could use gpio-vibrator but that seemed like a waste when the device is connected to pwm. I figured the using the pwm-leds interface was a reasonable compromise until I had an opportunity to make changes the the imx27-pwm driver. Thanks Angus > Thanks, > Pavel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel