From: <Nicolas.Ferre@microchip.com>
To: <bbrezillon@kernel.org>, <peda@axentia.se>
Cc: alexandre.belloni@bootlin.com, airlied@linux.ie,
Joshua.Henderson@microchip.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, boris.brezillon@bootlin.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] drm/atmel-hlcdc: fix plane clipping/rotation issues
Date: Fri, 11 Jan 2019 14:18:34 +0000 [thread overview]
Message-ID: <96578f9c-74f1-38ab-7993-460fd9bc42ee@microchip.com> (raw)
In-Reply-To: <20190110184446.75b4350a@bbrezillon>
On 10/01/2019 at 18:45, Boris Brezillon wrote:
> On Thu, 10 Jan 2019 15:10:28 +0000
> Peter Rosin <peda@axentia.se> wrote:
>
>> Hi!
>>
>> I found an unfortunate issue while recoding plane handling to use
>> drm_atomic_helper_check_plane_state(). The driver rotates clockwise,
>> which is not correct. I simply fixed it (patch 1/4), but maybe that
>> will cause regressions for unsuspecting users who simply assumed
>> that the clockwise rotation was correct? I don't know what to do
>> about that? Adding an option to get the old broken behavior seems
>> useless, wouldn't it be just as easy to just fix whatever app to
>> rotate the other way instead of adding an option somewhere?
>
> Hm, rotation support has been added before the standard rotation
> property was created, and at that time I assumed rotation was clockwise
> (which apparently was an unwise choice). Anyway, I don't have a
> solution for this problem, so I'll let Nicolas decide if it's
> acceptable to change the rotation behavior.
Yes, being consistent with standard DRM sub-system is far more important
in my opinion.
Best regards,
Nicolas
>> I have only tested this series on sama5d3, but I did check the docs
>> for various other chips (sama5d2, sama5d4, sam9n12, sam9g15, sam9g35
>> and sam9x35) supported by the driver (relevant to patch 4/4).
>
> Thanks for addressing those problems.
>
>>
>> Cheers,
>> Peter
>>
>> Peter Rosin (4):
>> drm/atmel-hlcdc: rotate planes counterclockwise
>> drm/atmel-hlcdc: do not swap w/h of the crtc when a plane is rotated
>> drm/atmel-hlcdc: fix clipping of planes
>> drm/atmel-hlcdc: do not immediately disable planes, wait for next
>> frame
>>
>> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 179 +++++++++---------------
>> 1 file changed, 67 insertions(+), 112 deletions(-)
>>
>
>
--
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-11 14:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 15:10 [PATCH 0/4] drm/atmel-hlcdc: fix plane clipping/rotation issues Peter Rosin
2019-01-10 15:10 ` [PATCH 1/4] drm/atmel-hlcdc: rotate planes counterclockwise Peter Rosin
2019-01-10 15:10 ` [PATCH 2/4] drm/atmel-hlcdc: do not swap w/h of the crtc when a plane is rotated Peter Rosin
2019-01-10 17:48 ` Boris Brezillon
2019-01-11 13:29 ` Peter Rosin
2019-01-11 14:14 ` Nicolas.Ferre
2019-01-10 15:10 ` [PATCH 3/4] drm/atmel-hlcdc: fix clipping of planes Peter Rosin
2019-01-10 15:10 ` [PATCH 4/4] drm/atmel-hlcdc: do not immediately disable planes, wait for next frame Peter Rosin
2019-01-10 17:29 ` Boris Brezillon
2019-01-10 18:51 ` Peter Rosin
2019-01-10 19:25 ` Boris Brezillon
2019-01-11 14:29 ` Peter Rosin
2019-01-16 14:45 ` Boris Brezillon
2019-01-10 17:45 ` [PATCH 0/4] drm/atmel-hlcdc: fix plane clipping/rotation issues Boris Brezillon
2019-01-10 20:16 ` Sam Ravnborg
2019-01-11 9:16 ` Peter Rosin
2019-01-10 21:24 ` Peter Rosin
2019-01-11 14:18 ` Nicolas.Ferre [this message]
2019-01-27 8:27 ` Boris Brezillon
2019-01-31 13:13 ` Peter Rosin
2019-01-31 13:21 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96578f9c-74f1-38ab-7993-460fd9bc42ee@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Joshua.Henderson@microchip.com \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@bootlin.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).