From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEBDFC433E0 for ; Wed, 3 Mar 2021 19:24:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C62A64EBB for ; Wed, 3 Mar 2021 19:24:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C62A64EBB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=scZJJ6h53JRfe08QACfc045sbsCmGtYeSNdfCmuxHt0=; b=nD1vuftF0Mh4OonzYCCNZIWh5 CQieCpxAzjSiQxENemP3uSg6KeApYNI0yDxD/bETInoSdPJe8bZx/GU69bUbHqd3Xs4zuKAUTFa92 HLI+vslrGcScTXaTZjAr66G8Bv2EfIGnqvkw3j2qRgraFwwLk5ueW9E7H7WtgEMnC+GQd+yhhaoKw InhqogG1Rr+BMlBPAW5hGsEvPFLuzH2BDlx7OdvwnsBf0y6q0Zb/jMjnYWZmM59Jy8X3r1+8yv0g4 ldbJudgOovotL+tL1oIQIzBvUHTaWKIt+8NglDfTrOG1pSn+iCBPpL4rL/HU/vXTEZSxuLj5MYYWI MRo9lgyLQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHX43-006BxP-HX; Wed, 03 Mar 2021 19:21:45 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHT38-005HxD-V8 for linux-arm-kernel@desiato.infradead.org; Wed, 03 Mar 2021 15:04:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=ZxiIkQ9Chmcr/Um94hFBgRidvu6+S6jxlCs6FBzerPs=; b=M6teszFMyndHZiQxKc5LuZjcqc fAzYW+lmt5968fXyQSMicivu33bplK4XtqTHruuu7/eNiDt7Ib5MnXQlFKFiKmqCD7NwJhtaXlVQA iKnyvOCVARQsEYo7SiwuildokM+3LZE5MVBSFeJZd6CgllTrZ0XgD0O0EBiKAGKZD9qLQkF0qY0md tRD6ru3iGXwE/okNrNQmax3oHytg9zAdM6863EGjLA0BHjqoZlHKpoLZz/tbR45tzm5awj6/AKztW 2T+5BiAgvug15UqPou7lEnXC+hmA1j8fTMqhs/MUSoTw+wbYbbAnD9vkewJdwk86ek5LobXt2L5W+ 9FMikssA==; Received: from foss.arm.com ([217.140.110.172]) by casper.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lH3Ol-00H1pK-Km for linux-arm-kernel@lists.infradead.org; Tue, 02 Mar 2021 11:41:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D0905106F; Tue, 2 Mar 2021 03:41:00 -0800 (PST) Received: from [10.57.48.219] (unknown [10.57.48.219]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C1933FA00; Tue, 2 Mar 2021 03:40:58 -0800 (PST) Subject: Re: [RFC 10/13] iommu/arm-smmu-impl: Get rid of Marvell's implementation details To: Nicolas Saenz Julienne , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: f.fainelli@gmail.com, robh+dt@kernel.org, ardb@kernel.org, hch@infradead.org, narmstrong@baylibre.com, dwmw2@infradead.org, linux@armlinux.org.uk, catalin.marinas@arm.com, arnd@arndb.de, will@kernel.org References: <20210226140305.26356-1-nsaenzjulienne@suse.de> <20210226140305.26356-11-nsaenzjulienne@suse.de> From: Robin Murphy Message-ID: <96b6c3e4-d9d3-270e-6d8e-7c826ae11827@arm.com> Date: Tue, 2 Mar 2021 11:40:53 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226140305.26356-11-nsaenzjulienne@suse.de> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210302_114110_341941_65759DB4 X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-02-26 14:03, Nicolas Saenz Julienne wrote: > arm-smmu can now deal with integrations on buses that don't support > 64bit MMIO accesses. No need to create a special case for that on > Marvell's integration. This breaks compatibility with existing DTs. Robin. > Signed-off-by: Nicolas Saenz Julienne > --- > drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c b/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c > index 136872e77195..55d40e37e144 100644 > --- a/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c > @@ -145,25 +145,6 @@ static const struct arm_smmu_impl arm_mmu500_impl = { > .reset = arm_mmu500_reset, > }; > > -static u64 mrvl_mmu500_readq(struct arm_smmu_device *smmu, int page, int off) > -{ > - /* > - * Marvell Armada-AP806 erratum #582743. > - * Split all the readq to double readl > - */ > - return hi_lo_readq_relaxed(arm_smmu_page(smmu, page) + off); > -} > - > -static void mrvl_mmu500_writeq(struct arm_smmu_device *smmu, int page, int off, > - u64 val) > -{ > - /* > - * Marvell Armada-AP806 erratum #582743. > - * Split all the writeq to double writel > - */ > - hi_lo_writeq_relaxed(val, arm_smmu_page(smmu, page) + off); > -} > - > static int mrvl_mmu500_cfg_probe(struct arm_smmu_device *smmu) > { > > @@ -181,8 +162,6 @@ static int mrvl_mmu500_cfg_probe(struct arm_smmu_device *smmu) > } > > static const struct arm_smmu_impl mrvl_mmu500_impl = { > - .read_reg64 = mrvl_mmu500_readq, > - .write_reg64 = mrvl_mmu500_writeq, > .cfg_probe = mrvl_mmu500_cfg_probe, > .reset = arm_mmu500_reset, > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel