From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07256C43334 for ; Tue, 5 Jul 2022 12:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b043RtxGIisyxKGpLKGrsLthH/qGvdlXo25OLruFaLk=; b=EA/cDYrIfK3zch AsyLnruT3K9f1zeplYX4vaDl7omuSb8Em3HATHkffgOjZqTRxbMF6rOJPKcdJo+9cGUiNoiDeO9Ew /4TgJOG4BFzeVoZmp3dqITqsBmQGnwNjSlSRAYwqLzkPY54AmyxDZgUs/RwMcXoSme4+9Ay22WBvL eG3OLEzQ3EI0EXWGVvni1FsMF5bcogzmG7jlzBMJnAoZ6uSGVr0YuSTMG4AJXULfDsrmm1vRTnW4R EPDtRC1qQ67sXLAtUyHcSLWwBxFxGUk2pBfTB970FJnujFbM+2BsUBc2SP7ggITDu7w3d0YOGWj40 twL9+XrR8t7I7TgDURPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8hMS-0002qb-C9; Tue, 05 Jul 2022 12:09:00 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8hMP-0002om-7R for linux-arm-kernel@lists.infradead.org; Tue, 05 Jul 2022 12:08:58 +0000 Received: by mail-lf1-x134.google.com with SMTP id j21so20243261lfe.1 for ; Tue, 05 Jul 2022 05:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ihhr+go3H6HNgFbSksIx63Cidh++W2IwUum3O7T/3gk=; b=It5uTRFw2c8H1LR8TfaJKFKMA1hKtnruFe2SdrSsC7xUf8XjoruTXCJRNB5KxAm9+4 NzwTDfmPtbsDAdaji7gkFBjYYIqr+ylikcW6DqWjuAJWQQ64rXQ/aDymH4AQjE95w93A edQjCBwR1LZwqfekoQ1N6cZzPcjs4j5LWOeaGfB71BdmcFZ0Cix+lMlIxlO6wzgm/fGA Uek3CaYmRIHb+PYdESrgnFB3vZV5nMkB+E84xsOvEFD4YlyjWmuGswMcxYjxdtjWwxZu 3U6UIpQRd9sgdzyb4bPW3SWi3adHjSYjfpcWwONpKuKe7JblrGM/Y3Ommt6t5dYEeEck zXXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ihhr+go3H6HNgFbSksIx63Cidh++W2IwUum3O7T/3gk=; b=cKMkzM6/cxVdKwlPj0e8RNLrgQslvEho25ioRWq00JVEVgdNjnXQu8aP7RNUnXJHHv 9V58sY3rGz4LfyZFizaPBF50b01/z+KvQVYjyq1/Z8T1yCkrZ5TQ/4EowAoV4mpuhns3 xUiaoPjrOY1XuPZgfBbGfxcMl0nXh7kthnBTqu1zAGXtUkiFHxagWFqutzJiFYBdAgTY V2ucdfFWl423AGTw7fEb1Crh1cH/fdDqabJiyrZk0Y2KGnfWqbJSK+Kqep+QauEnXx9h U9P7c1PRqLl9si+w3KYxpppXR3sA3oeTRMUVMLAziNcfIDp1XvFMF/cP23pzLGfTpR03 D2WQ== X-Gm-Message-State: AJIora96c66NYNxUOIkN0a/wB0VmUf2nfK0pzoSAzGKpPY+fRNx+ToMk mCD18Lzo3YZYhOUyXEZzsRuV4w== X-Google-Smtp-Source: AGRyM1tFWsgMJ/MlaFpyOPsBIAszroay69w97JtxjVrtk8RsY2Y9SlOtd9egItDMdymBkfNWyLdwsg== X-Received: by 2002:a05:6512:2393:b0:47f:8f12:3a93 with SMTP id c19-20020a056512239300b0047f8f123a93mr21458936lfv.209.1657022935496; Tue, 05 Jul 2022 05:08:55 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id s21-20020a056512315500b0047f6e91d4fesm3275915lfi.141.2022.07.05.05.08.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 05:08:54 -0700 (PDT) Message-ID: <97d9ccf9-71f8-c97d-ce56-8aeb1a3db194@linaro.org> Date: Tue, 5 Jul 2022 14:08:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 02/20] dt-bindings: media: s5p-mfc: Convert s5p-mfc.txt to new DT schema Content-Language: en-US To: Smitha T Murthy , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, linux-fsd@tesla.com References: <20220517125548.14746-1-smitha.t@samsung.com> <20220517125548.14746-3-smitha.t@samsung.com> <6c2ea5f7-3cc0-d43c-c667-18c25b64ff72@linaro.org> <01e601d89064$a212a590$e637f0b0$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <01e601d89064$a212a590$e637f0b0$@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_050857_323587_1E3F60A4 X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/07/2022 13:44, Smitha T Murthy wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] >> Sent: Tuesday, May 17, 2022 7:26 PM >> To: Smitha T Murthy ; linux-arm- >> kernel@lists.infradead.org; linux-media@vger.kernel.org; linux- >> kernel@vger.kernel.org; devicetree@vger.kernel.org >> Cc: m.szyprowski@samsung.com; andrzej.hajda@intel.com; >> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; >> ezequiel@vanguardiasur.com.ar; jernej.skrabec@gmail.com; >> benjamin.gaignard@collabora.com; stanimir.varbanov@linaro.org; >> dillon.minfei@gmail.com; david.plowman@raspberrypi.com; >> mark.rutland@arm.com; robh+dt@kernel.org; krzk+dt@kernel.org; >> andi@etezian.org; alim.akhtar@samsung.com; aswani.reddy@samsung.com; >> pankaj.dubey@samsung.com; linux-fsd@tesla.com >> Subject: Re: [PATCH 02/20] dt-bindings: media: s5p-mfc: Convert s5p-mfc.txt >> to new DT schema >> >> On 17/05/2022 14:55, Smitha T Murthy wrote: >>> Adds DT schema for s5p-mfc in yaml format. >>> >> >> Thank you for your patch. There is something to discuss/improve. >> > > Thank you for the review. > You responded after two months, I don't remember what I reviewed... Two months periods between resends do not really help to usptream. > >>> + compatible = "samsung,mfc-v12"; >> >> Does not look like you tested the bindings. Please run `make >> dt_binding_check` (see Documentation/devicetree/bindings/writing- >> schema.rst for instructions). >> Be sure to test your bindings before sending them. >> > > I did do make dtbs and dt_binding_check using v2022.3, I will recheck post these changes. > >>> + reg = <0x12880000 0x10000>; >>> + clock-names = "mfc"; >>> + interrupts = <0 137 4>; >> >> Use interrupt defines. >> > > When I use interrupt defines I get errors as "1. Syntax error: This was due to interrupts field has some macro reference and needed to give absolute value.", hence I gave absolute values. Look at other DT schema files... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel