From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA39C76186 for ; Tue, 23 Jul 2019 21:31:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8D06218D4 for ; Tue, 23 Jul 2019 21:30:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UDGFNfly"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="KhQICRUG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8D06218D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L/CwZCUBY6cvHf5zONF5z9jKUM2axLdhjjQO+KAndww=; b=UDGFNflyqkUi/s ujEo6fg/YrKV57xvwf8qYoCV67hgJ7lum4gi4bYt9iDLQ2jfqwp6IgLhRn+oL0QBWauxTGUuz5ps/ p4TdQOqn7mpjREnuCBoPeW6wDnmG64giBmqf30wKINzuSh/8owLsI4pd/SMgFEQIl5wxzyPZfsKaY UmJ11QhaelTb1Or4ML4405hd0Nvu5/Fn2dVrV+WocdIJj+76t6a6dhNLwrl0IS3mzzexrwI4rKlSM aPXp0zOowYvHsBgd2KjUemKIKpn5esdFtwiyw9f/5Y4/h5LSo/5AXIoCj4UshIR4rykNsUfa90EsL zSYEpj+ICCx8o2FtYZLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hq2N4-0001iD-JL; Tue, 23 Jul 2019 21:30:54 +0000 Received: from mout.gmx.net ([212.227.15.19]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hq2N0-0001hT-D6; Tue, 23 Jul 2019 21:30:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1563917424; bh=ejmFng2QjFZzODfS2qj9F1WGpZClOx2oEip4jXKXfLg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=KhQICRUGnpMroAUN9bMGoFAiKs2W9E2tGHu6Fs+4eKbsl+vLpuasSvqOYWReOMlVk iRBnSu3k5B9dkq0nt+muwwonElzVPN4pcN0Y8cxig5ebLhgC4+oeXcDdeNZ59g/uE9 bBokIl0yvHTOyiC3llykGWwU8v4H/4z/UuSmSZL8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.162] ([37.4.249.115]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MRoRF-1i0eO90v29-00Szrl; Tue, 23 Jul 2019 23:30:24 +0200 Subject: Re: [PATCH 00/18] ARM: Add minimal Raspberry Pi 4 support To: Nicolas Saenz Julienne , Christoph Hellwig References: <1563774880-8061-1-git-send-email-wahrenst@gmx.net> <96113adb5fcab9c2f4bb5fa82b84ff5f9c07fd07.camel@suse.de> <20190723093442.GA27239@lst.de> <04c5eaa03f3a124dbbce6186e11e19acc4539cc8.camel@suse.de> <5f9b11f54c66fd0487837f7e58af3adf7f86635f.camel@suse.de> From: Stefan Wahren Message-ID: <9937cd58-3921-6b9a-b099-d0aa28035e50@gmx.net> Date: Tue, 23 Jul 2019 23:30:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <5f9b11f54c66fd0487837f7e58af3adf7f86635f.camel@suse.de> Content-Language: en-US X-Provags-ID: V03:K1:h2GW857+HHTVqkW+oDI5RfOm9FP83HJJ2yxHRbtE5rJoQxezczw Wuwd8SC6/iENm9aR9BHzJpuB1fU2478xlX+4cj+41G/S0AJxwfF2RaXcHIRyelsmEYCmufb nJ8/h0+/cugBOYLIgUi5qV/bcil22OcfL+13jKc6VqlQArcnCkWEkDSbMGmUKVJ3Sixr15a RwQP2MgNj+kyhHOIqweXQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:X6lONT7HRJE=:3VdJQ7wGC4XyDSK+2LwGQc pu2k+EhXu7HX3jK3ERBqsXTsdyZz7F0XW3QIYftleBKvSpifQe4hCl/H/Y5Ftp3brudMf2rBR w9boe0ayy2kbcTJEoK4pIsAWz1c7CnmqmRYedJzDQTF52b5ppUvAlF1ggZKumElHCsCnPGEvv +HuMnfUP8JrYVS+dMj1PUmgNfdwwUKNJ0cNwWO1BcTWA5s2dLLlHzWSlgGiMSx09OmSyeGMmv TpA3mdefgFDM8qpXX3KWgn/B5DcDB01EdNAh62CwPbtZms6OQX8qYz0AWgYaix2kqTZ1s6sbb Bq2X7xyigwZ5twinM7R21UrMRfjbKNLV8cu2D4zlQZFwO373E/xvPwsP1S22EZ4UNKWrYCph1 Y+8XoY7i4neM0NQqOP3UIhGGuwu2wF3SLoXNIc0bqaldHV5QsD300KmY6lw+P4IVnNxR0tvFI 85eTEtRmq75ux7aIpbcoFAsjJge8yzz39KVjrxEP9vsrf0IoHM9UOQsRUpxfckLeo0BUMTd27 kxcy2ohbGZbQc3JDvyfwPl6OO2YgDXEneeVgCDZ8zOgtTyAdH1kNMZ/1sxQU2T6aK3BhUEyL+ QvVGHWaFgf2wmQ5Ej/Ucaq+uEB1b/nbew2dGCKx5N/uLhbtZE22gq3R0Xq9UZn/ol5JEAOhpW 1LOLrVP/HyMmFCdEsBH4EPo893iflo2MJCD6SL40+rtIKO5EtMYo9j3jlRJIJ+xCvXOpC9C0d zw6liixe+pjKyQcqADrT+f2cWph7VH6WgiVzjYV30mC6B7t+ncWhXWJxKQiTpt6BZ6BRW0+3C SzDhqPl+b2+0+BUAay9TqwiaGIF9tqZPWaauCAmzmwSrMkbaNffd6PF/6bz3/XyCuzrJVmLj6 Qx6ITKBeMtXFltrX7OUEJCcU/SOGWvZOK+zQVeDDopEXAa+lax5LRGYVkdt2H+oqiA1/FVAzw VbjeChRDCF3YIKoqISNy8eHdl2VQWEqo7VLQBTn6JgQbGqWwE2r3I0pUzWjKzc+shFDnO232G gPBtmfjl63CAPNrl2pqTpgQjPneuIeJ5Jr5pQQP5q6rC/vWFcsAUHMhmI0gOD3nava8z4D+QS s9pi5+QkGHNj3U= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190723_143050_738475_6CC22799 X-CRM114-Status: GOOD ( 18.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ulf Hansson , Florian Fainelli , Scott Branden , Matthias Brugger , Stephen Boyd , Ray Jui , Linus Walleij , linux-mmc@vger.kernel.org, Adrian Hunter , Eric Anholt , Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Michael Turquette , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nicolas, Am 23.07.19 um 19:33 schrieb Nicolas Saenz Julienne: > On Tue, 2019-07-23 at 18:26 +0200, Stefan Wahren wrote: >> Hi Nicolas, >> >> thanks for your work, but i'm a little bit sceptical about these >> changes. So here some thoughts. >> >> Am 23.07.19 um 15:32 schrieb Nicolas Saenz Julienne: >>> On Tue, 2019-07-23 at 11:34 +0200, Christoph Hellwig wrote: >>>> On Mon, Jul 22, 2019 at 08:10:17PM +0200, Stefan Wahren wrote: >>>>> i rebased this series also and got this only on the RPi 4. >>>>> >>>>> After reverting the following: >>>>> >>>>> 79a986721de dma-mapping: remove dma_max_pfn >>>>> 7559d612dff0 mmc: core: let the dma map ops handle bouncing >>>>> >>>>> This crash disappear, but wifi seems to be still broken. >>>>> >>>>> Would be nice, if you can investigate further. >>>> That means dma addressing on this system doesn't just work for some >>>> memory, and the mmc bounce buffering was papering over that just for >>>> mmc. Do you have highmem on this system? >>>> >>>> You might want to try this series, which has been submitted upstream: >>>> >>>> > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/arm-swiotlb >>> Hi Christoph, >>> I tried your series on top of Stefan's, it has no effect. I guess it's no >>> surprise as with mult_v7_defconfig, you get SWIOTLB=n & LPAE=n. >>> >>> FYI DMA addressing constraints for RPi4 are the following: devices can only >>> access the first GB of ram even though the board might have up to 4GB of >>> ram. >>> The DMA addresses are aliased with a 0xc0000000 offset. So 0x00000000 phys >>> is >>> aliased to 0xc0000000 in DMA. This is the same as for an RFC you commented >>> last >>> week trying to fix similar issues for arm64. >>> >>> You state in "arm: use swiotlb for bounce buffer on LPAE configs" that "The >>> DMA >>> API requires that 32-bit DMA masks are always supported". If I understand it >>> correctly this device breaks that assumption. Which implies we need a bounce >>> buffer system in place for any straming DMA user. >>> >>> It seems we're unable to use dma-direct/swiotlb, so I enabled arm's >>> dmabounce >>> on all devices hooked into RPi's limited interconnect, which fixes this >>> issue. >> Does it fix the wifi issue too? > Well it works as long as I revert this: 901bb98918 ("nl80211: require and > validate vendor command policy"). Which has nothing to do with DMA anyways. > > Was this the issue you where seeing? Yes. So it's a regression? I will try to test it with a RPi 3B+ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel